From: "Thomas Weißschuh" <linux@weissschuh.net>
To: "Mickaël Salaün" <mic@digikod.net>,
"David Howells" <dhowells@redhat.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Jarkko Sakkinen" <jarkko@kernel.org>,
"Eric Snowberg" <eric.snowberg@oracle.com>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
"Mark Pearson" <markpearson@lenovo.com>,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: [PATCH v2 1/3] certs: log more information on blacklist error
Date: Wed, 9 Nov 2022 03:50:17 +0100 [thread overview]
Message-ID: <20221109025019.1855-2-linux@weissschuh.net> (raw)
In-Reply-To: <20221109025019.1855-1-linux@weissschuh.net>
Without this information these logs are not actionable.
Fixes: 6364d106e041 ("certs: Allow root user to append signed hashes to the blacklist keyring")
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
certs/blacklist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/certs/blacklist.c b/certs/blacklist.c
index 41f10601cc72..6e260c4b6a19 100644
--- a/certs/blacklist.c
+++ b/certs/blacklist.c
@@ -192,7 +192,7 @@ static int mark_raw_hash_blacklisted(const char *hash)
KEY_ALLOC_NOT_IN_QUOTA |
KEY_ALLOC_BUILT_IN);
if (IS_ERR(key)) {
- pr_err("Problem blacklisting hash (%ld)\n", PTR_ERR(key));
+ pr_err("Problem blacklisting hash %s: %pe\n", hash, key);
return PTR_ERR(key);
}
return 0;
--
2.38.1
next prev parent reply other threads:[~2022-11-09 2:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 2:50 [PATCH v2 0/3] certs: Prevent spurious errors on repeated blacklisting Thomas Weißschuh
2022-11-09 2:50 ` Thomas Weißschuh [this message]
2022-11-15 23:54 ` [PATCH v2 1/3] certs: log more information on blacklist error Jarkko Sakkinen
2022-11-09 2:50 ` [PATCH v2 2/3] KEYS: Add key_create() Thomas Weißschuh
2022-11-16 0:21 ` Jarkko Sakkinen
2022-11-09 2:50 ` [PATCH v2 3/3] certs: don't try to update blacklist keys Thomas Weißschuh
2022-11-15 23:56 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109025019.1855-2-linux@weissschuh.net \
--to=linux@weissschuh.net \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=eric.snowberg@oracle.com \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=markpearson@lenovo.com \
--cc=mic@digikod.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).