Linux Security Modules development
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serge@hallyn.com>
To: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: serge@hallyn.com, linux-security-module@vger.kernel.org
Subject: Re: [PATCH -next] capability: fix kernel-doc warnings in capability.c
Date: Thu, 11 May 2023 00:25:27 -0500	[thread overview]
Message-ID: <20230511052527.GA115075@mail.hallyn.com> (raw)
In-Reply-To: <20230511012715.3692211-1-cuigaosheng1@huawei.com>

On Thu, May 11, 2023 at 09:27:15AM +0800, Gaosheng Cui wrote:
> Fix all kernel-doc warnings in capability.c:
> 
> kernel/capability.c:477: warning: Function parameter or member 'idmap'
> not described in 'privileged_wrt_inode_uidgid'
> kernel/capability.c:493: warning: Function parameter or member 'idmap'
> not described in 'capable_wrt_inode_uidgid'
> 
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>

Acked-by: Serge Hallyn <serge@hallyn.com>

> ---
>  kernel/capability.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/capability.c b/kernel/capability.c
> index 3e058f41df32..1a2795102ae4 100644
> --- a/kernel/capability.c
> +++ b/kernel/capability.c
> @@ -467,6 +467,7 @@ EXPORT_SYMBOL(file_ns_capable);
>  /**
>   * privileged_wrt_inode_uidgid - Do capabilities in the namespace work over the inode?
>   * @ns: The user namespace in question
> + * @idmap: idmap of the mount @inode was found from
>   * @inode: The inode in question
>   *
>   * Return true if the inode uid and gid are within the namespace.
> @@ -481,6 +482,7 @@ bool privileged_wrt_inode_uidgid(struct user_namespace *ns,
>  
>  /**
>   * capable_wrt_inode_uidgid - Check nsown_capable and uid and gid mapped
> + * @idmap: idmap of the mount @inode was found from
>   * @inode: The inode in question
>   * @cap: The capability in question
>   *
> -- 
> 2.25.1

  reply	other threads:[~2023-05-11  5:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-11  1:27 [PATCH -next] capability: fix kernel-doc warnings in capability.c Gaosheng Cui
2023-05-11  5:25 ` Serge E. Hallyn [this message]
2023-05-19 20:58   ` Paul Moore
2023-05-22 17:41     ` Serge E. Hallyn
2023-05-22 18:31       ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230511052527.GA115075@mail.hallyn.com \
    --to=serge@hallyn.com \
    --cc=cuigaosheng1@huawei.com \
    --cc=linux-security-module@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox