From: Jeff Layton <jlayton@kernel.org>
To: Christian Brauner <brauner@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Brad Warrum <bwarrum@linux.ibm.com>,
Ritu Agarwal <rituagar@linux.ibm.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ian Kent <raven@themaw.net>,
"Tigran A. Aivazian" <aivazian.tigran@gmail.com>,
Jeremy Kerr <jk@ozlabs.org>, Ard Biesheuvel <ardb@kernel.org>,
Namjae Jeon <linkinjeon@kernel.org>,
Sungjong Seo <sj1557.seo@samsung.com>,
Steve French <sfrench@samba.org>,
Paulo Alcantara <pc@manguebit.com>,
Ronnie Sahlberg <lsahlber@redhat.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>,
John Johansen <john.johansen@canonical.com>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Ruihan Li <lrh2000@pku.edu.cn>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Alan Stern <stern@rowland.harvard.edu>,
Suren Baghdasaryan <surenb@google.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
autofs@vger.kernel.org, linux-efi@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-cifs@vger.kernel.org,
samba-technical@lists.samba.org, apparmor@lists.ubuntu.com,
linux-security-module@vger.kernel.org
Subject: [PATCH v2 2/8] usb: update the ctime as well when updating mtime after an ioctl
Date: Mon, 12 Jun 2023 06:45:18 -0400 [thread overview]
Message-ID: <20230612104524.17058-3-jlayton@kernel.org> (raw)
In-Reply-To: <20230612104524.17058-1-jlayton@kernel.org>
In general, POSIX requires that when the mtime is updated that the ctime
be updated as well. Add the missing timestamp updates to the usb ioctls.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
drivers/usb/core/devio.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index fcf68818e999..1268d313a8df 100644
--- a/drivers/usb/core/devio.c
+++ b/drivers/usb/core/devio.c
@@ -2640,21 +2640,21 @@ static long usbdev_do_ioctl(struct file *file, unsigned int cmd,
snoop(&dev->dev, "%s: CONTROL\n", __func__);
ret = proc_control(ps, p);
if (ret >= 0)
- inode->i_mtime = current_time(inode);
+ inode->i_mtime = inode->i_ctime = current_time(inode);
break;
case USBDEVFS_BULK:
snoop(&dev->dev, "%s: BULK\n", __func__);
ret = proc_bulk(ps, p);
if (ret >= 0)
- inode->i_mtime = current_time(inode);
+ inode->i_mtime = inode->i_ctime = current_time(inode);
break;
case USBDEVFS_RESETEP:
snoop(&dev->dev, "%s: RESETEP\n", __func__);
ret = proc_resetep(ps, p);
if (ret >= 0)
- inode->i_mtime = current_time(inode);
+ inode->i_mtime = inode->i_ctime = current_time(inode);
break;
case USBDEVFS_RESET:
@@ -2666,7 +2666,7 @@ static long usbdev_do_ioctl(struct file *file, unsigned int cmd,
snoop(&dev->dev, "%s: CLEAR_HALT\n", __func__);
ret = proc_clearhalt(ps, p);
if (ret >= 0)
- inode->i_mtime = current_time(inode);
+ inode->i_mtime = inode->i_ctime = current_time(inode);
break;
case USBDEVFS_GETDRIVER:
@@ -2693,7 +2693,7 @@ static long usbdev_do_ioctl(struct file *file, unsigned int cmd,
snoop(&dev->dev, "%s: SUBMITURB\n", __func__);
ret = proc_submiturb(ps, p);
if (ret >= 0)
- inode->i_mtime = current_time(inode);
+ inode->i_mtime = inode->i_ctime = current_time(inode);
break;
#ifdef CONFIG_COMPAT
@@ -2701,14 +2701,14 @@ static long usbdev_do_ioctl(struct file *file, unsigned int cmd,
snoop(&dev->dev, "%s: CONTROL32\n", __func__);
ret = proc_control_compat(ps, p);
if (ret >= 0)
- inode->i_mtime = current_time(inode);
+ inode->i_mtime = inode->i_ctime = current_time(inode);
break;
case USBDEVFS_BULK32:
snoop(&dev->dev, "%s: BULK32\n", __func__);
ret = proc_bulk_compat(ps, p);
if (ret >= 0)
- inode->i_mtime = current_time(inode);
+ inode->i_mtime = inode->i_ctime = current_time(inode);
break;
case USBDEVFS_DISCSIGNAL32:
@@ -2720,7 +2720,7 @@ static long usbdev_do_ioctl(struct file *file, unsigned int cmd,
snoop(&dev->dev, "%s: SUBMITURB32\n", __func__);
ret = proc_submiturb_compat(ps, p);
if (ret >= 0)
- inode->i_mtime = current_time(inode);
+ inode->i_mtime = inode->i_ctime = current_time(inode);
break;
case USBDEVFS_IOCTL32:
--
2.40.1
next prev parent reply other threads:[~2023-06-12 10:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 10:45 [PATCH v2 0/8] fs: add some missing ctime updates Jeff Layton
2023-06-12 10:45 ` [PATCH v2 1/8] ibmvmc: update ctime in conjunction with mtime on write Jeff Layton
2023-06-12 10:45 ` Jeff Layton [this message]
2023-06-12 10:45 ` [PATCH v2 3/8] autofs: set ctime as well when mtime changes on a dir Jeff Layton
2023-06-13 7:16 ` Ian Kent
2023-06-14 8:30 ` (subset) " Christian Brauner
2023-06-15 10:14 ` Ian Kent
2023-06-12 10:45 ` [PATCH v2 4/8] bfs: update ctime in addition to mtime when adding entries Jeff Layton
2023-06-12 10:45 ` [PATCH v2 5/8] efivarfs: update ctime when mtime changes on a write Jeff Layton
2023-06-12 10:45 ` [PATCH v2 6/8] exfat: ensure that ctime is updated whenever the mtime is Jeff Layton
2023-06-12 10:45 ` [PATCH v2 7/8] apparmor: update ctime whenever the mtime changes on an inode Jeff Layton
2023-06-12 10:45 ` [PATCH v2 8/8] cifs: update the ctime on a partial page write Jeff Layton
2023-06-12 13:41 ` Tom Talpey
2023-06-12 13:51 ` Jeff Layton
2023-08-30 0:08 ` [PATCH v2 0/8] fs: add some missing ctime updates Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612104524.17058-3-jlayton@kernel.org \
--to=jlayton@kernel.org \
--cc=aivazian.tigran@gmail.com \
--cc=apparmor@lists.ubuntu.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=autofs@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=bwarrum@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jk@ozlabs.org \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lrh2000@pku.edu.cn \
--cc=lsahlber@redhat.com \
--cc=paul@paul-moore.com \
--cc=pc@manguebit.com \
--cc=raven@themaw.net \
--cc=rituagar@linux.ibm.com \
--cc=samba-technical@lists.samba.org \
--cc=sebastian.reichel@collabora.com \
--cc=serge@hallyn.com \
--cc=sfrench@samba.org \
--cc=sj1557.seo@samsung.com \
--cc=sprasad@microsoft.com \
--cc=stern@rowland.harvard.edu \
--cc=surenb@google.com \
--cc=tom@talpey.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).