From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9FB9EB64DB for ; Tue, 13 Jun 2023 19:47:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233024AbjFMTrb (ORCPT ); Tue, 13 Jun 2023 15:47:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbjFMTra (ORCPT ); Tue, 13 Jun 2023 15:47:30 -0400 Received: from mail-oo1-xc32.google.com (mail-oo1-xc32.google.com [IPv6:2607:f8b0:4864:20::c32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7717612A for ; Tue, 13 Jun 2023 12:47:28 -0700 (PDT) Received: by mail-oo1-xc32.google.com with SMTP id 006d021491bc7-55b171c1e16so4165756eaf.1 for ; Tue, 13 Jun 2023 12:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1686685648; x=1689277648; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/WhOeElaMsiD9GyeVbS/Kz/uOr4hArVsc6evONFkFnM=; b=aeMNEMT7mnAhLHospPJ5V6vIYNCAcophNZar1VJgpYHxyFURQMMgUNDfiKxbq31qUx /ntMLDU6dIgcpzP5jt5szoYlfgJOQ930p726r6qPC78stOnaYjfEWHjjMU58XMpu3dyx I1eRXxTLecm0sTZY+o9wNW2LEqaDO5EnnyJcs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686685648; x=1689277648; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/WhOeElaMsiD9GyeVbS/Kz/uOr4hArVsc6evONFkFnM=; b=ft/wbeiPVzYQPtqZ0Or2SOLa9VQ6XkmK/4ckh7Lk5eAWwQ50R7dohj+6NkZldZnziH D7fBZDBUaNyudWAHvoNd/PYEVNH3LOvuwiWo2URkzvgLxJrkaaJzp2AL7FOIRPiZAxWO ml0hYdpYNKvuaFgAU4EkCmNfv6nESZ5WN87NZWpwieRXHlD1OwaWjwOjniB8/q6xtGeh /1qgBW3W3OkQThJwPokjRuNcb+q4iC40IhJlqgGvnGrlFPiIaO1g6TUB55z5semBu4Yr KnQg0GPhLx2GsznKQwn0biTQXZFLwbb4zZpS21Q3Q9seAgwXNcANzKIpIovFg261YrOG asxA== X-Gm-Message-State: AC+VfDxlWlGCHcTTvYFelQ0/DQyDaDfCS5s0TZm9YOo19RtMWfNmp8qV Pf5MBWk+n+RO3OHOl/IV+Davbw== X-Google-Smtp-Source: ACHHUZ4U6UYeRfCrOKo1DH+SSAGfrV+G9PiakEqQJES8KDmPF0FcGGIFWyujt3k8m3pdnsxYnXqlng== X-Received: by 2002:aca:d0c:0:b0:398:c4ec:63bc with SMTP id 12-20020aca0d0c000000b00398c4ec63bcmr7585125oin.43.1686685647840; Tue, 13 Jun 2023 12:47:27 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id k67-20020a632446000000b005439aaf0301sm9683107pgk.64.2023.06.13.12.47.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 12:47:27 -0700 (PDT) Date: Tue, 13 Jun 2023 12:47:26 -0700 From: Kees Cook To: Peter Zijlstra Cc: torvalds@linux-foundation.org, gregkh@linuxfoundation.org, pbonzini@redhat.com, masahiroy@kernel.org, nathan@kernel.org, ndesaulniers@google.com, nicolas@fjasle.eu, catalin.marinas@arm.com, will@kernel.org, vkoul@kernel.org, trix@redhat.com, ojeda@kernel.org, mingo@redhat.com, longman@redhat.com, boqun.feng@gmail.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, irogers@google.com, adrian.hunter@intel.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, paulmck@kernel.org, frederic@kernel.org, quic_neeraju@quicinc.com, joel@joelfernandes.org, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, rientjes@google.com, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, john.johansen@canonical.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, llvm@lists.linux.dev, linux-perf-users@vger.kernel.org, rcu@vger.kernel.org, linux-security-module@vger.kernel.org, tglx@linutronix.de, ravi.bangoria@amd.com, error27@gmail.com, luc.vanoostenryck@gmail.com Subject: Re: [PATCH v3 45/57] perf: Simplify perf_event_parse_addr_filter() Message-ID: <202306131247.3E617931@keescook> References: <20230612090713.652690195@infradead.org> <20230612093540.779825032@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612093540.779825032@infradead.org> Precedence: bulk List-ID: On Mon, Jun 12, 2023 at 11:07:58AM +0200, Peter Zijlstra wrote: > XXX this code needs a cleanup :) > > Signed-off-by: Peter Zijlstra (Intel) > --- > kernel/events/core.c | 56 ++++++++++++++++++++------------------------------- > 1 file changed, 22 insertions(+), 34 deletions(-) > > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -10495,6 +10495,8 @@ static void free_filters_list(struct lis > } > } > > +DEFINE_FREE(filter_list, struct list_head *, if (_T) free_filters_list(_T)) > + > /* > * Free existing address filters and optionally install new ones > */ > @@ -10658,13 +10660,15 @@ perf_event_parse_addr_filter(struct perf > struct list_head *filters) > { > struct perf_addr_filter *filter = NULL; > - char *start, *orig, *filename = NULL; > substring_t args[MAX_OPT_ARGS]; > int state = IF_STATE_ACTION, token; > unsigned int kernel = 0; > - int ret = -EINVAL; > + char *start; > + int ret; > > - orig = fstr = kstrdup(fstr, GFP_KERNEL); > + struct list_head *fguard __free(filter_list) = filters; > + char *filename __free(kfree) = NULL; > + char *orig __free(kfree) = fstr = kstrdup(fstr, GFP_KERNEL); Ah! I see a kfree users. Sorry for the noise. :) -- Kees Cook