From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62798EB64D9 for ; Tue, 27 Jun 2023 19:49:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230323AbjF0TtN (ORCPT ); Tue, 27 Jun 2023 15:49:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230422AbjF0TtF (ORCPT ); Tue, 27 Jun 2023 15:49:05 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7A692953; Tue, 27 Jun 2023 12:48:45 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3fa96fd79feso31141395e9.2; Tue, 27 Jun 2023 12:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687895324; x=1690487324; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=7pY77BX0Bjm/AG7DKW+7YePblMuDF5/88esr4ObIklU=; b=ldzpV7TNtqMRq9y/b72mmwbatQnKd0ZJdsBOP2Ex0kCOpEYiiBIOEvMX5Ro45A2zS3 HDUeO4NMjVxwbYSM/sKj2DIIFfxGFZBSYA8dlvs1Z5F49RhBIjMo/GfI5Sdb8Ah2iehp B4EYj26TKWYeDOmJaTXwcI2aAEYNuXgOO8go53FqhBoipL8+vQsuZwxqUHvq8IBytQA6 6jG/J/Yal9ojlGirFo61Atum21QrD1NKTHQJKqiKKW53zPwPXR2uIhiPonXXbiyx6rpj pscMrDFFBmxc3qJ2mwn5huR9kdigIkrY4/iBU/sjhwjsPYQ36F2C/2OHYH30eBpPVAR2 0zWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687895324; x=1690487324; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7pY77BX0Bjm/AG7DKW+7YePblMuDF5/88esr4ObIklU=; b=e8kNP6aW+USX4Y/RHhQTaZgMgsuoEvOvWtG9t+883GWHvu8YH4pUlxPpif5Gux52CV ACvpm8x7W4envu4f05Pj6nFko0EF+xqch6FhLmuMl7p+gu3EvD6W8F3u0wFprH860DgY YkO55NWJECgG/M8JK6CUzLwg0BVofJVNmXDCobu4l81y67HAaieshCxxXAo0wHRKobri vbdRNbVt2H+SV2iM2iuux6jzQGhuiQKJpezqmJ8afoASS/l6FEKVKwrcCIvrjhpTOu05 djrVlPDY80q5QcKvcYT4BXDukukoiQLCm//GjyTh6tEMiKylj2FB+bHRDUw/CApn9oii qykw== X-Gm-Message-State: AC+VfDze18OTOnPBYBqFF3MphqJquvFd4blbPYUqs/2VaSkP5gHBY1Fk q+h3uLYWhFgAdYcCbytq/iE= X-Google-Smtp-Source: ACHHUZ47C+lWtGTBCwu5KgZvIz28Mq3oGaWnE0/qfgjO5jNdPVrvAxxQeRNXNFDTqrh25iufnRHlFA== X-Received: by 2002:adf:e711:0:b0:313:efed:9162 with SMTP id c17-20020adfe711000000b00313efed9162mr6149433wrm.59.1687895323905; Tue, 27 Jun 2023 12:48:43 -0700 (PDT) Received: from localhost ([2a02:168:633b:1:9d6a:15a4:c7d1:a0f0]) by smtp.gmail.com with ESMTPSA id p12-20020a5d638c000000b00313f61889e9sm5260340wru.36.2023.06.27.12.48.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 12:48:43 -0700 (PDT) Date: Tue, 27 Jun 2023 21:48:36 +0200 From: =?iso-8859-1?Q?G=FCnther?= Noack To: Konstantin Meskhidze Cc: mic@digikod.net, willemdebruijn.kernel@gmail.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, yusongping@huawei.com, artem.kuzin@huawei.com Subject: Re: [PATCH v11 08/12] landlock: Add network rules and TCP hooks support Message-ID: <20230627.82cde73b1efe@gnoack.org> References: <20230515161339.631577-1-konstantin.meskhidze@huawei.com> <20230515161339.631577-9-konstantin.meskhidze@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230515161339.631577-9-konstantin.meskhidze@huawei.com> Precedence: bulk List-ID: On Tue, May 16, 2023 at 12:13:35AM +0800, Konstantin Meskhidze wrote: > +static int add_rule_net_service(struct landlock_ruleset *ruleset, > + const void __user *const rule_attr) > +{ > +#if IS_ENABLED(CONFIG_INET) > + struct landlock_net_service_attr net_service_attr; > + int res; > + access_mask_t mask; > + > + /* Copies raw user space buffer, only one type for now. */ Nit, which I came across by accident: I believe the remark "only one type for now" referred to the fact that path_beneath_attr was the only rule type up until now - but that is not true any more. Please adapt the wording also in add_rule_path_beneath, where the same comment exists. –Günther