From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBC11EB64D9 for ; Thu, 6 Jul 2023 14:57:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233682AbjGFO5i (ORCPT ); Thu, 6 Jul 2023 10:57:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233681AbjGFO5h (ORCPT ); Thu, 6 Jul 2023 10:57:37 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E37C01FC1; Thu, 6 Jul 2023 07:57:30 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 959A521F0F; Thu, 6 Jul 2023 14:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688655449; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZG+yQQJdnTV+AQwujFyahCM3o0U4xKQmURYi/IL3qyQ=; b=XjKAD8TZ0Q9XglDxur0hXsiR05GFB540k75NNjyO0hXyQTxSFiFxTneOXTUfG5Tr6NcqKV +lWMLppymZqm9xZFi9SVsx7i2ah4JFLxVFhw+TJjwMbDldXZPi58p8qotTwet5GHg1hsCY PQ8CjgoTUTOPlPUsGuxajkXPzizau1Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688655449; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZG+yQQJdnTV+AQwujFyahCM3o0U4xKQmURYi/IL3qyQ=; b=KnLY85SmG704S4MFl2eaBzn7h/xYSUkzL9ONq3uzng9KE7i/ULtQoU3foVmvmDqviU2E2E M8Dy1gds+lY9p8BA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 84D11138FC; Thu, 6 Jul 2023 14:57:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uENpIFnWpmTkBQAAMHmgww (envelope-from ); Thu, 06 Jul 2023 14:57:29 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id ECC3DA0707; Thu, 6 Jul 2023 16:57:28 +0200 (CEST) Date: Thu, 6 Jul 2023 16:57:28 +0200 From: Jan Kara To: Jeff Layton Cc: Christian Brauner , Paul Moore , James Morris , "Serge E. Hallyn" , Al Viro , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH v2 90/92] security: convert to ctime accessor functions Message-ID: <20230706145728.tbm667mjluyxesjn@quack3> References: <20230705185755.579053-1-jlayton@kernel.org> <20230705190309.579783-1-jlayton@kernel.org> <20230705190309.579783-88-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230705190309.579783-88-jlayton@kernel.org> Precedence: bulk List-ID: On Wed 05-07-23 15:01:55, Jeff Layton wrote: > In later patches, we're going to change how the inode's ctime field is > used. Switch to using accessor functions instead of raw accesses of > inode->i_ctime. > > Acked-by: Paul Moore > Signed-off-by: Jeff Layton Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > security/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/inode.c b/security/inode.c > index 6c326939750d..3aa75fffa8c9 100644 > --- a/security/inode.c > +++ b/security/inode.c > @@ -145,7 +145,7 @@ static struct dentry *securityfs_create_dentry(const char *name, umode_t mode, > > inode->i_ino = get_next_ino(); > inode->i_mode = mode; > - inode->i_atime = inode->i_mtime = inode->i_ctime = current_time(inode); > + inode->i_atime = inode->i_mtime = inode_set_ctime_current(inode); > inode->i_private = data; > if (S_ISDIR(mode)) { > inode->i_op = &simple_dir_inode_operations; > -- > 2.41.0 > -- Jan Kara SUSE Labs, CR