From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-security-module-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id F3364E936F7
	for <linux-security-module@archiver.kernel.org>; Thu,  5 Oct 2023 02:27:16 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233703AbjJEC1R (ORCPT
        <rfc822;linux-security-module@archiver.kernel.org>);
        Wed, 4 Oct 2023 22:27:17 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39126 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S232583AbjJEC1Q (ORCPT
        <rfc822;linux-security-module@vger.kernel.org>);
        Wed, 4 Oct 2023 22:27:16 -0400
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CCA7BF;
        Wed,  4 Oct 2023 19:27:13 -0700 (PDT)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3366AC433C7;
        Thu,  5 Oct 2023 02:27:10 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1696472832;
        bh=Dc7ed0EpqwHKkV+keuyjFNWgolgsWB/My9A+mXFzLVk=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=ielImPInTS8NqY7+g3fPoGycU7A+M62lI7bXjJFPd5Juc7UwVPS0KCS1hJyHORAG/
         ZIC9LbRX7VFpbygRKJ2nubq2i8IgOqlctlcSuckd8fnqwbr3JkLQQXaKkzavQn/SfV
         im1J8A6ugi5p+Lc58jcl6+mJcPutLhpJzqMl5LWhgAbkvyqsG7AysOAmrzYeDq0kio
         p/LBsjBRnjJJHpkIySOI6RU25krmm+qvqeVU0ZTCHXhCo0X5vTlS1xf/E/0Sx+tAci
         Zlr9Q/FUViD0+dTQ0sP5LE8K247pGaWhe5C9XlZsn1wAkNcXjeKd+hqSD2tHFgcDJD
         btFp5u9R1ENkg==
Date:   Wed, 4 Oct 2023 22:27:07 -0400
From:   Eric Biggers <ebiggers@kernel.org>
To:     Fan Wu <wufan@linux.microsoft.com>
Cc:     corbet@lwn.net, zohar@linux.ibm.com, jmorris@namei.org,
        serge@hallyn.com, tytso@mit.edu, axboe@kernel.dk, agk@redhat.com,
        snitzer@kernel.org, eparis@redhat.com, paul@paul-moore.com,
        linux-doc@vger.kernel.org, linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        linux-fscrypt@vger.kernel.org, linux-block@vger.kernel.org,
        dm-devel@redhat.com, audit@vger.kernel.org,
        roberto.sassu@huawei.com, linux-kernel@vger.kernel.org,
        Deven Bowers <deven.desai@linux.microsoft.com>
Subject: Re: [RFC PATCH v11 15/19] fsverity: consume builtin signature via
 LSM hook
Message-ID: <20231005022707.GA1688@quark.localdomain>
References: <1696457386-3010-1-git-send-email-wufan@linux.microsoft.com>
 <1696457386-3010-16-git-send-email-wufan@linux.microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1696457386-3010-16-git-send-email-wufan@linux.microsoft.com>
Precedence: bulk
List-ID: <linux-security-module.vger.kernel.org>

On Wed, Oct 04, 2023 at 03:09:42PM -0700, Fan Wu wrote:
> +#ifdef CONFIG_FS_VERITY_BUILTIN_SIGNATURES
> +static int fsverity_inode_setsecurity(struct inode *inode,
> +				      struct fsverity_descriptor *desc)
> +{
> +	return security_inode_setsecurity(inode, FS_VERITY_INODE_SEC_NAME,
> +					  desc->signature,
> +					  le32_to_cpu(desc->sig_size), 0);
> +}

Why isn't the type of the second argument 'const struct fsverity_descriptor *'?

- Eric