* [PATCH] landlock: fix typo in landlock_append_net_rule() stub function
@ 2023-10-17 14:33 Arnd Bergmann
2023-10-17 19:48 ` Mickaël Salaün
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2023-10-17 14:33 UTC (permalink / raw)
To: Mickaël Salaün, Paul Moore, James Morris,
Serge E. Hallyn, Konstantin Meskhidze
Cc: Arnd Bergmann, linux-security-module, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
There is an extraneous semicolon in the empty stub helper for
this function tha causes randconfig builds to break:
In file included from security/landlock/setup.c:17:
security/landlock/net.h:28:1: error: expected identifier or '(' before '{' token
security/landlock/net.h:26:1: error: 'landlock_append_net_rule' declared 'static' but never defined [-Werror=unused-function]
Fixes: 614d46b333ab9 ("landlock: Add network rules and TCP hooks support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
security/landlock/net.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/landlock/net.h b/security/landlock/net.h
index 588a49fd69076..09960c237a13e 100644
--- a/security/landlock/net.h
+++ b/security/landlock/net.h
@@ -24,7 +24,7 @@ static inline void landlock_add_net_hooks(void)
static inline int
landlock_append_net_rule(struct landlock_ruleset *const ruleset, const u16 port,
- access_mask_t access_rights);
+ access_mask_t access_rights)
{
return -EAFNOSUPPORT;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] landlock: fix typo in landlock_append_net_rule() stub function
2023-10-17 14:33 [PATCH] landlock: fix typo in landlock_append_net_rule() stub function Arnd Bergmann
@ 2023-10-17 19:48 ` Mickaël Salaün
0 siblings, 0 replies; 2+ messages in thread
From: Mickaël Salaün @ 2023-10-17 19:48 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Paul Moore, James Morris, Serge E. Hallyn, Konstantin Meskhidze,
Arnd Bergmann, linux-security-module, linux-kernel
Thanks Arnd, I fixed the issue and squashed it in -next.
There will be a next patch series including other fixes.
On Tue, Oct 17, 2023 at 04:33:35PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> There is an extraneous semicolon in the empty stub helper for
> this function tha causes randconfig builds to break:
>
> In file included from security/landlock/setup.c:17:
> security/landlock/net.h:28:1: error: expected identifier or '(' before '{' token
> security/landlock/net.h:26:1: error: 'landlock_append_net_rule' declared 'static' but never defined [-Werror=unused-function]
>
> Fixes: 614d46b333ab9 ("landlock: Add network rules and TCP hooks support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> security/landlock/net.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/landlock/net.h b/security/landlock/net.h
> index 588a49fd69076..09960c237a13e 100644
> --- a/security/landlock/net.h
> +++ b/security/landlock/net.h
> @@ -24,7 +24,7 @@ static inline void landlock_add_net_hooks(void)
>
> static inline int
> landlock_append_net_rule(struct landlock_ruleset *const ruleset, const u16 port,
> - access_mask_t access_rights);
> + access_mask_t access_rights)
> {
> return -EAFNOSUPPORT;
> }
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-17 19:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-17 14:33 [PATCH] landlock: fix typo in landlock_append_net_rule() stub function Arnd Bergmann
2023-10-17 19:48 ` Mickaël Salaün
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).