From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: John Johansen <john.johansen@canonical.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Anil Altinay <aaltinay@google.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
LKLM <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Tomasz Figa <tfiga@chromium.org>,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH v5 0/4] apparmor: cache buffers on percpu list if there is lock, contention
Date: Thu, 26 Oct 2023 14:13:13 +0900 [thread overview]
Message-ID: <20231026051313.GA15694@google.com> (raw)
In-Reply-To: <ffd13862-bc57-45ae-9fd0-454ee2d30fc2@canonical.com>
On (23/10/17 02:21), John Johansen wrote:
> > > yeah, testing help is always much appreciated. I have a v4, and I am
> > > working on 3 alternate version to compare against, to help give a better
> > > sense if we can get away with simplifying or tweak the scaling.
> > >
> > > I should be able to post them out some time tonight.
> >
> > Hi John,
> >
> > Did you get a chance to post v4? I may be able to give it some testing
> > on our real-life case.
>
> sorry yes, how about a v5. That is simplified with 3 follow on patches
> that aren't strictly necessary, but some combination of them might be
> better than just the base patch, but splitting them out makes the
> individual changes easier to review.
Sorry for late reply. So I gave it a try but, apparently, our build
environment has changed quite significantly since the last time I
looked into it.
I don't see that many aa_get/put_buffer() anymore. apparmor buffer
functions are mostly called form the exec path:
security_bprm_creds_for_exec()
apparmor_bprm_creds_for_exec()
make_vfsuid()
aa_get_buffer()
As for vfs_statx()->...->apparmor_inode_getattr()->aa_path_perm(),
that path is bpf_lsm_inode_getsecid() now.
next prev parent reply other threads:[~2023-10-26 5:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 13:19 apparmor: global buffers spin lock may get contended Sergey Senozhatsky
2021-08-15 9:47 ` John Johansen
2022-10-28 9:34 ` John Johansen
2022-10-31 3:52 ` Sergey Senozhatsky
2022-10-31 3:55 ` John Johansen
2022-10-31 4:04 ` Sergey Senozhatsky
2023-02-17 0:03 ` John Johansen
2023-02-17 0:08 ` [PATCH v3] " John Johansen
2023-02-17 10:44 ` Sebastian Andrzej Siewior
2023-02-20 8:42 ` John Johansen
2023-02-21 21:27 ` Anil Altinay
2023-06-26 23:35 ` Anil Altinay
[not found] ` <CACCxZWO-+M-J_enENr7q1WDcu1U8vYFoytqJxAh=x-nuP268zA@mail.gmail.com>
2023-06-27 0:31 ` John Johansen
2023-10-06 4:18 ` Sergey Senozhatsky
2023-10-17 9:21 ` [PATCH v5 0/4] apparmor: cache buffers on percpu list if there is lock, contention John Johansen
2023-10-17 9:23 ` [PATCH v5 1/4] " John Johansen
2023-10-17 9:24 ` [PATCH v5 2/4] apparmor: exponential backoff on cache buffer contention John Johansen
2023-10-17 9:25 ` [PATCH v5 3/4] apparmor: experiment with faster backoff on global buffer John Johansen
2023-10-17 9:26 ` [PATCH v5 4/4] apparmor: limit the number of buffers in percpu cache John Johansen
2023-10-26 5:13 ` Sergey Senozhatsky [this message]
[not found] ` <20221030013028.3557-1-hdanton@sina.com>
2022-10-30 6:32 ` apparmor: global buffers spin lock may get contended John Johansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231026051313.GA15694@google.com \
--to=senozhatsky@chromium.org \
--cc=aaltinay@google.com \
--cc=bigeasy@linutronix.de \
--cc=john.johansen@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).