* [PATCH] apparmor: make stack_msg static
@ 2023-11-22 11:56 Ben Dooks
2024-01-04 9:42 ` John Johansen
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2023-11-22 11:56 UTC (permalink / raw)
To: apparmor; +Cc: linux-security-module, linux-kernel, Ben Dooks
The stack_msg is not exported out of security/apparmor/domain.c so
make it static to avoid the following sparse warning:
security/apparmor/domain.c:1314:12: warning: symbol 'stack_msg' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
security/apparmor/domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/apparmor/domain.c b/security/apparmor/domain.c
index 89fbeab4b33b..571158ec6188 100644
--- a/security/apparmor/domain.c
+++ b/security/apparmor/domain.c
@@ -1311,7 +1311,7 @@ static int change_profile_perms_wrapper(const char *op, const char *name,
return error;
}
-const char *stack_msg = "change_profile unprivileged unconfined converted to stacking";
+static const char *stack_msg = "change_profile unprivileged unconfined converted to stacking";
/**
* aa_change_profile - perform a one-way profile transition
--
2.37.2.352.g3c44437643
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] apparmor: make stack_msg static
2023-11-22 11:56 [PATCH] apparmor: make stack_msg static Ben Dooks
@ 2024-01-04 9:42 ` John Johansen
0 siblings, 0 replies; 2+ messages in thread
From: John Johansen @ 2024-01-04 9:42 UTC (permalink / raw)
To: Ben Dooks, apparmor; +Cc: linux-security-module, linux-kernel
On 11/22/23 03:56, Ben Dooks wrote:
> The stack_msg is not exported out of security/apparmor/domain.c so
> make it static to avoid the following sparse warning:
>
> security/apparmor/domain.c:1314:12: warning: symbol 'stack_msg' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
thankyou for your contribution, unfortunately an the same patch went into apparmor-next on November 11
> ---
> security/apparmor/domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/domain.c b/security/apparmor/domain.c
> index 89fbeab4b33b..571158ec6188 100644
> --- a/security/apparmor/domain.c
> +++ b/security/apparmor/domain.c
> @@ -1311,7 +1311,7 @@ static int change_profile_perms_wrapper(const char *op, const char *name,
> return error;
> }
>
> -const char *stack_msg = "change_profile unprivileged unconfined converted to stacking";
> +static const char *stack_msg = "change_profile unprivileged unconfined converted to stacking";
>
> /**
> * aa_change_profile - perform a one-way profile transition
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-04 9:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-22 11:56 [PATCH] apparmor: make stack_msg static Ben Dooks
2024-01-04 9:42 ` John Johansen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).