From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-42ac.mail.infomaniak.ch (smtp-42ac.mail.infomaniak.ch [84.16.66.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4283E15EB6 for ; Thu, 11 Jan 2024 13:27:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=digikod.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=digikod.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=digikod.net header.i=@digikod.net header.b="mEvfMIL8" Received: from smtp-2-0000.mail.infomaniak.ch (unknown [10.5.36.107]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4T9lp50cJjzMqlwl; Thu, 11 Jan 2024 13:27:25 +0000 (UTC) Received: from unknown by smtp-2-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4T9lp40hDzzMpnPr; Thu, 11 Jan 2024 14:27:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1704979644; bh=NcqqHqbHcG+SCp8ggpuwIKesgMZhBMGU2oOkDWhEbbM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mEvfMIL8w/91vuf2+ilbVcjIHYmM1diMZINM0JzdDDczWXcvNNoaBmlCHuEJQnw3L BF4gtyQax3ytNPKu7AV8CoDCavZzV54n9xTZq2APhQB677qFd/Jar7UulQVKRDVU0Y Ili5KwP5JpLXiJb25B6Fasjvym0M9aOWUuRxGLpk= Date: Thu, 11 Jan 2024 14:27:22 +0100 From: =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= To: Hu Yadi Cc: jmorris@namei.org, serge@hallyn.com, shuah@kernel.org, mathieu.desnoyers@efficios.com, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, 514118380@qq.com, Christian Brauner , linux-fsdevel@vger.kernel.org, Shuah Khan Subject: Re: [PATCH v4] selftests/move_mount_set_group:Make tests build with old libc Message-ID: <20240111.mee0ohZie5he@digikod.net> References: <20240111113229.10820-1-hu.yadi@h3c.com> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240111113229.10820-1-hu.yadi@h3c.com> X-Infomaniak-Routing: alpha On Thu, Jan 11, 2024 at 07:32:29PM +0800, Hu Yadi wrote: > From: "Hu.Yadi" > > Replace SYS_ with __NR_. Using the __NR_ > notation, provided by UAPI, is useful to build tests on systems without > the SYS_ definitions. > > Replace SYS_move_mount with __NR_move_mount > > Similar changes: commit 87129ef13603 ("selftests/landlock: Make tests build with old libc") > > Acked-by: Mickaël Salaün Sorry, it should have been Reviewed-by: Mickaël Salaün Also, this is maintained by the VFS maintainers. I CCed three relevant addresses. > Signed-off-by: Hu.Yadi > Suggested-by: Jiao > Reviewed-by: Berlin > --- > Changes v4 -> v3: > - Adjust comments for consistent > - Add Acked-by > Changes v2 -> v3: > - Adjust comments > Changes v1 -> v2: > - Fix mail of Suggested-by and Reviewed-by > > .../move_mount_set_group/move_mount_set_group_test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/move_mount_set_group/move_mount_set_group_test.c b/tools/testing/selftests/move_mount_set_group/move_mount_set_group_test.c > index 50ed5d475dd1..bcf51d785a37 100644 > --- a/tools/testing/selftests/move_mount_set_group/move_mount_set_group_test.c > +++ b/tools/testing/selftests/move_mount_set_group/move_mount_set_group_test.c > @@ -218,7 +218,7 @@ static bool move_mount_set_group_supported(void) > if (mount(NULL, SET_GROUP_FROM, NULL, MS_SHARED, 0)) > return -1; > > - ret = syscall(SYS_move_mount, AT_FDCWD, SET_GROUP_FROM, > + ret = syscall(__NR_move_mount, AT_FDCWD, SET_GROUP_FROM, > AT_FDCWD, SET_GROUP_TO, MOVE_MOUNT_SET_GROUP); > umount2("/tmp", MNT_DETACH); > > @@ -363,7 +363,7 @@ TEST_F(move_mount_set_group, complex_sharing_copying) > CLONE_VM | CLONE_FILES); ASSERT_GT(pid, 0); > ASSERT_EQ(wait_for_pid(pid), 0); > > - ASSERT_EQ(syscall(SYS_move_mount, ca_from.mntfd, "", > + ASSERT_EQ(syscall(__NR_move_mount, ca_from.mntfd, "", > ca_to.mntfd, "", MOVE_MOUNT_SET_GROUP > | MOVE_MOUNT_F_EMPTY_PATH | MOVE_MOUNT_T_EMPTY_PATH), > 0); > -- > 2.23.0 > >