From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F69E4428 for ; Wed, 21 Feb 2024 00:49:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708476598; cv=none; b=eOAcJf29rnNwxIqsaypqwg34x8S/1sDs53qEZ9GpThaoE2c/2U+meG4Uj2MdDtlJkKU1cgUA6zIJN4jeGDexN5bon48Y0azMnhmcnzy+uHgx935bTQgTXL0EyMZW4rUP9ReT2ocAdHKrZK3eHWhDGaRTli3dDtSj6LQ9WxjAy2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708476598; c=relaxed/simple; bh=70+cboh+R10PUtYIytfNWxwR6L0MddrmKGm16ZtgHKI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VpvMtpeROj3H9LCbZX5zRU+ud/BZIx/L3OICfU5mQRomp/rOUXtg161lRpttzMypU3tfQaC0+p62Fj4WgaOW1AkygZcwC4MWeb9rN8dRnfwHcizdpMgwIToPIlvY+8yFU2naO5LJujAw2BFQe/mSQ5UPDdjzc5sccPdP5wzgazU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=crYWPAsk; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="crYWPAsk" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1d918008b99so50200755ad.3 for ; Tue, 20 Feb 2024 16:49:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708476596; x=1709081396; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aEpA/O0h+RXbPW9lyhYatDMrYbk8elnxsP4c7EZA4p0=; b=crYWPAsku8ZcKPu6VhzjS2X3kK+6ZIvu3grSAe+n19o/qF0Nyoogn1kYP2ZiNZf5rj VjLgVusYRJioAGc0hcVCiWoANzhK0/okSFS+P3gKPQK+4AYe43dWSTRCW5FlFJgqw2XO GUPaob+7mt7FhiFiXkSBn6avtzYY9xe0U9EzA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708476596; x=1709081396; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aEpA/O0h+RXbPW9lyhYatDMrYbk8elnxsP4c7EZA4p0=; b=ImrgkhpTRmei4TIXhKwYwuvIpJGzVkkL7SNzC8+bv34sshGPQeFHs+mLo+dil77Zh9 04Bh/YjLu1ueE5AtUT4YAWl6f/jP2ENhtbdO8ADZ0q5XdA3ERoVCHP7sEIcsjSuNm+Fy w6e1gh/HSkXEk9AhgfVQk4JxZrY5knSEKrXXMS47uHEi8A8Pqhe2i+xUyA91Ja04FnH1 VeceUY6NoIYOpzIfN+FhvZeUGnCbhbeXXGMLRXGnTfGgd329RNePMW0V0qtaayQT8BNp /v+JiUHKZpib2YxQSMLEQDbfxQAMhkp7HHneEEIHc7x0J09ytOzFhIX6CBm/OIOJm+p9 A0RQ== X-Forwarded-Encrypted: i=1; AJvYcCVvqcTeFU0dWxJwf3m8Ci522VsjwnWTAeZagpttj7/zsMYCuwL0vzOLZ5cWjH1MyKkCJQUt3WrmQdJ+ClL5ek22e/49TyLLFnMgJBpYpuQnMYlCB7PI X-Gm-Message-State: AOJu0Yxdn9V1rOxpImeYtvPsHipjQ2Rp5EzFHb4TQKtGFSXgid4kAp8s TXWhrPipsvjiubPv7a5tIuiyHhe2KkD1ra8XnqqZQh96OqrXrpsYb3r0MhDIog== X-Google-Smtp-Source: AGHT+IHN78NFZuTVNdvjx4fisZqXjohZioxW3mJ5Akp/F3MBFBmZREEQJXW39mALAwt/z7vJqe4Htg== X-Received: by 2002:a17:902:c944:b0:1db:cf64:732a with SMTP id i4-20020a170902c94400b001dbcf64732amr11375487pla.62.1708476596356; Tue, 20 Feb 2024 16:49:56 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id x12-20020a170902e04c00b001db86c491e1sm6812758plx.32.2024.02.20.16.49.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 16:49:56 -0800 (PST) Date: Tue, 20 Feb 2024 16:49:55 -0800 From: Kees Cook To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, mic@digikod.net, linux-security-module@vger.kernel.org, jakub@cloudflare.com Subject: Re: [PATCH net-next v3 06/11] selftests: kselftest: add ksft_test_result_code(), handling all exit codes Message-ID: <202402201649.DF5ED3264@keescook> References: <20240220192235.2953484-1-kuba@kernel.org> <20240220192235.2953484-7-kuba@kernel.org> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240220192235.2953484-7-kuba@kernel.org> On Tue, Feb 20, 2024 at 11:22:30AM -0800, Jakub Kicinski wrote: > For generic test harness code it's more useful to deal with exit > codes directly, rather than having to switch on them and call > the right ksft_test_result_*() helper. Add such function to kselftest.h. > > Note that "directive" and "diagnostic" are what ktap docs call > those parts of the message. > > Signed-off-by: Jakub Kicinski Reviewed-by: Kees Cook -- Kees Cook