From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D764D5666 for ; Wed, 21 Feb 2024 00:50:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708476657; cv=none; b=ZhOmPd9lmBzyQ93lJBlWRUm59G1Z7O1In4ARRDwyVi8L+rvrYAIxANWd7HtJYBnyQNIJwa1etMwBzamNgAStmpJddo5997Muc3ACsaQ4axDXAl69gwCPCp+YslSliVVTHC0cs88uLPY47gmkVUIQRktZe/xniMKCsM4QxX3VVmo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708476657; c=relaxed/simple; bh=KtI8YpdPtPNZvgfGsG2RYyLLgUPuNNI+HpwhqX0FHro=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LOSPExY6WkWbOEdchBmDG1vs6+Noq0cyFko7lQ7rSd0LHfWYT/cqy2qOc6e85cT5tuXPnsh5LSDEwEVJd2hFMRnZtL/F09OSlDvX4ILltdDSm6koyZnTqCA1TdNbI8Z/5fAXduXc9MXnQuD976N9nH8Nvf4Z7B/TRfXsTCFyl8E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ereX/gIX; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ereX/gIX" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6da202aa138so51884b3a.2 for ; Tue, 20 Feb 2024 16:50:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708476655; x=1709081455; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IElk/Iax1+PcU/0IwqEjxw3cTNa/0DdIWNZolixvAtE=; b=ereX/gIXiESq449pw9N9E7dYOvH5YqaodkVWsbN0B+dVilQCcZoR7fz1KLpA681/B+ 7oOuVWvQXEueUqKzUyKgXVKMzqvnk8iDtyrIqZt5mBXNTVQF3H4qpqn+DoDsTHf+IW0t ddWoX68kH4k83fp8UhfbSDkeiGIzRqNHI9hlA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708476655; x=1709081455; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IElk/Iax1+PcU/0IwqEjxw3cTNa/0DdIWNZolixvAtE=; b=iw2d2+S1LorwJ4O8UoCo7od9egzLQlvXCu4Y6Yn7tQDjaPP14FcPQNdm8XM2hmQN+k Ac/VsIT2hVVPtpLgn85jjkDnsCGbWxrsDlnoWO0EkwlgpIcnOtE/zDIe/eextD4jr+fK pPOAJ2jcaRT2YgShjY+6OzPdlQU7pvLi64L1BdSvGQY6FxSMQ+A/lKKj8XvggGl5Ofnk sN5nObDXAA+nF1088oI+p5HScYtZTPtVY7O2b+wB5+ZZ6Ph+7QGmWNtyr6R4xdkkNaRU qc76pqHg/2UXRoG7qbqAaGvQmPJKDb/viXKTt9RvoYze9XfEDI6DsoM/49RYaSwogD0E Elaw== X-Forwarded-Encrypted: i=1; AJvYcCVELQ/RaA/WcHLVVhBMaW4dPuL35g+w3YtaQpXMyNmsVmSs20KM/KUlgGygsrLrxrOZms6f71+q5vBpT4P3yCjgZxquLEeCM+NyAIhOdIC8YfqfXOCM X-Gm-Message-State: AOJu0YxSrpOoYbnkfLWfOuBVQILd3e/VM2kfQ3XbWp/80aF8cmXhrohW zO+YBhYd1+3AurMRw8O/cuvVk5ft0xl1vNWfY5fzjBgtD3sq+/y+SBq3+Mr/wA== X-Google-Smtp-Source: AGHT+IFydLljI0+1fERqTi4GrSUTYDSiGotRT/MZd2H3qgqkAeKhRO7bajUjsc33vF1/TfIByoUI4A== X-Received: by 2002:a05:6a00:a8a:b0:6e0:92c2:c3ee with SMTP id b10-20020a056a000a8a00b006e092c2c3eemr19648727pfl.18.1708476655117; Tue, 20 Feb 2024 16:50:55 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id le8-20020a056a004fc800b006e47e57d976sm1924898pfb.166.2024.02.20.16.50.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 16:50:54 -0800 (PST) Date: Tue, 20 Feb 2024 16:50:53 -0800 From: Kees Cook To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, mic@digikod.net, linux-security-module@vger.kernel.org, jakub@cloudflare.com Subject: Re: [PATCH net-next v3 08/11] selftests: kselftest_harness: separate diagnostic message with # in ksft_test_result_code() Message-ID: <202402201650.37FA9A4@keescook> References: <20240220192235.2953484-1-kuba@kernel.org> <20240220192235.2953484-9-kuba@kernel.org> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240220192235.2953484-9-kuba@kernel.org> On Tue, Feb 20, 2024 at 11:22:32AM -0800, Jakub Kicinski wrote: > According to the spec we should always print a # if we add > a diagnostic message. Having the caller pass in the new line > as part of diagnostic message makes handling this a bit > counter-intuitive, so append the new line in the helper. > > Signed-off-by: Jakub Kicinski Reviewed-by: Kees Cook -- Kees Cook