From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37A5784D3C for ; Mon, 25 Mar 2024 13:40:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711374019; cv=none; b=TDtfJfjeFHYOLCcxfxnv1eQRmntdYUbLzPMbDiRJlPD154/eSwfZE0m7YnuewF7EFrdGQP6i5wnclEn5W4y5UUqur9lL92NYNMQUJQwRKYpq2Nvf80T6nd1MvzeQTYcu62yxmLJaA8aWhNWhDGoA7DWC0xmOfVnWd0dNmoKtTzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711374019; c=relaxed/simple; bh=Zui2v1od/elMRFrLL3WvczuYkqdRJ607JihPTYWoBxc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=sglr4Lb53Q6g+gfPzWmR433dfIqqH34usKuBFPBOgRf0zb/lL1AriIUgkZciVyOrFyghV6l/oFkJ3iJAViPyHsQFDKWou/ImYX0YfnRryd2Yl5GmyKsSXGnc6SiSH86X9sCdIAQRwLuqHiZDFiH5M/dsSH1cxj9juymd6GcMTlM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--gnoack.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=upVQwOYC; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--gnoack.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="upVQwOYC" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-60ff1816749so67300037b3.3 for ; Mon, 25 Mar 2024 06:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711374016; x=1711978816; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=l9e1vLBZyU81CA03W1c5FAr2hW3zhJCc3KJ54WTxEPY=; b=upVQwOYCHj60r700MMuQ+H4NjcBrctqiFMaefibbWetnu7wMf1VJsNxTW7AGxtI2zZ Z3ZvEN8e9D4a7GqWrmXZmB0yb7DWcExdnZJDf4rqedOoVCBdI+fLvexjBDLn2nVgUrRb bwj9RSdayVQG0XEhFvnL5JtY9KpzqlV6XVhMKQGDC/Z8i74opPoMCknPxHGlx23EWO6G X9RlObmneFIsoJbMjgw0nALWycIU2EVbGzG3fM9QKH9PE46Qw93N7H+IRMwJ78eDfqF3 LMSFIkQFS+lp3RiMVuKpnwvorAG7EDMPLHm6rOgXnhPG/CKl8fu9p0l3mlyGwxcjKxtf CdZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711374016; x=1711978816; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=l9e1vLBZyU81CA03W1c5FAr2hW3zhJCc3KJ54WTxEPY=; b=hNhASdEbNLrjjMpybTt1fALqTlNsm+2st6AjDUGmya879veP9JsYua+5/PkieBpS1d zzxWdJJahALHcnGxRA5MjG3tAEDcZ7zGi5Le8BUeRYv8GXhTSLdrfnaM5YMWeIJ+aLm5 BhnSHUyBg+ZFUxC+IxXZoCF5/Dn42HY6THtRZmFNqwrto7NihFspzXODEIADJN/UQb3t LIBf6w7MBuX/JMBAJokEd4jkt9FLsa/NfL1GG0SHzsjT+mUc8WHshpgLhzffuzR8FEJH cPCt0B76f5H44aoNucD+3vGIIks2KMfCU0bC9Uu6YGCB7xVb/+qOWxJrRuLhW2q44yGg SWZg== X-Gm-Message-State: AOJu0Yzzv8n1g6C0svQdsWr820V/qZEPJKRzerpeIgiddI93h+WZgNOK xiUqT3MFs7nTEH1vXRugWhb72NwO32skvn0RY8E/fqN570vq8kjdEDeeCJG0WP/AgdPJdZgli8x aLk56tnF/2NVwVmhNlLIV5riGMUQKVUjMXS/VO6JciwuSYrVCGaqAzyJx9IeN1eVgyUXHxSgLyb 4uMxUDhKlxTFv/Xmb2/M2/nv/N6w2x2F5tRSfwwnHUoP6SNy6WP4IQ X-Google-Smtp-Source: AGHT+IFs4pnYuPT9QeZILMzpw+KH5sZK9Ban54cZz2iTTYwMpWCCK9ZdBEKyXLu08t/akMqVJsacfwv8pOI= X-Received: from swim.c.googlers.com ([fda3:e722:ac3:cc00:31:98fb:c0a8:1605]) (user=gnoack job=sendgmr) by 2002:a81:4cc9:0:b0:611:e34:5a87 with SMTP id z192-20020a814cc9000000b006110e345a87mr1261154ywa.1.1711374016017; Mon, 25 Mar 2024 06:40:16 -0700 (PDT) Date: Mon, 25 Mar 2024 13:39:58 +0000 In-Reply-To: <20240325134004.4074874-1-gnoack@google.com> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240325134004.4074874-1-gnoack@google.com> X-Mailer: git-send-email 2.44.0.396.g6e790dbe36-goog Message-ID: <20240325134004.4074874-4-gnoack@google.com> Subject: [PATCH v12 3/9] selftests/landlock: Test IOCTL support From: "=?UTF-8?q?G=C3=BCnther=20Noack?=" To: linux-security-module@vger.kernel.org, "=?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?=" Cc: Jeff Xu , Arnd Bergmann , Jorge Lucangeli Obes , Allen Webb , Dmitry Torokhov , Paul Moore , Konstantin Meskhidze , Matt Bobrowski , linux-fsdevel@vger.kernel.org, "=?UTF-8?q?G=C3=BCnther=20Noack?=" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Exercises Landlock's IOCTL feature in different combinations of handling and permitting the LANDLOCK_ACCESS_FS_IOCTL_DEV right, and in different combinations of using files and directories. Signed-off-by: G=C3=BCnther Noack --- tools/testing/selftests/landlock/fs_test.c | 236 ++++++++++++++++++++- 1 file changed, 233 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/landlock/fs_test.c b/tools/testing/sel= ftests/landlock/fs_test.c index 0bcbbf594fd7..22229fe3e403 100644 --- a/tools/testing/selftests/landlock/fs_test.c +++ b/tools/testing/selftests/landlock/fs_test.c @@ -8,6 +8,7 @@ */ =20 #define _GNU_SOURCE +#include #include #include #include @@ -15,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -23,6 +25,12 @@ #include #include =20 +/* + * Intentionally included last to work around header conflict. + * See https://sourceware.org/glibc/wiki/Synchronizing_Headers. + */ +#include + #include "common.h" =20 #ifndef renameat2 @@ -735,6 +743,9 @@ static int create_ruleset(struct __test_metadata *const= _metadata, } =20 for (i =3D 0; rules[i].path; i++) { + if (!rules[i].access) + continue; + add_path_beneath(_metadata, ruleset_fd, rules[i].access, rules[i].path); } @@ -3443,7 +3454,7 @@ TEST_F_FORK(layout1, truncate_unhandled) LANDLOCK_ACCESS_FS_WRITE_FILE; int ruleset_fd; =20 - /* Enable Landlock. */ + /* Enables Landlock. */ ruleset_fd =3D create_ruleset(_metadata, handled, rules); =20 ASSERT_LE(0, ruleset_fd); @@ -3526,7 +3537,7 @@ TEST_F_FORK(layout1, truncate) LANDLOCK_ACCESS_FS_TRUNCATE; int ruleset_fd; =20 - /* Enable Landlock. */ + /* Enables Landlock. */ ruleset_fd =3D create_ruleset(_metadata, handled, rules); =20 ASSERT_LE(0, ruleset_fd); @@ -3752,7 +3763,7 @@ TEST_F_FORK(ftruncate, open_and_ftruncate) }; int fd, ruleset_fd; =20 - /* Enable Landlock. */ + /* Enables Landlock. */ ruleset_fd =3D create_ruleset(_metadata, variant->handled, rules); ASSERT_LE(0, ruleset_fd); enforce_ruleset(_metadata, ruleset_fd); @@ -3829,6 +3840,16 @@ TEST_F_FORK(ftruncate, open_and_ftruncate_in_differe= nt_processes) ASSERT_EQ(0, close(socket_fds[1])); } =20 +/* Invokes the FS_IOC_GETFLAGS IOCTL and returns its errno or 0. */ +static int test_fs_ioc_getflags_ioctl(int fd) +{ + uint32_t flags; + + if (ioctl(fd, FS_IOC_GETFLAGS, &flags) < 0) + return errno; + return 0; +} + TEST(memfd_ftruncate) { int fd; @@ -3845,6 +3866,215 @@ TEST(memfd_ftruncate) ASSERT_EQ(0, close(fd)); } =20 +static int test_fionread_ioctl(int fd) +{ + size_t sz =3D 0; + + if (ioctl(fd, FIONREAD, &sz) < 0 && errno =3D=3D EACCES) + return errno; + return 0; +} + +/* clang-format off */ +FIXTURE(ioctl) {}; + +FIXTURE_SETUP(ioctl) {}; + +FIXTURE_TEARDOWN(ioctl) {}; +/* clang-format on */ + +FIXTURE_VARIANT(ioctl) +{ + const __u64 handled; + const __u64 allowed; + const mode_t open_mode; + /* + * TCGETS is used as a characteristic device-specific IOCTL command. + * The logic is the same for other IOCTL commands as well. + */ + const int expected_tcgets_result; /* terminal device IOCTL */ + /* + * FIONREAD is implemented in fs/ioctl.c for regular files, + * but we do not blanket-permit it for devices. + */ + const int expected_fionread_result; +}; + +/* clang-format off */ +FIXTURE_VARIANT_ADD(ioctl, handled_i_allowed_none) { + /* clang-format on */ + .handled =3D LANDLOCK_ACCESS_FS_IOCTL_DEV, + .allowed =3D 0, + .open_mode =3D O_RDWR, + .expected_tcgets_result =3D EACCES, + .expected_fionread_result =3D EACCES, +}; + +/* clang-format off */ +FIXTURE_VARIANT_ADD(ioctl, handled_i_allowed_i) { + /* clang-format on */ + .handled =3D LANDLOCK_ACCESS_FS_IOCTL_DEV, + .allowed =3D LANDLOCK_ACCESS_FS_IOCTL_DEV, + .open_mode =3D O_RDWR, + .expected_tcgets_result =3D 0, + .expected_fionread_result =3D 0, +}; + +/* clang-format off */ +FIXTURE_VARIANT_ADD(ioctl, unhandled) { + /* clang-format on */ + .handled =3D LANDLOCK_ACCESS_FS_EXECUTE, + .allowed =3D LANDLOCK_ACCESS_FS_EXECUTE, + .open_mode =3D O_RDWR, + .expected_tcgets_result =3D 0, + .expected_fionread_result =3D 0, +}; + +static int test_fioqsize_ioctl(int fd) +{ + size_t sz; + + if (ioctl(fd, FIOQSIZE, &sz) < 0) + return errno; + return 0; +} + +static int test_tcgets_ioctl(int fd) +{ + struct termios info; + + if (ioctl(fd, TCGETS, &info) < 0) + return errno; + return 0; +} + +TEST_F_FORK(ioctl, handle_dir_access_file) +{ + const int flag =3D 0; + const struct rule rules[] =3D { + { + .path =3D "/dev", + .access =3D variant->allowed, + }, + {}, + }; + int file_fd, ruleset_fd; + + /* Enables Landlock. */ + ruleset_fd =3D create_ruleset(_metadata, variant->handled, rules); + ASSERT_LE(0, ruleset_fd); + enforce_ruleset(_metadata, ruleset_fd); + ASSERT_EQ(0, close(ruleset_fd)); + + file_fd =3D open("/dev/tty", variant->open_mode); + ASSERT_LE(0, file_fd); + + /* Checks that IOCTL commands return the expected errors. */ + EXPECT_EQ(variant->expected_tcgets_result, test_tcgets_ioctl(file_fd)); + EXPECT_EQ(variant->expected_fionread_result, + test_fionread_ioctl(file_fd)); + + /* Checks that unrestrictable commands are unrestricted. */ + EXPECT_EQ(0, ioctl(file_fd, FIOCLEX)); + EXPECT_EQ(0, ioctl(file_fd, FIONCLEX)); + EXPECT_EQ(0, ioctl(file_fd, FIONBIO, &flag)); + EXPECT_EQ(0, ioctl(file_fd, FIOASYNC, &flag)); + EXPECT_EQ(ENOTTY, test_fioqsize_ioctl(file_fd)); + + ASSERT_EQ(0, close(file_fd)); +} + +TEST_F_FORK(ioctl, handle_dir_access_dir) +{ + const int flag =3D 0; + const struct rule rules[] =3D { + { + .path =3D "/dev", + .access =3D variant->allowed, + }, + {}, + }; + int dir_fd, ruleset_fd; + + /* Enables Landlock. */ + ruleset_fd =3D create_ruleset(_metadata, variant->handled, rules); + ASSERT_LE(0, ruleset_fd); + enforce_ruleset(_metadata, ruleset_fd); + ASSERT_EQ(0, close(ruleset_fd)); + + /* + * Ignore variant->open_mode for this test, as we intend to open a + * directory. If the directory can not be opened, the variant is + * infeasible to test with an opened directory. + */ + dir_fd =3D open("/dev", O_RDONLY); + if (dir_fd < 0) + return; + + /* + * Checks that IOCTL commands return the expected errors. + * We do not use the expected values from the fixture here. + * + * When using IOCTL on a directory, no Landlock restrictions apply. + * TCGETS will fail anyway because it is not invoked on a TTY device. + */ + EXPECT_EQ(ENOTTY, test_tcgets_ioctl(dir_fd)); + EXPECT_EQ(0, test_fionread_ioctl(dir_fd)); + + /* Checks that unrestrictable commands are unrestricted. */ + EXPECT_EQ(0, ioctl(dir_fd, FIOCLEX)); + EXPECT_EQ(0, ioctl(dir_fd, FIONCLEX)); + EXPECT_EQ(0, ioctl(dir_fd, FIONBIO, &flag)); + EXPECT_EQ(0, ioctl(dir_fd, FIOASYNC, &flag)); + EXPECT_EQ(0, test_fioqsize_ioctl(dir_fd)); + + ASSERT_EQ(0, close(dir_fd)); +} + +TEST_F_FORK(ioctl, handle_file_access_file) +{ + const int flag =3D 0; + const struct rule rules[] =3D { + { + .path =3D "/dev/tty0", + .access =3D variant->allowed, + }, + {}, + }; + int file_fd, ruleset_fd; + + if (variant->allowed & LANDLOCK_ACCESS_FS_READ_DIR) { + SKIP(return, "LANDLOCK_ACCESS_FS_READ_DIR " + "can not be granted on files"); + } + + /* Enables Landlock. */ + ruleset_fd =3D create_ruleset(_metadata, variant->handled, rules); + ASSERT_LE(0, ruleset_fd); + enforce_ruleset(_metadata, ruleset_fd); + ASSERT_EQ(0, close(ruleset_fd)); + + file_fd =3D open("/dev/tty0", variant->open_mode); + ASSERT_LE(0, file_fd) + { + TH_LOG("Failed to open /dev/tty0: %s", strerror(errno)); + } + + /* Checks that IOCTL commands return the expected errors. */ + EXPECT_EQ(variant->expected_tcgets_result, test_tcgets_ioctl(file_fd)); + EXPECT_EQ(variant->expected_fionread_result, + test_fionread_ioctl(file_fd)); + + /* Checks that unrestrictable commands are unrestricted. */ + EXPECT_EQ(0, ioctl(file_fd, FIOCLEX)); + EXPECT_EQ(0, ioctl(file_fd, FIONCLEX)); + EXPECT_EQ(0, ioctl(file_fd, FIONBIO, &flag)); + EXPECT_EQ(0, ioctl(file_fd, FIOASYNC, &flag)); + EXPECT_EQ(ENOTTY, test_fioqsize_ioctl(file_fd)); + + ASSERT_EQ(0, close(file_fd)); +} + /* clang-format off */ FIXTURE(layout1_bind) {}; /* clang-format on */ --=20 2.44.0.396.g6e790dbe36-goog