From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BF1912BF2A for ; Tue, 7 May 2024 23:28:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715124537; cv=none; b=o7pqQs6GWdRb/eM/821zUF7gh9cg3cmeRHzz92nRTkunQegNKBI3OK/v+xrDlBaQWMI3bskqExYZqTUDUmEm2qj5Y7v9k7p5bwhb3RB81cQLqJztj3F6lSCc5T0WiUTQXkp6s56ORJQGBM0xASr7h4zhvIGWDvAg+YJ7tQR0G68= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715124537; c=relaxed/simple; bh=JX0XCKXr1thgDPxaTecjtKr6rIsRQAHKTIazy9OBhDc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TGel1zVT2ffXGWiGoSKJPs7W+pBA8lPCqZ/YrYILfyBl25GW94ENXkiTOtH4laUQ4CkoudkfD/bRj5lXnsP7xUd76Sa0qFuShq9mRTx4us4zwCKPYQ0ebJ+7r564KpVGlpuF/0JkMf5N3spsZ1vffbWISQBOk/t0XRsZiHVVTc4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=YSKyRV2q; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YSKyRV2q" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6f44b390d5fso3624706b3a.3 for ; Tue, 07 May 2024 16:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715124534; x=1715729334; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Tt8XgRQm+eA+VmBxGqEcvvy66oE9R2AfbLeL3WkCPuU=; b=YSKyRV2qjy0ljrYgd0U6Ch3uzgizQZe+4pSJYHsZSP01gcra909Tiz1I1roMahHF4f R02+dz1KaKB4os+ZuM06R3OW4OuuE5O+jtzs5QpwOMbe9ciAbxWjG0HBoTz/GjMb/HTS JZzkAPMzRCPpiJPnaz9ioUHMig2uiUqQfpOOs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715124534; x=1715729334; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Tt8XgRQm+eA+VmBxGqEcvvy66oE9R2AfbLeL3WkCPuU=; b=O98KfdCv5kvief7z14fK87f2B/crl2dBuzS6NaOXpCrEseuD9Cd1CrakDt6GocdwUy LvEtP7KwpRj+G2guXFo69e9az026bGIXnJF3TxXDWMnI37E/TRgWPxScBwx0cpX4H42t raljRQjQv9sdNaUeondhgudg876HO7WzxGA+329emQPlgIJrbz3N/dzFcwxPXun6uk+4 NoYyh09l4hglAoJUEaEPh7Sk/ulu6O3g0nmwUiwc6DeJKiaNhyc+YRJQ37lnCw7AIwqw HD5fgdCTsv3KgSmXrMmIoxr8NU8MTaGiqS/2+74I8k18mOuV33J4gbEFOwyfwuao8qvm q0JA== X-Forwarded-Encrypted: i=1; AJvYcCWZ8Urya/84vB8+7ul2Nz2WXt8HZ0O7WGS1P/djLdlP9/I4bJW3VXNX+KDiNgLch4gh7MU643Vc9RIceSBdj5rnvhvtKGR9bH7nVZDJ/baTnnl08ZXz X-Gm-Message-State: AOJu0YwFU0SP6+BT1TN+hU8U2Ktv4Ten7xjgaPj2fP5QMkR9DUWOulVQ oufN8odZmm29N4PBPGuxy3x7iFWXhH4Plc5FxLwkaoei4twFRYEZJ0+BXUDd1A== X-Google-Smtp-Source: AGHT+IElkYKkPF9F5WlZiOfJXRbgeCSMUqbJ3Z1JrZ5HzzcuDvdHCUlR3LVeoTae63dQgTdtTlamYA== X-Received: by 2002:a05:6a20:9f88:b0:1ad:6c5:4ea1 with SMTP id adf61e73a8af0-1afc8db5479mr1525582637.41.1715124534335; Tue, 07 May 2024 16:28:54 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id 60-20020a17090a09c200b002b624b0161fsm80422pjo.19.2024.05.07.16.28.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 16:28:53 -0700 (PDT) Date: Tue, 7 May 2024 16:28:53 -0700 From: Kees Cook To: Edward Liaw Cc: shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?iso-8859-1?Q?Andr=E9?= Almeida , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Sean Christopherson , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 0/5] Define _GNU_SOURCE for sources using Message-ID: <202405071628.7F8C3EC@keescook> References: <20240507214254.2787305-1-edliaw@google.com> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240507214254.2787305-1-edliaw@google.com> On Tue, May 07, 2024 at 09:38:25PM +0000, Edward Liaw wrote: > 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced > asprintf into kselftest_harness.h, which is a GNU extension and needs > _GNU_SOURCE to either be defined prior to including headers or with the > -D_GNU_SOURCE flag passed to the compiler. > > v1: https://lore.kernel.org/linux-kselftest/20240430235057.1351993-1-edliaw@google.com/ > v2: add -D_GNU_SOURCE to KHDR_INCLUDES so that it is in a single > location. Remove #define _GNU_SOURCE from source code to resolve > redefinition warnings. > > Edward Liaw (5): > selftests: Compile kselftest headers with -D_GNU_SOURCE > selftests/sgx: Include KHDR_INCLUDES in Makefile > selftests: Include KHDR_INCLUDES in Makefile > selftests: Drop define _GNU_SOURCE > selftests: Drop duplicate -D_GNU_SOURCE It's a lot of churn, but I don't see a way to do it differently. :) Reviewed-by: Kees Cook -- Kees Cook