From: Steven Rostedt <rostedt@goodmis.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-security-module@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] linux++: delete some forward declarations
Date: Thu, 13 Jun 2024 17:28:31 -0400 [thread overview]
Message-ID: <20240613172831.5e7f762f@rorschach.local.home> (raw)
In-Reply-To: <20240613142110.30019a4084d922d63c6d4352@linux-foundation.org>
On Thu, 13 Jun 2024 14:21:10 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Thu, 13 Jun 2024 16:10:12 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > > And... I'm a bit surprised that forward declarations are allowed in C.
> > > A billion years ago I used a C compiler which would use 16 bits for
> > > an enum if the enumted values would fit in 16 bits. And it would use 32
> > > bits otherwise. So the enumerated values were *required* for the
> > > compiler to be able to figure out the sizeof. But it was a billion
> > > years ago.
> >
> > Well, I only looked at the one change in ftrace.h which has a
> > "struct seq_file;" that is not used anywhere else in the file, so that
> > one definitely can go.
>
> The risk is that something which includes ftrace.h is depending upon
> the enum declaration.
You mean forward struct declaration. And if so, good! it needs to be fixed ;-)
-- Steve
next prev parent reply other threads:[~2024-06-13 21:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 19:22 [PATCH] linux++: delete some forward declarations Alexey Dobriyan
2024-06-13 19:34 ` Steven Rostedt
2024-06-13 20:04 ` Andrew Morton
2024-06-13 20:10 ` Steven Rostedt
2024-06-13 21:21 ` Andrew Morton
2024-06-13 21:28 ` Steven Rostedt [this message]
2024-06-14 6:29 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613172831.5e7f762f@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).