From: "Günther Noack" <gnoack3000@gmail.com>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: "Jann Horn" <jannh@google.com>,
"Tahera Fahimi" <fahimitahera@gmail.com>,
"Günther Noack" <gnoack@google.com>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, "Paul Moore" <paul@paul-moore.com>,
"James Morris" <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
outreachy@lists.linux.dev, netdev@vger.kernel.org,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>
Subject: Re: [PATCH v3] landlock: Add abstract unix socket connect restriction
Date: Fri, 14 Jun 2024 22:04:56 +0200 [thread overview]
Message-ID: <20240614.128b8d9046fd@gnoack.org> (raw)
In-Reply-To: <20240611.Pi8Iph7ootae@digikod.net>
On Tue, Jun 11, 2024 at 10:19:20AM +0200, Mickaël Salaün wrote:
> On Tue, Jun 11, 2024 at 12:27:58AM +0200, Jann Horn wrote:
> > This reminds me - from what I remember, Landlock also doesn't restrict
> > access to filesystem-based unix sockets yet... I'm I'm right about
> > that, we should probably at some point add code at some point to
> > restrict that as part of the path-based filesystem access rules? (But
> > to be clear, I'm not saying I expect you to do that as part of your
> > patch, just commenting for context.)
>
> Yes, I totally agree. For now, unix socket binding requires to create
> the LANDLOCK_ACCESS_FS_MAKE_SOCK right, but connecting to an existing
> socket is not controlled. The abstract unix socket scoping is
> orthogonal and extends Landlock with unix socket LSM hooks, which are
> required to extend the "filesystem" access rights to control path-based
> unix socket.
Thanks for the reminder, Jann! I filed it as
https://github.com/landlock-lsm/linux/issues/36.
–Günther
next prev parent reply other threads:[~2024-06-14 20:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 23:44 [PATCH v3] landlock: Add abstract unix socket connect restriction Tahera Fahimi
2024-06-07 8:28 ` Günther Noack
2024-06-07 19:41 ` Tahera Fahimi
2024-06-10 16:36 ` Mickaël Salaün
2024-06-10 21:49 ` Jann Horn
2024-06-11 8:19 ` Mickaël Salaün
2024-06-10 22:27 ` Jann Horn
2024-06-11 8:19 ` Mickaël Salaün
2024-06-14 20:04 ` Günther Noack [this message]
2024-06-11 21:06 ` Tahera Fahimi
-- strict thread matches above, loose matches on Subject: below --
2024-06-06 4:36 Tahera Fahimi
2024-06-06 15:56 ` Mickaël Salaün
2024-06-07 13:24 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614.128b8d9046fd@gnoack.org \
--to=gnoack3000@gmail.com \
--cc=bjorn3_gh@protonmail.com \
--cc=fahimitahera@gmail.com \
--cc=gnoack@google.com \
--cc=jannh@google.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@digikod.net \
--cc=netdev@vger.kernel.org \
--cc=outreachy@lists.linux.dev \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).