From: Kees Cook <kees@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: dm-devel@lists.linux.dev, Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Matthias Kaehlcke <mka@chromium.org>
Subject: Re: [PATCH] dm-verity: fix dm_is_verity_target() when dm-verity is builtin
Date: Wed, 3 Jul 2024 13:26:17 -0700 [thread overview]
Message-ID: <202407031326.8DD8F504@keescook> (raw)
In-Reply-To: <20240703200813.64802-1-ebiggers@kernel.org>
On Wed, Jul 03, 2024 at 01:08:13PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> When CONFIG_DM_VERITY=y, dm_is_verity_target() returned true for any
> builtin dm target, not just dm-verity. Fix this by checking for
> verity_target instead of THIS_MODULE (which is NULL for builtin code).
>
> Fixes: b6c1c5745ccc ("dm: Add verity helpers for LoadPin")
> Cc: stable@vger.kernel.org
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Cc: Kees Cook <keescook@chromium.org>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Ah! Nice catch.
Reviewed-by: Kees Cook <kees@kernel.org>
--
Kees Cook
prev parent reply other threads:[~2024-07-03 20:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 20:08 [PATCH] dm-verity: fix dm_is_verity_target() when dm-verity is builtin Eric Biggers
2024-07-03 20:26 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202407031326.8DD8F504@keescook \
--to=kees@kernel.org \
--cc=agk@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=ebiggers@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mka@chromium.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).