* [PATCH -next] lockdown: Make lockdown_lsmid static
@ 2024-08-14 3:30 Yue Haibing
2024-08-15 16:01 ` Kees Cook
2024-08-15 16:11 ` [PATCH] " Paul Moore
0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2024-08-14 3:30 UTC (permalink / raw)
To: paul, jmorris, serge, kees, casey
Cc: linux-security-module, linux-kernel, yuehaibing
Fix sparse warning:
security/lockdown/lockdown.c:79:21: warning:
symbol 'lockdown_lsmid' was not declared. Should it be static?
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
security/lockdown/lockdown.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/lockdown/lockdown.c b/security/lockdown/lockdown.c
index cd84d8ea1dfb..f2bdbd55aa2b 100644
--- a/security/lockdown/lockdown.c
+++ b/security/lockdown/lockdown.c
@@ -76,7 +76,7 @@ static struct security_hook_list lockdown_hooks[] __ro_after_init = {
LSM_HOOK_INIT(locked_down, lockdown_is_locked_down),
};
-const struct lsm_id lockdown_lsmid = {
+static const struct lsm_id lockdown_lsmid = {
.name = "lockdown",
.id = LSM_ID_LOCKDOWN,
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] lockdown: Make lockdown_lsmid static
2024-08-14 3:30 [PATCH -next] lockdown: Make lockdown_lsmid static Yue Haibing
@ 2024-08-15 16:01 ` Kees Cook
2024-08-15 16:11 ` [PATCH] " Paul Moore
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2024-08-15 16:01 UTC (permalink / raw)
To: Yue Haibing
Cc: paul, jmorris, serge, casey, linux-security-module, linux-kernel
On Wed, Aug 14, 2024 at 11:30:04AM +0800, Yue Haibing wrote:
> Fix sparse warning:
>
> security/lockdown/lockdown.c:79:21: warning:
> symbol 'lockdown_lsmid' was not declared. Should it be static?
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Reviewed-by: Kees Cook <kees@kernel.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] lockdown: Make lockdown_lsmid static
2024-08-14 3:30 [PATCH -next] lockdown: Make lockdown_lsmid static Yue Haibing
2024-08-15 16:01 ` Kees Cook
@ 2024-08-15 16:11 ` Paul Moore
1 sibling, 0 replies; 3+ messages in thread
From: Paul Moore @ 2024-08-15 16:11 UTC (permalink / raw)
To: Yue Haibing, jmorris, serge, kees, casey
Cc: linux-security-module, linux-kernel, yuehaibing
On Aug 13, 2024 Yue Haibing <yuehaibing@huawei.com> wrote:
>
> Fix sparse warning:
>
> security/lockdown/lockdown.c:79:21: warning:
> symbol 'lockdown_lsmid' was not declared. Should it be static?
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> Reviewed-by: Kees Cook <kees@kernel.org>
> ---
> security/lockdown/lockdown.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Merged into lsm/dev, thanks!
--
paul-moore.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-15 16:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-14 3:30 [PATCH -next] lockdown: Make lockdown_lsmid static Yue Haibing
2024-08-15 16:01 ` Kees Cook
2024-08-15 16:11 ` [PATCH] " Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).