From: Christian Brauner <brauner@kernel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Alice Ryhl <aliceryhl@google.com>,
rust-for-linux@vger.kernel.org, Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Miguel Ojeda <ojeda@kernel.org>,
Alex Gaynor <alex.gaynor@gmail.com>,
Wedson Almeida Filho <wedsonaf@gmail.com>,
Boqun Feng <boqun.feng@gmail.com>,
Bjoern Roy Baron <bjorn3_gh@protonmail.com>,
Benno Lossin <benno.lossin@proton.me>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arve Hjonnevag <arve@android.com>, Todd Kjos <tkjos@android.com>,
Martijn Coenen <maco@android.com>,
Joel Fernandes <joel@joelfernandes.org>,
Carlos Llamas <cmllamas@google.com>,
Suren Baghdasaryan <surenb@google.com>,
Dan Williams <dan.j.williams@intel.com>,
Matthew Wilcox <willy@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>, Daniel Xu <dxu@dxuuu.xyz>,
Martin Rodriguez Reboredo <yakoyoku@gmail.com>,
Trevor Gross <tmgross@umich.edu>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Kees Cook <kees@kernel.org>,
Andreas Hindborg <a.hindborg@kernel.org>
Subject: Re: [PATCH v4] rust: add PidNamespace
Date: Wed, 2 Oct 2024 13:30:50 +0200 [thread overview]
Message-ID: <20241002-wappnen-kartoffeln-deea146780ef@brauner> (raw)
In-Reply-To: <CANiq72my2N41wRWGFpPhJk_zTTaLJcuvYFekWFyoWrhQRLEfDQ@mail.gmail.com>
On Wed, Oct 02, 2024 at 01:12:08PM GMT, Miguel Ojeda wrote:
> On Wed, Oct 2, 2024 at 1:00 PM Christian Brauner <brauner@kernel.org> wrote:
> >
> > + let pidns = unsafe { bindings::task_active_pid_ns(Task::current_raw()) };
>
> Missing `// SAFETY` -- I mention it since this will be a warning (thus
> error in `WERROR`) soon.
>
> > + let ptr = unsafe { bindings::task_get_pid_ns(self.0.get()) };
>
> Ditto.
>
> > + Some(pidns) => unsafe { bindings::task_tgid_nr_ns(self.0.get(), pidns.as_ptr()) },
> > + None => unsafe { bindings::task_tgid_nr_ns(self.0.get(), ptr::null_mut()) },
>
> Ditto.
Ah, good to know.
prev parent reply other threads:[~2024-10-02 11:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 10:59 [PATCH v4] rust: add PidNamespace Christian Brauner
2024-10-02 11:12 ` Miguel Ojeda
2024-10-02 11:30 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002-wappnen-kartoffeln-deea146780ef@brauner \
--to=brauner@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=arve@android.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=cmllamas@google.com \
--cc=dan.j.williams@intel.com \
--cc=dxu@dxuuu.xyz \
--cc=gregkh@linuxfoundation.org \
--cc=jmorris@namei.org \
--cc=joel@joelfernandes.org \
--cc=kees@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=maco@android.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=paul@paul-moore.com \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=tkjos@android.com \
--cc=tmgross@umich.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=wedsonaf@gmail.com \
--cc=willy@infradead.org \
--cc=yakoyoku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox