[PATCH 1/1] netlabel: Add missing comment to struct field

[PATCH 1/1] netlabel: Add missing comment to struct field

[George Guo]

From: George Guo <guodongtai@kylinos.cn>

add a comment to doi_remove in struct netlbl_calipso_ops.

Flagged by ./scripts/kernel-doc -none.

Signed-off-by: George Guo <guodongtai@kylinos.cn>
---
 include/net/netlabel.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/net/netlabel.h b/include/net/netlabel.h
index 529160f76cac..4afd934b1238 100644
--- a/include/net/netlabel.h
+++ b/include/net/netlabel.h
@@ -208,6 +208,7 @@ struct netlbl_lsm_secattr {
  * struct netlbl_calipso_ops - NetLabel CALIPSO operations
  * @doi_add: add a CALIPSO DOI
  * @doi_free: free a CALIPSO DOI
+ * @doi_remove: remove a CALIPSO DOI
  * @doi_getdef: returns a reference to a DOI
  * @doi_putdef: releases a reference of a DOI
  * @doi_walk: enumerate the DOI list
-- 
2.34.1

Re: [PATCH 1/1] netlabel: Add missing comment to struct field

[Paul Moore]

On Mon, Sep 23, 2024 at 4:08 AM George Guo <dongtai.guo@linux.dev> wrote:
>
> From: George Guo <guodongtai@kylinos.cn>
>
> add a comment to doi_remove in struct netlbl_calipso_ops.
>
> Flagged by ./scripts/kernel-doc -none.
>
> Signed-off-by: George Guo <guodongtai@kylinos.cn>
> ---
>  include/net/netlabel.h | 1 +
>  1 file changed, 1 insertion(+)

Looks good to me.

Acked-by: Paul Moore <paul@paul-moore.com>

> diff --git a/include/net/netlabel.h b/include/net/netlabel.h
> index 529160f76cac..4afd934b1238 100644
> --- a/include/net/netlabel.h
> +++ b/include/net/netlabel.h
> @@ -208,6 +208,7 @@ struct netlbl_lsm_secattr {
>   * struct netlbl_calipso_ops - NetLabel CALIPSO operations
>   * @doi_add: add a CALIPSO DOI
>   * @doi_free: free a CALIPSO DOI
> + * @doi_remove: remove a CALIPSO DOI
>   * @doi_getdef: returns a reference to a DOI
>   * @doi_putdef: releases a reference of a DOI
>   * @doi_walk: enumerate the DOI list
> --
> 2.34.1

-- 
paul-moore.com

Re: [PATCH 1/1] netlabel: Add missing comment to struct field

[Paolo Abeni]

On 9/23/24 10:07, George Guo wrote:
> From: George Guo <guodongtai@kylinos.cn>
> 
> add a comment to doi_remove in struct netlbl_calipso_ops.
> 
> Flagged by ./scripts/kernel-doc -none.
> 
> Signed-off-by: George Guo <guodongtai@kylinos.cn>

## Form letter - net-next-closed

The merge window for v6.12 and therefore net-next is closed for new
drivers, features, code refactoring and optimizations. We are currently
accepting bug fixes only.

Please repost when net-next reopens after Sept 30th.

RFC patches sent for review only are obviously welcome at any time.

See:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
-- 
pw-bot: defer

[PATCH 1/1] add comment for doi_remove in struct netlbl_lsm_secattr

[George Guo]

From: George Guo <guodongtai@kylinos.cn>

---
 include/net/netlabel.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/net/netlabel.h b/include/net/netlabel.h
index 48106f910139..7091c8552fa1 100644
--- a/include/net/netlabel.h
+++ b/include/net/netlabel.h
@@ -209,6 +209,7 @@ struct netlbl_lsm_secattr {
  * struct netlbl_calipso_ops - NetLabel CALIPSO operations
  * @doi_add: add a CALIPSO DOI
  * @doi_free: free a CALIPSO DOI
+ * @doi_remove: remove a CALIPSO DOI
  * @doi_getdef: returns a reference to a DOI
  * @doi_putdef: releases a reference of a DOI
  * @doi_walk: enumerate the DOI list
-- 
2.34.1

Re: [PATCH 1/1] add comment for doi_remove in struct netlbl_lsm_secattr

[Simon Horman]

On Fri, Oct 25, 2024 at 02:40:31PM +0800, George Guo wrote:
> From: George Guo <guodongtai@kylinos.cn>

Hi George,

Thanks for your patch. I agree that is is correct and a good change
to make. But there are some process issues to be addressed before this
patch can be accepted.

Firstly, as this is presumably a non-bug fix for networking code,
it should be targeted at the net-next tree. That it should
be based on that tree (it seems to be) and explicitly targeted
at that tree in the Subject.

  Subject: [PATCH net-next v2] ...

Secondly, the subject should include a prefix.
Looking at git log include/net/netlabel.h it
seems that should be 'netlabel:'

  Subject: [PATCH net-next v2] netlabel: ...

And it might be best to make the subject a bit more descriptive.

  Subject: [PATCH net-next v2] netlabel: document doi_remove field of struct netlbl_calipso_ops


Next, a commit message is required. It should explain why the change is
being made. And, ideally how you found this problem. It should
also include a Signed-off-by line [1]. e.g.

  Add documentation of do_remove field to Kernel doc for struct
  netlbl_calipso_ops.

  Found using W=1 build.

  Signed-off-by: ...

[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Lastly, please do wait 24h before posting a new version.
Please include information about what has changed below the scissors ('---').
And please send the new patch as a new thread.

More information on development processes for Networking can be found here:
https://docs.kernel.org/process/maintainer-netdev.html

...

-- 
pw-bot: changes-requested

[PATCH 1/1] add comment for doi_remove in struct netlbl_lsm_secattr

[George Guo]

From: George Guo <guodongtai@kylinos.cn>

---
 include/net/netlabel.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/net/netlabel.h b/include/net/netlabel.h
index 48106f910139..7091c8552fa1 100644
--- a/include/net/netlabel.h
+++ b/include/net/netlabel.h
@@ -209,6 +209,7 @@ struct netlbl_lsm_secattr {
  * struct netlbl_calipso_ops - NetLabel CALIPSO operations
  * @doi_add: add a CALIPSO DOI
  * @doi_free: free a CALIPSO DOI
+ * @doi_remove: remove a CALIPSO DOI
  * @doi_getdef: returns a reference to a DOI
  * @doi_putdef: releases a reference of a DOI
  * @doi_walk: enumerate the DOI list
-- 
2.34.1

Re: [PATCH 1/1] add comment for doi_remove in struct netlbl_lsm_secattr

[Simon Horman]

On Fri, Oct 25, 2024 at 02:54:41PM +0800, George Guo wrote:
> From: George Guo <guodongtai@kylinos.cn>

Please don't post updated patches more frequently than once per 24h.
It makes reviewing quite cumbersome.

For comments on a (slightly) earlier version, please see:

https://lore.kernel.org/netdev/20241025065441.1001852-1-dongtai.guo@linux.dev/T/#mc951365b9ba02e3538efa0f0eb6a215199efc73b

-- 
pw-bot: changes-requested

[PATCH 1/1] netlabel: Add missing comment to struct field

[George Guo]

From: George Guo <guodongtai@kylinos.cn>

add a comment to doi_remove in struct netlbl_calipso_ops.

Flagged by ./scripts/kernel-doc -none.

Signed-off-by: George Guo <guodongtai@kylinos.cn>
---
 include/net/netlabel.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/net/netlabel.h b/include/net/netlabel.h
index 529160f76cac..4afd934b1238 100644
--- a/include/net/netlabel.h
+++ b/include/net/netlabel.h
@@ -208,6 +208,7 @@ struct netlbl_lsm_secattr {
  * struct netlbl_calipso_ops - NetLabel CALIPSO operations
  * @doi_add: add a CALIPSO DOI
  * @doi_free: free a CALIPSO DOI
+ * @doi_remove: remove a CALIPSO DOI
  * @doi_getdef: returns a reference to a DOI
  * @doi_putdef: releases a reference of a DOI
  * @doi_walk: enumerate the DOI list
-- 
2.34.1

Re: [PATCH 1/1] netlabel: Add missing comment to struct field

[Simon Horman]

On Fri, Oct 25, 2024 at 03:02:29PM +0800, George Guo wrote:
> From: George Guo <guodongtai@kylinos.cn>
> 
> add a comment to doi_remove in struct netlbl_calipso_ops.
> 
> Flagged by ./scripts/kernel-doc -none.
> 
> Signed-off-by: George Guo <guodongtai@kylinos.cn>

This revision is looking much nicer than the previous 2.
But I think it would be best to mention that you are
adding a Kernel doc entry, as per my comment on an earlier version:

https://lore.kernel.org/netdev/20241025065441.1001852-1-dongtai.guo@linux.dev/T/#mc951365b9ba02e3538efa0f0eb6a215199efc73b

...

-- 
pw-bot: changes-requested