From: Simon Horman <horms@kernel.org>
To: George Guo <dongtai.guo@linux.dev>
Cc: pabeni@redhat.com, davem@davemloft.net, edumazet@google.com,
guodongtai@kylinos.cn, kuba@kernel.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, netdev@vger.kernel.org,
paul@paul-moore.com
Subject: Re: [PATCH 1/1] netlabel: Add missing comment to struct field
Date: Fri, 25 Oct 2024 14:53:32 +0100 [thread overview]
Message-ID: <20241025135332.GY1202098@kernel.org> (raw)
In-Reply-To: <20241025070229.1006241-1-dongtai.guo@linux.dev>
On Fri, Oct 25, 2024 at 03:02:29PM +0800, George Guo wrote:
> From: George Guo <guodongtai@kylinos.cn>
>
> add a comment to doi_remove in struct netlbl_calipso_ops.
>
> Flagged by ./scripts/kernel-doc -none.
>
> Signed-off-by: George Guo <guodongtai@kylinos.cn>
This revision is looking much nicer than the previous 2.
But I think it would be best to mention that you are
adding a Kernel doc entry, as per my comment on an earlier version:
https://lore.kernel.org/netdev/20241025065441.1001852-1-dongtai.guo@linux.dev/T/#mc951365b9ba02e3538efa0f0eb6a215199efc73b
...
--
pw-bot: changes-requested
prev parent reply other threads:[~2024-10-25 13:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 8:07 [PATCH 1/1] netlabel: Add missing comment to struct field George Guo
2024-09-23 11:52 ` Paul Moore
2024-09-24 10:43 ` Paolo Abeni
2024-10-25 6:40 ` [PATCH 1/1] add comment for doi_remove in struct netlbl_lsm_secattr George Guo
2024-10-25 13:40 ` Simon Horman
2024-10-25 6:54 ` George Guo
2024-10-25 13:50 ` Simon Horman
2024-10-25 7:02 ` [PATCH 1/1] netlabel: Add missing comment to struct field George Guo
2024-10-25 13:53 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241025135332.GY1202098@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=dongtai.guo@linux.dev \
--cc=edumazet@google.com \
--cc=guodongtai@kylinos.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).