Re: [PATCH v3 fanotify 1/2] fanotify: Introduce fanotify filter

kernel test robot
2024-11-26T00:06:12Z

Hi Song,

kernel test robot noticed the following build warnings:

[auto build test WARNING on jack-fs/fsnotify]
[also build test WARNING on linus/master v6.12 next-20241125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Song-Liu/fanotify-Introduce-fanotify-filter/20241125-110818
base: https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git fsnotify
patch link: https://lore.kernel.org/r/20241122225958.1775625-2-song%40kernel.org
patch subject: [PATCH v3 fanotify 1/2] fanotify: Introduce fanotify filter
config: x86_64-randconfig-123-20241125 (https://download.01.org/0day-ci/archive/20241126/202411260746.XEdTrLMj-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241126/202411260746.XEdTrLMj-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411260746.XEdTrLMj-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> fs/notify/fanotify/fanotify_filter.c:271:21: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct fanotify_filter_hook *filter_hook @@ got struct fanotify_filter_hook [noderef] __rcu *filter_hook @@
fs/notify/fanotify/fanotify_filter.c:271:21: sparse: expected struct fanotify_filter_hook *filter_hook
fs/notify/fanotify/fanotify_filter.c:271:21: sparse: got struct fanotify_filter_hook [noderef] __rcu *filter_hook
fs/notify/fanotify/fanotify_filter.c: note: in included file (through include/linux/kobject.h, include/linux/fanotify.h):
include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
--
>> fs/notify/fanotify/fanotify.c:1015:63: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct fanotify_filter_hook *filter_hook @@ got struct fanotify_filter_hook [noderef] __rcu *filter_hook @@
fs/notify/fanotify/fanotify.c:1015:63: sparse: expected struct fanotify_filter_hook *filter_hook
fs/notify/fanotify/fanotify.c:1015:63: sparse: got struct fanotify_filter_hook [noderef] __rcu *filter_hook

vim +271 fs/notify/fanotify/fanotify_filter.c

262
263 /*
264 * fanotify_filter_del - Delete a filter from fsnotify_group.
265 */
266 void fanotify_filter_del(struct fsnotify_group *group)
267 {
268 struct fanotify_filter_hook *filter_hook;
269
270 fsnotify_group_lock(group);
> 271 filter_hook = group->fanotify_data.filter_hook;
272 if (!filter_hook)
273 goto out;
274
275 rcu_assign_pointer(group->fanotify_data.filter_hook, NULL);
276 fanotify_filter_hook_free(filter_hook);
277
278 out:
279 fsnotify_group_unlock(group);
280 }
281

--
0-DAY CI Kernel Test Service