From: alexjlzheng@gmail.com
To: paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com,
greg@kroah.com, chrisw@osdl.org
Cc: linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jinliang Zheng <alexjlzheng@tencent.com>,
stable@vger.kernel.org
Subject: [PATCH] securityfs: fix missing of d_delete() in securityfs_remove()
Date: Fri, 25 Apr 2025 17:25:48 +0800 [thread overview]
Message-ID: <20250425092548.6828-1-alexjlzheng@tencent.com> (raw)
From: Jinliang Zheng <alexjlzheng@tencent.com>
Consider the following module code:
static struct dentry *dentry;
static int __init securityfs_test_init(void)
{
dentry = securityfs_create_dir("standon", NULL);
return PTR_ERR(dentry);
}
static void __exit securityfs_test_exit(void)
{
securityfs_remove(dentry);
}
module_init(securityfs_test_init);
module_exit(securityfs_test_exit);
and then:
insmod /path/to/thismodule
cd /sys/kernel/security/standon <- we hold 'standon'
rmmod thismodule <- 'standon' don't go away
insmod /path/to/thismodule <- Failed: File exists!
Fix this by adding d_delete() in securityfs_remove().
Fixes: b67dbf9d4c198 ("[PATCH] add securityfs for all LSMs to use")
Signed-off-by: Jinliang Zheng <alexjlzheng@tencent.com>
Cc: <stable@vger.kernel.org>
---
security/inode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/inode.c b/security/inode.c
index da3ab44c8e57..d99baf26350a 100644
--- a/security/inode.c
+++ b/security/inode.c
@@ -306,6 +306,7 @@ void securityfs_remove(struct dentry *dentry)
simple_rmdir(dir, dentry);
else
simple_unlink(dir, dentry);
+ d_delete(dentry);
dput(dentry);
}
inode_unlock(dir);
--
2.49.0
next reply other threads:[~2025-04-25 9:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 9:25 alexjlzheng [this message]
2025-04-25 22:06 ` [PATCH] securityfs: fix missing of d_delete() in securityfs_remove() Paul Moore
2025-04-26 4:15 ` Jinliang Zheng
2025-04-26 5:57 ` Fan Wu
2025-04-26 15:09 ` Jinliang Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250425092548.6828-1-alexjlzheng@tencent.com \
--to=alexjlzheng@gmail.com \
--cc=alexjlzheng@tencent.com \
--cc=chrisw@osdl.org \
--cc=greg@kroah.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).