From: Jakub Kicinski <kuba@kernel.org>
To: Chaohai Chen <wdhh6@aliyun.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, steffen.klassert@secunet.com,
herbert@gondor.apana.org.au, paul@paul-moore.com,
pablo@netfilter.org, kadlec@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org
Subject: Re: [PATCH] net:ipv4: Use shift left 2 to calculate the length of the IPv4 header.
Date: Mon, 28 Apr 2025 13:42:46 -0700 [thread overview]
Message-ID: <20250428134246.147b02fe@kernel.org> (raw)
In-Reply-To: <20250427061706.391920-1-wdhh6@aliyun.com>
On Sun, 27 Apr 2025 14:17:06 +0800 Chaohai Chen wrote:
> Encapsulate the IPV4_HEADER_LEN macro and use shift left 2 to calculate
> the length of the IPv4 header instead of multiplying 4 everywhere.
Doesn't seem worth the churn, sorry.
prev parent reply other threads:[~2025-04-28 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-27 6:17 [PATCH] net:ipv4: Use shift left 2 to calculate the length of the IPv4 header Chaohai Chen
2025-04-28 20:42 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250428134246.147b02fe@kernel.org \
--to=kuba@kernel.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=kadlec@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=paul@paul-moore.com \
--cc=steffen.klassert@secunet.com \
--cc=wdhh6@aliyun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).