From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38B81295515 for ; Mon, 12 May 2025 13:19:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747055972; cv=none; b=Z2iUC70sFNZLQZZntgrpEl7eL8XxvtrfEGWt76ZV1HwIHCb/P0NxGRKAd9F/DOEqbS65ewymL/w+qw0t5R5Dgbre5ea0CjfDYWRWfq2QTOow7i/WOKxNMW0WsbG3aQpZ0EMMGqxQyb0suO88xD3gxghNKe3ajGEek9urMoPtp5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747055972; c=relaxed/simple; bh=9gJF743RWK+bJ6m7oQyctUYpmbwhq5qenEdMjKDH0Lc=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=YoJ9cT0y0mcEaGwAMGyVx8eqK/0WH59middwJKf/DE1nWk477+V2p/pnQsHEm4mJBhbyuAb57oZJ2JArkXKHXJ/UgBruPQuMyi+gxppJ+35MC8+kiUcvvdV/D8KBw5QFfiOg7rpCqw/MQ+RqLoYqpKYDoS2plftGTVZd+wHMKCE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QNsQv9bn; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QNsQv9bn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747055967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FLzO0UetENOl7ymbAc9ZwNTqK+089tCghqZXKpGiOB4=; b=QNsQv9bnQ1GKbWM/G0UBFcPZiar86cGmsoMSilStBrahBIidbV/53UZcL2f5SNR+8WCmEk 5m8ehGx6b8K74MGLhjRWFdoUj7YmJIqoqxICffKzfc0M5ytjMCs/2vLZWvffVnyEqqfLtK oNarGLhz0PesaghyqAhO5vg3Us5X9TI= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-qriPdHbROoKC9mRkm7SB7A-1; Mon, 12 May 2025 09:19:26 -0400 X-MC-Unique: qriPdHbROoKC9mRkm7SB7A-1 X-Mimecast-MFC-AGG-ID: qriPdHbROoKC9mRkm7SB7A_1747055965 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-ad2200eb1d0so203974666b.3 for ; Mon, 12 May 2025 06:19:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747055965; x=1747660765; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FLzO0UetENOl7ymbAc9ZwNTqK+089tCghqZXKpGiOB4=; b=PS50xLaY50dhfEigzACLGWi7jRC4ICMhSp4NhGcreZwDSPQD4EAz9Q5VKo1TKfk7+n 1QdH1bLVCS1v6xGd7LNpQBkSQgYfnJJ5PVTRYinfq9ldUm2ImxSls8W0dHt17Re4q3nO Iefs09SLuK4KC59/6ijIp1QiE+tWVxTwk+0W5Cy2y9JNxxDg8dqRQnJM4isXFMI/gkEJ y27dbVPjnHVElQMxxOgiqituTj4k1lrEGtv9er/4+5KC0z876s5+mWhhrBS0VL0oXxaa ALHozAVx0XatYRZHfMNVGAoMPtEf/+R+w3/7kiIXuVVCTEGOv/RMrAxen/SVQSCz0GeR +ttA== X-Forwarded-Encrypted: i=1; AJvYcCUtb0zLBMGxAmbyZ6VT9h/fgjA5jwU/S9eXz6uhgKrRwasMimoW+c39597lT++KwlzlUCha+Nal9LGL7DtHwq0ui4Bt7Zw=@vger.kernel.org X-Gm-Message-State: AOJu0YxnOAFAoBdnOGcAySv+pA8BJiPzR6E8UEJwJPXEfqKXOCdpty9D 59amfFD344rDQazf7+dyKYUbtqNGsBz+3Whkzy6jKiQ3XxOZ2I8+FyvLlFA1PIP19NrnjyjYCYj Ce2wfHSk4u3uFhwH1f9Zq7HIUfZJ7CYcZLjt4A5ecQGn3JaG185c2I4NfUR+PO5ZlNG8E6TZ5 X-Gm-Gg: ASbGncuxX+RDOwm7wnty3ePLE3qI8PwaAMJwwuOV4NC9OogeXbL4IPBtkNduGv1f4PO alInmu5r2GiLS499+d7HY9iDCRxD8Za6m4KOsmnJDkxXFQtbdv3w8cKE9QfQiJowmLQuLsHuLxu 4ieRPHH7amE5HBgS+/VctWyLxyqvDcyEQ8RPYsWIqV8vneYvnXR0WB+yQvSFLeTmbCZvTVHtSIC Kkbw9iuWdM8kd7KKsllWoRNnmZhL8+IhyloWs19iK4WaT8wnc15ZeMAi56nx6RI3+QQEqbv0GwA yb4Fk1DW1UdjIDeDKxXhhIbbroY= X-Received: by 2002:a17:907:8b99:b0:ad2:2d6e:4962 with SMTP id a640c23a62f3a-ad22d6e52c2mr855524166b.42.1747055965132; Mon, 12 May 2025 06:19:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGa3ZpYdTF3qd17gWEoRTHMnv+pL5522+Z5nSX7r6uDpni86IH6A8IHgBLuulX9yc13mwfyKQ== X-Received: by 2002:a17:907:8b99:b0:ad2:2d6e:4962 with SMTP id a640c23a62f3a-ad22d6e52c2mr855517166b.42.1747055964687; Mon, 12 May 2025 06:19:24 -0700 (PDT) Received: from [127.0.0.1] (109-92-26-237.static.isp.telekom.rs. [109.92.26.237]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad2197bde09sm612328766b.125.2025.05.12.06.19.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 06:19:24 -0700 (PDT) From: Andrey Albershteyn X-Google-Original-From: Andrey Albershteyn Date: Mon, 12 May 2025 15:18:56 +0200 Subject: [PATCH v5 3/7] selinux: implement inode_file_[g|s]etattr hooks Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250512-xattrat-syscall-v5-3-a88b20e37aae@kernel.org> References: <20250512-xattrat-syscall-v5-0-a88b20e37aae@kernel.org> In-Reply-To: <20250512-xattrat-syscall-v5-0-a88b20e37aae@kernel.org> To: Richard Henderson , Matt Turner , Russell King , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Chris Zankel , Max Filippov , Alexander Viro , Christian Brauner , Jan Kara , =?utf-8?q?Micka=C3=ABl_Sala=C3=BCn?= , =?utf-8?q?G=C3=BCnther_Noack?= , Arnd Bergmann , =?utf-8?q?Pali_Roh=C3=A1r?= , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , Ondrej Mosnacek , Tyler Hicks , Miklos Szeredi , Amir Goldstein Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, selinux@vger.kernel.org, ecryptfs@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, Andrey Albershteyn X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=1614; i=aalbersh@kernel.org; h=from:subject:message-id; bh=9gJF743RWK+bJ6m7oQyctUYpmbwhq5qenEdMjKDH0Lc=; b=owJ4nJvAy8zAJea2/JXEGuOHHIyn1ZIYMhS/+h/6tvS4ypammLpAoYZzNSvmXjrOE5DOrL33V 8CXj52HDmR0lLIwiHExyIopsqyT1pqaVCSVf8SgRh5mDisTyBAGLk4BmMjE64wMK86tctk6J8PH 5NWsT9K3ktK/ublm/c3lZ8k/wnjIVFi0kZHh8PaZrp7Ld+k+Z2N7UH7CtdSLJcq5zkrlWQO7dK2 M72wWABsnReQ= X-Developer-Key: i=aalbersh@kernel.org; a=openpgp; fpr=AE1B2A9562721A6FC4307C1F46A7EA18AC33E108 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fKuiQ-Yb_rDBmdDyYDNBiZFOG8PmoftjK6baXzEnR54_1747055965 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit These hooks are called on inode extended attribute retrieval/change. Cc: selinux@vger.kernel.org Cc: Paul Moore Signed-off-by: Andrey Albershteyn --- security/selinux/hooks.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index e7a7dcab81db..9c6e264b090f 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -3366,6 +3366,18 @@ static int selinux_inode_removexattr(struct mnt_idmap *idmap, return -EACCES; } +static int selinux_inode_file_setattr(struct dentry *dentry, + struct fileattr *fa) +{ + return dentry_has_perm(current_cred(), dentry, FILE__SETATTR); +} + +static int selinux_inode_file_getattr(struct dentry *dentry, + struct fileattr *fa) +{ + return dentry_has_perm(current_cred(), dentry, FILE__GETATTR); +} + static int selinux_path_notify(const struct path *path, u64 mask, unsigned int obj_type) { @@ -7272,6 +7284,8 @@ static struct security_hook_list selinux_hooks[] __ro_after_init = { LSM_HOOK_INIT(inode_getxattr, selinux_inode_getxattr), LSM_HOOK_INIT(inode_listxattr, selinux_inode_listxattr), LSM_HOOK_INIT(inode_removexattr, selinux_inode_removexattr), + LSM_HOOK_INIT(inode_file_getattr, selinux_inode_file_getattr), + LSM_HOOK_INIT(inode_file_setattr, selinux_inode_file_setattr), LSM_HOOK_INIT(inode_set_acl, selinux_inode_set_acl), LSM_HOOK_INIT(inode_get_acl, selinux_inode_get_acl), LSM_HOOK_INIT(inode_remove_acl, selinux_inode_remove_acl), -- 2.47.2