From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE3B72147F9 for ; Tue, 13 May 2025 09:18:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747127908; cv=none; b=nAPR2tvKbuJESVAi5te6A/i2ItzeOj0g6laEHBpbf7gHbXse/nD4qtC8htD/8tv8Fl/avezgLiWw2gpwPHa/FOodiCVU697jLwYfyAedJSU0E7KfgfQboxlJGDNOq40U7Z5wCA3z9dQVY1bkBhjbiWdI5crl8yGNhAXppNByF0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747127908; c=relaxed/simple; bh=wSzH0WcqWhiy63ekDcp2P+4tMQ4i2gTZHqE6rCKQ++I=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=TrllFehaXp2xRy+0k76aClYqAirZEjJek4tOCK7bC3Fw5CuiUrgQqo1XsnqBd+bU26mFlbpwUKi0o0Tw7HJT2oRONmvoPuLlTB2C/Uw+MuMvNpK9ydZoTUAs+tONJeYc0X/eJ4BObn48Vc7t9jLeYkq8AhqCdYSgs4+mUVCfGPY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ed0+4OzW; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ed0+4OzW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747127901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A7i9r0bj6CyLmaFmxt3qgx2Tj6vgASlaO3PK3g/iy20=; b=Ed0+4OzWfLh32523fJEz31/L5nouK9o+S1bguFQ57Sl5ZXPnRCRs0y2BwRhH1/LxjNlH9D P4MAuRx2z/LbSBwW5PzVPO9tXHmLEUcxlgJfz0A6EE1j3f8/UgCZTWfThcjSZ8OKCwbvob dLEFxUljxywwBAmGLwZNvrcSYp1nDts= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-pv0V1y_8OMqK3z_5RWrd0Q-1; Tue, 13 May 2025 05:18:20 -0400 X-MC-Unique: pv0V1y_8OMqK3z_5RWrd0Q-1 X-Mimecast-MFC-AGG-ID: pv0V1y_8OMqK3z_5RWrd0Q_1747127899 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43ce8f82e66so28145525e9.3 for ; Tue, 13 May 2025 02:18:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747127899; x=1747732699; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A7i9r0bj6CyLmaFmxt3qgx2Tj6vgASlaO3PK3g/iy20=; b=bZiq5RD6diDbif2dW9rwtWM2n68Adsefu5C0n8L2HWmeIflj+m1AiEmraCcDkShy7X WsWxkkDEa6yjeY27hI0Wu6DNbKGMQ2hjDlAiih82+wo5unDtI5/Sg/zJW2J17fAkx2Z2 Sngl/UffNV17GG1fZNVJZXXGLTmQoDrHo8H5dJH/LIKFHQkoFSmuS0tW836sWCbUlynN mEnDDlp0YnzBMNap8iDUce5/dAqf20ZUvFvJuvJZOxQo4AocX4t1xuzq0JjHzIBEw/W4 17cFqqpCKX0UCRsmUDI93P+xecwfAp+8WRjPmk8Xt8vIiVGzrPqPROsACt9YifPYDN4O zgrQ== X-Forwarded-Encrypted: i=1; AJvYcCV5f/y8U2jb5hqUsIGLOxPB8FcQXrKkCmWsUN1+BOH57KaBpNfoyNxLOQEUzPlWxAIlS0uYko4xdueyOrNwzH30Kf26YrE=@vger.kernel.org X-Gm-Message-State: AOJu0YyZk//GS9n4UpONtAccwE9huy+PjC3o6wPIBcy4zXB0nw48xPJU gRS7kGrCwpYV3Z8nfS5uBX/Wg1NPuEmtCLHWsc3GXEPSjgFo9F3hwN441ANOOS1PQMkG0P6v/v7 vcrIqLry6/Pl4/Ow48gHosjkpj4Et9P2qxgmIhVnrMICc3+O0WroSJrwhBNMvTlvGECW5njz6 X-Gm-Gg: ASbGncslIgA7L9RErqnR60DC+2TlmNilppvioLaED1gogIN82sXTLdNlHyxu156B4Nu 8q8sgUQ4ZtYltoFRA1Q/WlXfvVs2kg9nGX6uUDlRJJAzvvyk3yyt82cEFuzR8BmFVajiIolUc82 1rZQJV4z2zlNhehARi6ij3kE4hQNNeCqLj+q+5Dh7E1syLXoP8aLXGE6P+4But3/bn+UCoS7tb2 dW4o6CrnIDk7pGZV9259NvzGKvwZ5LGTD1iI2LXYk1yqzFgQMsTqP5bpcSOkAHD1k5nAVLZTz2G Z15RyQTxN/rSUU6g9B4n8Qp7Yeip8XKAdqlSrcnI8P8fQiA= X-Received: by 2002:a05:600c:b85:b0:43d:fa59:cc8f with SMTP id 5b1f17b1804b1-442d6dde9a5mr123282515e9.33.1747127898857; Tue, 13 May 2025 02:18:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH48YApAweQLr9FqjcxLWZAARsvWVI15CFcissyg+mEXGTlUmY2j0SDRus7eO6YNuUdP6jeRg== X-Received: by 2002:a05:600c:b85:b0:43d:fa59:cc8f with SMTP id 5b1f17b1804b1-442d6dde9a5mr123281625e9.33.1747127898279; Tue, 13 May 2025 02:18:18 -0700 (PDT) Received: from [127.0.0.2] (109-92-26-237.static.isp.telekom.rs. [109.92.26.237]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442ed666dc7sm12345655e9.18.2025.05.13.02.18.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 02:18:17 -0700 (PDT) From: Andrey Albershteyn X-Google-Original-From: Andrey Albershteyn Date: Tue, 13 May 2025 11:17:56 +0200 Subject: [PATCH v5 3/7] selinux: implement inode_file_[g|s]etattr hooks Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250513-xattrat-syscall-v5-3-22bb9c6c767f@kernel.org> References: <20250513-xattrat-syscall-v5-0-22bb9c6c767f@kernel.org> In-Reply-To: <20250513-xattrat-syscall-v5-0-22bb9c6c767f@kernel.org> To: Richard Henderson , Matt Turner , Russell King , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Chris Zankel , Max Filippov , Alexander Viro , Christian Brauner , Jan Kara , =?utf-8?q?Micka=C3=ABl_Sala=C3=BCn?= , =?utf-8?q?G=C3=BCnther_Noack?= , Arnd Bergmann , =?utf-8?q?Pali_Roh=C3=A1r?= , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , Ondrej Mosnacek , Tyler Hicks , Miklos Szeredi , Amir Goldstein Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, selinux@vger.kernel.org, ecryptfs@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, Andrey Albershteyn X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1670; i=aalbersh@kernel.org; h=from:subject:message-id; bh=wSzH0WcqWhiy63ekDcp2P+4tMQ4i2gTZHqE6rCKQ++I=; b=owJ4nJvAy8zAJea2/JXEGuOHHIyn1ZIYMpT5vOcHL6x//4Yt+9EFwZyLxr/7Tz9ZpP5u3tO4V q6ORSUh1y53lLIwiHExyIopsqyT1pqaVCSVf8SgRh5mDisTyBAGLk4BmEiwPiND+6YnluEhu/Qc Cx5cnc3R+vvvJvuQL0V6fGyyUclCHH6VjAwT/JZona0OZVzwJvX/wlkFTstmX7ezC/yqzlmc01k tfZMVAGD5RU0= X-Developer-Key: i=aalbersh@kernel.org; a=openpgp; fpr=AE1B2A9562721A6FC4307C1F46A7EA18AC33E108 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: VySleJmuQRiRjzHAJY4lhAmDy08wXzDNF9njUC3P-Ms_1747127899 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit These hooks are called on inode extended attribute retrieval/change. Cc: selinux@vger.kernel.org Cc: Paul Moore Signed-off-by: Andrey Albershteyn --- security/selinux/hooks.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index e7a7dcab81db6a8735877eeb911975e06a9de688..9c6e264b090f9038d6848546760860bfe74b7341 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -3366,6 +3366,18 @@ static int selinux_inode_removexattr(struct mnt_idmap *idmap, return -EACCES; } +static int selinux_inode_file_setattr(struct dentry *dentry, + struct fileattr *fa) +{ + return dentry_has_perm(current_cred(), dentry, FILE__SETATTR); +} + +static int selinux_inode_file_getattr(struct dentry *dentry, + struct fileattr *fa) +{ + return dentry_has_perm(current_cred(), dentry, FILE__GETATTR); +} + static int selinux_path_notify(const struct path *path, u64 mask, unsigned int obj_type) { @@ -7272,6 +7284,8 @@ static struct security_hook_list selinux_hooks[] __ro_after_init = { LSM_HOOK_INIT(inode_getxattr, selinux_inode_getxattr), LSM_HOOK_INIT(inode_listxattr, selinux_inode_listxattr), LSM_HOOK_INIT(inode_removexattr, selinux_inode_removexattr), + LSM_HOOK_INIT(inode_file_getattr, selinux_inode_file_getattr), + LSM_HOOK_INIT(inode_file_setattr, selinux_inode_file_setattr), LSM_HOOK_INIT(inode_set_acl, selinux_inode_set_acl), LSM_HOOK_INIT(inode_get_acl, selinux_inode_get_acl), LSM_HOOK_INIT(inode_remove_acl, selinux_inode_remove_acl), -- 2.47.2