Linux Security Modules development
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Jann Horn <jannh@google.com>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>,
	stephen@networkplumber.org,  alexander@mihalicyn.com,
	daan.j.demeyer@gmail.com, daniel@iogearbox.net,
	 davem@davemloft.net, david@readahead.eu, edumazet@google.com,
	horms@kernel.org,  jack@suse.cz, kuba@kernel.org,
	lennart@poettering.net,  linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	 linux-security-module@vger.kernel.org, luca.boccassi@gmail.com,
	me@yhndnzj.com, netdev@vger.kernel.org,  oleg@redhat.com,
	pabeni@redhat.com, serge@hallyn.com, viro@zeniv.linux.org.uk,
	 zbyszek@in.waw.pl
Subject: Re: [PATCH v8 0/9] coredump: add coredump socket
Date: Wed, 21 May 2025 17:12:52 +0200	[thread overview]
Message-ID: <20250521-knirschen-kommst-2fcf19f7d280@brauner> (raw)
In-Reply-To: <CAG48ez0r4A7iMXzBBdPiHWycYSAGSm7VFWULCqKQPXoBKFWpEw@mail.gmail.com>

> The path lookups work very differently between COREDUMP_SOCK and
> COREDUMP_FILE - they are interpreted relative to different namespaces,
> and they run with different privileges, and they do different format
> string interpretation. I think trying to determine dynamically whether
> the path refers to a socket or to a nonexistent location at which we
> should create a file (or a preexisting file we should clobber) would
> not be practical, partly for these reasons.

Agreed.

> 
> Also, fundamentally, if we have the choice between letting userspace
> be explicit about what it wants, or trying to guess userspace's intent
> from the kernel, I think we should always go for being explicit.

Agreed.

> 
> meaning in this context, like '>'; but I don't think we should be
> changing the overall approach because of this.

Agreed.

  reply	other threads:[~2025-05-21 15:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-16 11:25 [PATCH v8 0/9] coredump: add coredump socket Christian Brauner
2025-05-16 11:25 ` [PATCH v8 1/9] coredump: massage format_corename() Christian Brauner
2025-05-16 11:25 ` [PATCH v8 2/9] coredump: massage do_coredump() Christian Brauner
2025-05-16 11:25 ` [PATCH v8 3/9] coredump: reflow dump helpers a little Christian Brauner
2025-05-16 11:25 ` [PATCH v8 4/9] coredump: add coredump socket Christian Brauner
2025-05-16 14:33   ` Jann Horn
2025-05-22 23:25   ` Paul Moore
2025-05-23  0:59   ` Randy Dunlap
2025-05-16 11:25 ` [PATCH v8 5/9] pidfs, coredump: add PIDFD_INFO_COREDUMP Christian Brauner
2025-05-16 14:37   ` Jann Horn
2025-05-16 11:25 ` [PATCH v8 6/9] coredump: show supported coredump modes Christian Brauner
2025-05-16 11:25 ` [PATCH v8 7/9] coredump: validate socket name as it is written Christian Brauner
2025-05-16 11:25 ` [PATCH v8 8/9] selftests/pidfd: add PIDFD_INFO_COREDUMP infrastructure Christian Brauner
2025-05-16 11:25 ` [PATCH v8 9/9] selftests/coredump: add tests for AF_UNIX coredumps Christian Brauner
2025-05-20 19:28 ` [PATCH v8 0/9] coredump: add coredump socket Stephen Hemminger
2025-05-21  0:41   ` Kuniyuki Iwashima
2025-05-21  0:54     ` Jann Horn
2025-05-21 15:12       ` Christian Brauner [this message]
2025-05-21 11:12   ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250521-knirschen-kommst-2fcf19f7d280@brauner \
    --to=brauner@kernel.org \
    --cc=alexander@mihalicyn.com \
    --cc=daan.j.demeyer@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=david@readahead.eu \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jack@suse.cz \
    --cc=jannh@google.com \
    --cc=kuba@kernel.org \
    --cc=kuniyu@amazon.com \
    --cc=lennart@poettering.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=luca.boccassi@gmail.com \
    --cc=me@yhndnzj.com \
    --cc=netdev@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=pabeni@redhat.com \
    --cc=serge@hallyn.com \
    --cc=stephen@networkplumber.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=zbyszek@in.waw.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox