From: Kees Cook <kees@kernel.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Thiago Jung Bauermann <thiago.bauermann@linaro.org>,
akpm@linux-foundation.org, arnd@arndb.de, broonie@kernel.org,
davidgow@google.com, diego.daniel.professional@gmail.com,
gnoack@google.com, gustavoars@kernel.org, jmorris@namei.org,
justinstitt@google.com, linux-hardening@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, linux@treblig.org,
llvm@lists.linux.dev, mcgrof@kernel.org, mic@digikod.net,
morbo@google.com, nick.desaulniers+lkml@gmail.com,
paul@paul-moore.com, pmladek@suse.com, rmoar@google.com,
serge@hallyn.com, tamird@gmail.com, wangyuli@uniontech.com
Subject: Re: [PATCH 3/3] Revert "hardening: Disable GCC randstruct for COMPILE_TEST"
Date: Fri, 30 May 2025 12:37:06 -0700 [thread overview]
Message-ID: <202505301234.4F2C365F@keescook> (raw)
In-Reply-To: <20250530190904.GA1159814@ax162>
On Fri, May 30, 2025 at 12:09:04PM -0700, Nathan Chancellor wrote:
> On Thu, May 29, 2025 at 10:12:22PM -0700, Kees Cook wrote:
> > On Thu, May 29, 2025 at 09:06:46PM -0300, Thiago Jung Bauermann wrote:
> > > This commit was reported by our CI as breaking the allmodconfig build for
> > > the arm and arm64 architectures when using GCC 15. This is due to
> > > https://github.com/KSPP/linux/issues/367 :
> > >
> > > 00:05:08 arch/arm64/kernel/kexec_image.c:132:14: internal compiler error: in comptypes_check_enum_int, at c/c-typeck.cc:1519
> > > 00:05:08 132 | const struct kexec_file_ops kexec_image_ops = {
> > > 00:05:08 | ^~~~~~~~~~~~~~
> >
> > I'm not able to reproduce this. Which specific version of GCC 15 and
> > on what distro are you seeing this?
>
> It looks like this was also reported to Debian (I originally noticed it
> in the #gcc channel on OFTC a couple of weeks ago but forgot to mention
> it):
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1104745
>
> It looks like the difference might be whether GCC was built with
> additional checks or not based on the last couple of comments in that
> bug.
Ah, thanks for the additional pointer! Yeah, discussion has continued
on https://github.com/KSPP/linux/issues/367 which shows it's a problem
for GCC builds configured with "--enable-checking=yes"
It seems like this check is overly strict? I'm building GCC now to see
which aspect of the plugin is tripping it... I assume its decl
finalization, but we'll see.
--
Kees Cook
next prev parent reply other threads:[~2025-05-30 19:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-27 1:38 [PATCH 0/3] randstruct: gcc-plugin: Remove bogus void member Kees Cook
2025-04-27 1:38 ` [PATCH 1/3] " Kees Cook
2025-04-27 1:38 ` [PATCH 2/3] lib/tests: Add randstruct KUnit test Kees Cook
2025-04-27 3:47 ` kernel test robot
2025-04-27 3:47 ` kernel test robot
2025-04-30 18:56 ` Kees Cook
2025-04-27 6:04 ` kernel test robot
2025-04-29 7:44 ` David Gow
2025-04-30 18:56 ` Kees Cook
2025-04-27 1:38 ` [PATCH 3/3] Revert "hardening: Disable GCC randstruct for COMPILE_TEST" Kees Cook
2025-05-30 0:06 ` Thiago Jung Bauermann
2025-05-30 5:12 ` Kees Cook
2025-05-30 19:09 ` Nathan Chancellor
2025-05-30 19:37 ` Kees Cook [this message]
2025-05-30 22:31 ` Kees Cook
2025-05-20 15:18 ` [PATCH 0/3] randstruct: gcc-plugin: Remove bogus void member Mickaël Salaün
2025-05-20 16:14 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202505301234.4F2C365F@keescook \
--to=kees@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=davidgow@google.com \
--cc=diego.daniel.professional@gmail.com \
--cc=gnoack@google.com \
--cc=gustavoars@kernel.org \
--cc=jmorris@namei.org \
--cc=justinstitt@google.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux@treblig.org \
--cc=llvm@lists.linux.dev \
--cc=mcgrof@kernel.org \
--cc=mic@digikod.net \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=paul@paul-moore.com \
--cc=pmladek@suse.com \
--cc=rmoar@google.com \
--cc=serge@hallyn.com \
--cc=tamird@gmail.com \
--cc=thiago.bauermann@linaro.org \
--cc=wangyuli@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox