From: Song Liu <song@kernel.org>
To: bpf@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Cc: kernel-team@meta.com, andrii@kernel.org, eddyz87@gmail.com,
ast@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev,
viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
kpsingh@kernel.org, mattbobrowski@google.com, amir73il@gmail.com,
repnop@google.com, jlayton@kernel.org, josef@toxicpanda.com,
mic@digikod.net, gnoack@google.com, m@maowtm.org,
neil@brown.name, Song Liu <song@kernel.org>
Subject: [PATCH v4 bpf-next 0/5] bpf path iterator
Date: Wed, 11 Jun 2025 15:02:15 -0700 [thread overview]
Message-ID: <20250611220220.3681382-1-song@kernel.org> (raw)
In security use cases, it is common to apply rules to VFS subtrees.
However, filtering files in a subtree is not straightforward [1].
One solution to this problem is to start from a path and walk up the VFS
tree (towards the root). Among in-tree LSMs, Landlock uses this solution.
BPF LSM solutions, such like Tetragon [2], also use similar approaches.
However, due to lack of proper helper/kfunc support, BPF LSM solutions
usually do the path walk with probe read, which is racy.
This patchset introduces a new helper path_walk_parent, which walks
path to its VFS parent. The helper is used in Landlock.
A new BPF iterator, path iterator, is introduced to do the path walking.
The BPF path iterator uses the new path_walk_parent help to walk the VFS
tree.
Changes v3 => v4:
1. Rewrite path_walk_parent based on suggestion from Neil Brown.
2. When path_walk_parent() returns false, it call path_put on @path and
then zeros @path.
v3: https://lore.kernel.org/bpf/20250606213015.255134-1-song@kernel.org/
Changes v2 => v3:
1. Fix an issue with path_walk_parent.
2. Move bpf path iterator to fs/bpf_fs_kfuncs.c
3. Optimize bpf path iterator (less memory).
4. Add more selftests.
5. Add more comments.
v2: https://lore.kernel.org/bpf/20250603065920.3404510-1-song@kernel.org/
Changes v1 => v2:
1. Rename path_parent => path_walk_parent.
2. Remove path_connected check in path_walk_parent.
3. Fix is_access_to_paths_allowed().
4. Remove mode for path iterator, add a flag instead.
v1: https://lore.kernel.org/bpf/20250528222623.1373000-1-song@kernel.org/
[1] https://lpc.events/event/18/contributions/1940/
[2] https://github.com/cilium/tetragon/
Song Liu (5):
namei: Introduce new helper function path_walk_parent()
landlock: Use path_walk_parent()
bpf: Introduce path iterator
selftests/bpf: Add tests for bpf path iterator
selftests/bpf: Path walk test
fs/bpf_fs_kfuncs.c | 72 +++++++++
fs/namei.c | 99 ++++++++++--
include/linux/namei.h | 2 +
kernel/bpf/verifier.c | 5 +
security/landlock/fs.c | 28 +---
.../testing/selftests/bpf/bpf_experimental.h | 6 +
.../selftests/bpf/prog_tests/path_iter.c | 111 ++++++++++++++
tools/testing/selftests/bpf/progs/path_iter.c | 145 ++++++++++++++++++
tools/testing/selftests/bpf/progs/path_walk.c | 59 +++++++
9 files changed, 493 insertions(+), 34 deletions(-)
create mode 100644 tools/testing/selftests/bpf/prog_tests/path_iter.c
create mode 100644 tools/testing/selftests/bpf/progs/path_iter.c
create mode 100644 tools/testing/selftests/bpf/progs/path_walk.c
--
2.47.1
next reply other threads:[~2025-06-11 22:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 22:02 Song Liu [this message]
2025-06-11 22:02 ` [PATCH v4 bpf-next 1/5] namei: Introduce new helper function path_walk_parent() Song Liu
2025-06-13 0:10 ` NeilBrown
2025-06-13 22:27 ` Song Liu
2025-06-14 18:36 ` Tingmao Wang
2025-06-17 5:08 ` Song Liu
2025-06-11 22:02 ` [PATCH v4 bpf-next 2/5] landlock: Use path_walk_parent() Song Liu
2025-06-11 22:02 ` [PATCH v4 bpf-next 3/5] bpf: Introduce path iterator Song Liu
2025-06-12 23:11 ` Andrii Nakryiko
2025-06-11 22:02 ` [PATCH v4 bpf-next 4/5] selftests/bpf: Add tests for bpf " Song Liu
2025-06-11 22:02 ` [PATCH v4 bpf-next 5/5] selftests/bpf: Path walk test Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611220220.3681382-1-song@kernel.org \
--to=song@kernel.org \
--cc=amir73il@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=gnoack@google.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@meta.com \
--cc=kpsingh@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=m@maowtm.org \
--cc=martin.lau@linux.dev \
--cc=mattbobrowski@google.com \
--cc=mic@digikod.net \
--cc=neil@brown.name \
--cc=repnop@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).