From: Al Viro <viro@zeniv.linux.org.uk>
To: linux-fsdevel@vger.kernel.org
Cc: linux-security-module@vger.kernel.org,
Christian Brauner <brauner@kernel.org>
Subject: [PATCH] selinuxfs_fill_super(): don't bother with selinuxfs_info_free() on failures
Date: Sun, 15 Jun 2025 03:01:54 +0100 [thread overview]
Message-ID: <20250615020154.GE1880847@ZenIV> (raw)
In-Reply-To: <20250615003110.GA3011112@ZenIV>
[don't really care which tree that goes through; right now it's
in viro/vfs.git #work.misc, but if somebody prefers to grab it
through a different tree, just say so]
Failures in there will be followed by sel_kill_sb(), which will call
selinuxfs_info_free() anyway.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
security/selinux/selinuxfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
index e67a8ce4b64c..b44b5919f4af 100644
--- a/security/selinux/selinuxfs.c
+++ b/security/selinux/selinuxfs.c
@@ -2097,8 +2097,6 @@ static int sel_fill_super(struct super_block *sb, struct fs_context *fc)
pr_err("SELinux: %s: failed while creating inodes\n",
__func__);
- selinux_fs_info_free(sb);
-
return ret;
}
--
2.39.5
next prev parent reply other threads:[~2025-06-15 2:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-15 0:30 [PATCH] landlock: opened file never has a negative dentry Al Viro
2025-06-15 0:31 ` [PATCH] apparmor: file never has NULL f_path.mnt Al Viro
2025-06-15 2:01 ` Al Viro [this message]
2025-06-16 14:19 ` [PATCH] selinuxfs_fill_super(): don't bother with selinuxfs_info_free() on failures Christian Brauner
2025-06-24 23:44 ` Paul Moore
2025-06-25 0:57 ` Al Viro
2025-06-16 14:16 ` [PATCH] apparmor: file never has NULL f_path.mnt Christian Brauner
2025-06-16 15:36 ` Ryan Lee
2025-06-16 14:16 ` [PATCH] landlock: opened file never has a negative dentry Christian Brauner
2025-06-17 10:03 ` Mickaël Salaün
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250615020154.GE1880847@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).