From: Chandra Mohan Sundar <chandramohan.explore@gmail.com>
To: john.johansen@canonical.com, paul@paul-moore.com,
jmorris@namei.org, serge@hallyn.com, apparmor@lists.ubuntu.com,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, shuah@kernel.org
Cc: Chandra Mohan Sundar <chandramohan.explore@gmail.com>,
linux-kernel-mentees@lists.linux.dev
Subject: [PATCH] apparmor: Remove unused value
Date: Wed, 13 Aug 2025 21:31:43 +0530 [thread overview]
Message-ID: <20250813160148.132192-1-chandramohan.explore@gmail.com> (raw)
The value "new" is being assigned to NULL but that statement does not
have effect since "new" is being overwritten in the subsequent fallback case.
Remove the unused value. This issue was reported by coverity static
analyzer.
Fixes: a9eb185be84e9 (apparmor: fix x_table_lookup)
Signed-off-by: Chandra Mohan Sundar <chandramohan.explore@gmail.com>
---
security/apparmor/domain.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/security/apparmor/domain.c b/security/apparmor/domain.c
index 267da82afb14..9c0c7fa8de46 100644
--- a/security/apparmor/domain.c
+++ b/security/apparmor/domain.c
@@ -592,7 +592,6 @@ static struct aa_label *x_to_label(struct aa_profile *profile,
if (!new || **lookupname != '&')
break;
stack = new;
- new = NULL;
fallthrough; /* to X_NAME */
case AA_X_NAME:
if (xindex & AA_X_CHILD)
--
2.43.0
reply other threads:[~2025-08-13 16:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250813160148.132192-1-chandramohan.explore@gmail.com \
--to=chandramohan.explore@gmail.com \
--cc=apparmor@lists.ubuntu.com \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).