Re: [PATCH v2 3/4] arch: copy_thread: pass clone_flags as u64

Russell King (Oracle)
2025-09-01T13:39:35Z

On Mon, Sep 01, 2025 at 03:09:52PM +0200, Simon Schuster via B4 Relay wrote:
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index e16ed102960c..d7aa95225c70 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -234,7 +234,7 @@ asmlinkage void ret_from_fork(void) __asm__("ret_from_fork");
>
> int copy_thread(struct task_struct *p, const struct kernel_clone_args *args)
> {
> - unsigned long clone_flags = args->flags;
> + u64 clone_flags = args->flags;
> unsigned long stack_start = args->stack;
> unsigned long tls = args->tls;
> struct thread_info *thread = task_thread_info(p);

We only have one user of clone_flags in this function, which is:

if (clone_flags & CLONE_SETTLS)

I would much rather clone_flags was removed, and this changed to:

if (args->flags & CLONE_SETTLS)

Thanks.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!