From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4714271440 for ; Tue, 16 Sep 2025 04:49:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757998169; cv=none; b=rzrcpkntEjfPnYE/FbeLcpw2UUdSAakwZSX9ITseopgZhBM3AA5l1LpHtEKHBOK2uxYlJ7wlnKAsf7rCZekrwOe++CoV91DMpmN1JUX55GEHn2sUdXg8VK0xM8f3sNGyi/dkONzLyqb8eZyi6hDqx7ohI9RusLEW36x38sDte20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757998169; c=relaxed/simple; bh=+qvXPu8HTVeRFaubIyM3rQFPhKws6qzYTh9yka49uSI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CQEXh9wJGW3n0UMyKQTfYCdxZ0FqTvZ/H0yshEvFhwqGQ5a25oDn21gaNxky064MncBWslxEJSCCqTxjmoWv79snwmlCuZHCiwwO1Ci2fzPjKA+HEEeAzdUjdE1AAhrrhmUIyPem5/WppKxMT2hzTgF5d/Ib4OTx3UjdizHlc4Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h23e2S6Y; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h23e2S6Y" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-b54a8c2eb5cso3984583a12.2 for ; Mon, 15 Sep 2025 21:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757998167; x=1758602967; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zSw+5V18QQW1zrEulMj1oteRdmYU7Zw4RYS7vag/74M=; b=h23e2S6YBhzCpQQF+vf3PMKlnWyaXYUwO6oF/J1csVqE8vMSVBFHJPP2kFyA7mTnw6 QwnvilGcLAzZwk5dm9UBosQKS6iNp2CfPLVNNazBVsUUUJfAbDLJfrY+mfJQkUvtu3z1 zWQax3mYP1rICXuSyt9xs3gS4/ZaW0cCGP0shYpcIQA0XBLWLYOdGS2SU+OIMLgtd4+t B4N2aRUeDCv7XMX5ZYvbbFkYrMoh8OH7RWXOt/2ZQJzUw1ujVaB2Fx6RTQa2fB9o45cH XBGVenMM6TSDsWgpoWOuPERolaNznuaoeMDBjHfKZa46SDncBp6qxbnQ5Typ86pzizmn KHhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757998167; x=1758602967; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zSw+5V18QQW1zrEulMj1oteRdmYU7Zw4RYS7vag/74M=; b=ExvCUTauB0aO4bPee6NUMwpDuvvN/JsJVMMjftD36CP8GziszxX5mPDcmGJMbC0wzc a5YeuP81laehaqVDv3R4eo9or3WMieV/hioodoDC58SyhrdfZqXOn6+CbQviAVH9hZyi 2FDwxnO8gpvUXPyPkl9/XkYyHnuc5kVrGVsm+pVSh6D6q4iqcX8Q+B+i5MciDjr32WgC MJXVyo2HamTcwPwTw0SORKKYCHa+OA+F5c+fhzVi3Q22YGAEUmnuNtNeKdj+2xsF+mEh c5di9sYAmQcNMs1U6o8NPukMD358tBYIqXNULzJQfS8zrqb/KuBwOeCVCem4Rpy1zRCl eu1g== X-Forwarded-Encrypted: i=1; AJvYcCWOLaurAN3Jc0dNTi8Yu9M5ubnODRcqVG2fyMDRx80QrarV52eYcH3THLuoMnWf/bjivRhoeQQQ7PmmoujsSv3WGxRGlkQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyuRByqleUb83JM18xVaHi8w7E1/oPAwkZVvCb4zIeSULQQAyR2 e4IH4zfmQI9S0rCRR6nSQvdyBJ/25W6bRKllM08FJEqeRpya3xeRzobb X-Gm-Gg: ASbGncufMLX5He22xbI9wLncTJe7bGXAiaFOCIRyihgWwVxpSU1tmofT7cbNXb+oQEN pCjRxVXaUFHXJFXsyByC7BnhTbBy2H8ylh9BXgjzMGB/8u+rgnxB5ygy+/IC4jmkE0orbb4r3Kt HaQI5B+HkygOI2XSOEMWiIWzKAKYK96kJy75T0UYWQhkSWfa+dmh92KYdqd0uJgzu2MTFBB0ori /JNkf8yv3y5dOQmMpa+pH/xJbNwCbV3/E1YpdC3R+SIgx5a9Jr6COFDn64KVHPy6LG7pirGkiq2 EwmzLBxR7iO7/vkF0l1cxc9F/R4zCikkOOENZfGALRCDd8t3kB0vkGghRcr74W1WDGkAO0TlR2f EcCX+clJTQp0UvPqTjK5mCuW5+zewyJ3a3XkIZKA= X-Google-Smtp-Source: AGHT+IFoVKHWE4WmC5NQoAJgz5S3HoMpNrjT8PBpaSw1vdAI3yXeG2nG2SQAkLHZCeabG5ejGwx28A== X-Received: by 2002:a17:902:ea10:b0:24e:bdfa:112b with SMTP id d9443c01a7336-25d289e9988mr159622635ad.61.1757998167045; Mon, 15 Sep 2025 21:49:27 -0700 (PDT) Received: from pengdl-pc.mioffice.cn ([43.224.245.249]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-25ef09c77f8sm104600605ad.15.2025.09.15.21.49.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 21:49:26 -0700 (PDT) From: pengdonglin To: tj@kernel.org, tony.luck@intel.com, jani.nikula@linux.intel.com, ap420073@gmail.com, jv@jvosburgh.net, freude@linux.ibm.com, bcrl@kvack.org, trondmy@kernel.org, longman@redhat.com, kees@kernel.org Cc: bigeasy@linutronix.de, hdanton@sina.com, paulmck@kernel.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-nfs@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-wireless@vger.kernel.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, cgroups@vger.kernel.org, pengdonglin , Samuel Mendoza-Jonas , Paul Fertser , pengdonglin Subject: [PATCH v3 11/14] net: ncsi: Remove redundant rcu_read_lock/unlock() in spin_lock Date: Tue, 16 Sep 2025 12:47:32 +0800 Message-Id: <20250916044735.2316171-12-dolinux.peng@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250916044735.2316171-1-dolinux.peng@gmail.com> References: <20250916044735.2316171-1-dolinux.peng@gmail.com> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: pengdonglin Since commit a8bb74acd8efe ("rcu: Consolidate RCU-sched update-side function definitions") there is no difference between rcu_read_lock(), rcu_read_lock_bh() and rcu_read_lock_sched() in terms of RCU read section and the relevant grace period. That means that spin_lock(), which implies rcu_read_lock_sched(), also implies rcu_read_lock(). There is no need no explicitly start a RCU read section if one has already been started implicitly by spin_lock(). Simplify the code and remove the inner rcu_read_lock() invocation. Cc: Samuel Mendoza-Jonas Cc: Paul Fertser Signed-off-by: pengdonglin Signed-off-by: pengdonglin --- net/ncsi/ncsi-manage.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c index 446e4e3b9553..6e36cd64a31e 100644 --- a/net/ncsi/ncsi-manage.c +++ b/net/ncsi/ncsi-manage.c @@ -650,7 +650,6 @@ static int set_one_vid(struct ncsi_dev_priv *ndp, struct ncsi_channel *nc, spin_lock_irqsave(&nc->lock, flags); - rcu_read_lock(); list_for_each_entry_rcu(vlan, &ndp->vlan_vids, list) { vid = vlan->vid; for (i = 0; i < ncf->n_vids; i++) @@ -661,7 +660,6 @@ static int set_one_vid(struct ncsi_dev_priv *ndp, struct ncsi_channel *nc, if (vid) break; } - rcu_read_unlock(); if (!vid) { /* No VLAN ID is not set */ -- 2.34.1