From: Eric Biggers <ebiggers@kernel.org>
To: KP Singh <kpsingh@kernel.org>
Cc: bpf@vger.kernel.org, linux-security-module@vger.kernel.org,
bboscaccy@linux.microsoft.com, paul@paul-moore.com,
kys@microsoft.com, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org
Subject: Re: [PATCH v5 03/12] libbpf: Implement SHA256 internal helper
Date: Sat, 27 Sep 2025 14:03:45 -0700 [thread overview]
Message-ID: <20250927210345.GE9798@quark> (raw)
In-Reply-To: <20250921133133.82062-4-kpsingh@kernel.org>
On Sun, Sep 21, 2025 at 03:31:24PM +0200, KP Singh wrote:
> Use AF_ALG sockets to not have libbpf depend on OpenSSL. The helper is
> used for the loader generation code to embed the metadata hash in the
> loader program and also by the bpf_map__make_exclusive API to calculate
> the hash of the program the map is exclusive to.
>
> Acked-by: Andrii Nakryiko <andrii@kernel.org>
> Signed-off-by: KP Singh <kpsingh@kernel.org>
Nacked-by: Eric Biggers <ebiggers@kernel.org>
No more users of AF_ALG, please. It's a huge mistake and has been
incredibly problematic over the years.
If you don't want to depend on a library, then just include some basic
SHA-256 code, similar to what I'm doing for iproute2 and SHA-1 at
https://lore.kernel.org/netdev/20250925225322.13013-1-ebiggers@kernel.org/.
I'd even be glad to write the patch for you, if you want.
- Eric
next prev parent reply other threads:[~2025-09-27 21:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-21 13:31 [PATCH v5 00/12] Signed BPF programs KP Singh
2025-09-21 13:31 ` [PATCH v5 01/12] bpf: Update the bpf_prog_calc_tag to use SHA256 KP Singh
2025-09-21 13:31 ` [PATCH v5 02/12] bpf: Implement exclusive map creation KP Singh
2025-09-21 13:31 ` [PATCH v5 03/12] libbpf: Implement SHA256 internal helper KP Singh
2025-09-27 21:03 ` Eric Biggers [this message]
2025-09-27 22:33 ` Alexei Starovoitov
2025-09-27 23:04 ` Eric Biggers
2025-09-21 13:31 ` [PATCH v5 04/12] libbpf: Support exclusive map creation KP Singh
2025-09-21 13:31 ` [PATCH v5 05/12] selftests/bpf: Add tests for exclusive maps KP Singh
2025-09-21 13:31 ` [PATCH v5 06/12] bpf: Return hashes of maps in BPF_OBJ_GET_INFO_BY_FD KP Singh
2025-09-21 13:31 ` [PATCH v5 07/12] bpf: Move the signature kfuncs to helpers.c KP Singh
2025-09-21 13:31 ` [PATCH v5 08/12] bpf: Implement signature verification for BPF programs KP Singh
2025-09-21 13:31 ` [PATCH v5 09/12] libbpf: Update light skeleton for signing KP Singh
2025-09-21 13:31 ` [PATCH v5 10/12] libbpf: Embed and verify the metadata hash in the loader KP Singh
2025-09-21 13:31 ` [PATCH v5 11/12] bpftool: Add support for signing BPF programs KP Singh
2025-09-21 13:31 ` [PATCH v5 12/12] selftests/bpf: Enable signature verification for some lskel tests KP Singh
2025-09-21 15:31 ` [PATCH v5 00/12] Signed BPF programs Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250927210345.GE9798@quark \
--to=ebiggers@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bboscaccy@linux.microsoft.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kpsingh@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).