From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC6173451D4; Thu, 18 Dec 2025 13:53:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766066035; cv=none; b=NZj4SwPVukajfbGdsmCD1LRKxdV9cP+rQoIRa6iMXrHz2Yh2mYOI5d+MPXFmQ9UEcQ8od/rG/NIVYLjIts6V0h+7lUwoBBh/ZhSYGIY2U+Z2hLx1WKUYrYY58nmZ64yKmzR/cMeeNrIkr2Nw9dq2bk9q1Jr0QHnXOB4OgECCwuE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766066035; c=relaxed/simple; bh=Gb408fVHMLonuRAakmkxdDWU8SK3ZsmJh94vFt7tIrA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Sy5Kps4BUbytZho+L8HpW9BKnfO5Kj85SwMDBJSWLpyo3JS/FoTKpi4++TuNbNHmGfkQg1aEcyUyOKlFe2i7BMVn3fkicvH9mI+UboBNz0T4Ngr42S9ec8TdeLxeNjYErKwmtIcrU83JuJAsAxnk0UptTg02W6FLPtT8AHJZ+tw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=qFohZZY8; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="qFohZZY8" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id D8E6D4E41C86; Thu, 18 Dec 2025 13:53:48 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id A4BEE606B6; Thu, 18 Dec 2025 13:53:48 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 66249102F0B2D; Thu, 18 Dec 2025 14:53:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1766066026; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=RhgSGQYStNGcdPoB3dTlM/CB5TE2tva/NS/z3ptd3wM=; b=qFohZZY8adtmwbRo28+tcgXOIuD5T9ZV6GmStiiS0ZAEXQPvVe9Zcnoe53YsCQv7j9c1kT pTrvVf3pcUkunP7HW/oQvdBg/Lk3nsGsCiYCx3SHIHn49cINe+SDypYYTUNdpwsJxK0JVh ocSroqcU2Nk7str55AMgKkPgbWDRxk2+yhvbttnAqOzQlGRqdP2i4+xde+ODjyK3Zpm5be ZSBh2N3dOdtUob6QOjlSHuVExl0oaNjoD8HBgFGaCPqRDPAFBwnRVvZxfM0UXeEISM/0Op YG/ULfUWn7tCLkV8LWmaP9dHfiDTFdsnlQ2sM6hNfJi3OczZvwptkZvMOkvVJQ== Date: Thu, 18 Dec 2025 14:53:32 +0100 From: Alexandre Belloni To: Jens Wiklander Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Jonathan Corbet , Sumit Garg , Olivia Mackall , Herbert Xu , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Ard Biesheuvel , Maxime Coquelin , Alexandre Torgue , Sumit Garg , Ilias Apalodimas , Jan Kiszka , Sudeep Holla , Christophe JAILLET , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Michael Chan , Pavan Chebbi , James Bottomley , Jarkko Sakkinen , Mimi Zohar , David Howells , Paul Moore , James Morris , "Serge E. Hallyn" , Peter Huewe , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org, linux-rtc@vger.kernel.org, linux-efi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Cristian Marussi , arm-scmi@vger.kernel.org, linux-mips@vger.kernel.org, netdev@vger.kernel.org, linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH v2 00/17] tee: Use bus callbacks instead of driver callbacks Message-ID: <20251218135332f323fa91@mail.local> References: Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 On 18/12/2025 08:21:27+0100, Jens Wiklander wrote: > Hi, > > On Mon, Dec 15, 2025 at 3:17 PM Uwe Kleine-König > wrote: > > > > Hello, > > > > the objective of this series is to make tee driver stop using callbacks > > in struct device_driver. These were superseded by bus methods in 2006 > > (commit 594c8281f905 ("[PATCH] Add bus_type probe, remove, shutdown > > methods.")) but nobody cared to convert all subsystems accordingly. > > > > Here the tee drivers are converted. The first commit is somewhat > > unrelated, but simplifies the conversion (and the drivers). It > > introduces driver registration helpers that care about setting the bus > > and owner. (The latter is missing in all drivers, so by using these > > helpers the drivers become more correct.) > > > > v1 of this series is available at > > https://lore.kernel.org/all/cover.1765472125.git.u.kleine-koenig@baylibre.com > > > > Changes since v1: > > > > - rebase to v6.19-rc1 (no conflicts) > > - add tags received so far > > - fix whitespace issues pointed out by Sumit Garg > > - fix shutdown callback to shutdown and not remove > > > > As already noted in v1's cover letter, this series should go in during a > > single merge window as there are runtime warnings when the series is > > only applied partially. Sumit Garg suggested to apply the whole series > > via Jens Wiklander's tree. > > If this is done the dependencies in this series are honored, in case the > > plan changes: Patches #4 - #17 depend on the first two. > > > > Note this series is only build tested. > > > > Uwe Kleine-König (17): > > tee: Add some helpers to reduce boilerplate for tee client drivers > > tee: Add probe, remove and shutdown bus callbacks to tee_client_driver > > tee: Adapt documentation to cover recent additions > > hwrng: optee - Make use of module_tee_client_driver() > > hwrng: optee - Make use of tee bus methods > > rtc: optee: Migrate to use tee specific driver registration function > > rtc: optee: Make use of tee bus methods > > efi: stmm: Make use of module_tee_client_driver() > > efi: stmm: Make use of tee bus methods > > firmware: arm_scmi: optee: Make use of module_tee_client_driver() > > firmware: arm_scmi: Make use of tee bus methods > > firmware: tee_bnxt: Make use of module_tee_client_driver() > > firmware: tee_bnxt: Make use of tee bus methods > > KEYS: trusted: Migrate to use tee specific driver registration > > function > > KEYS: trusted: Make use of tee bus methods > > tpm/tpm_ftpm_tee: Make use of tee specific driver registration > > tpm/tpm_ftpm_tee: Make use of tee bus methods > > > > Documentation/driver-api/tee.rst | 18 +---- > > drivers/char/hw_random/optee-rng.c | 26 ++---- > > drivers/char/tpm/tpm_ftpm_tee.c | 31 +++++--- > > drivers/firmware/arm_scmi/transports/optee.c | 32 +++----- > > drivers/firmware/broadcom/tee_bnxt_fw.c | 30 ++----- > > drivers/firmware/efi/stmm/tee_stmm_efi.c | 25 ++---- > > drivers/rtc/rtc-optee.c | 27 ++----- > > drivers/tee/tee_core.c | 84 ++++++++++++++++++++ > > include/linux/tee_drv.h | 12 +++ > > security/keys/trusted-keys/trusted_tee.c | 17 ++-- > > 10 files changed, 164 insertions(+), 138 deletions(-) > > > > base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8 > > -- > > 2.47.3 > > > > Thank you for the nice cleanup, Uwe. > > I've applied patch 1-3 to the branch tee_bus_callback_for_6.20 in my > tree at https://git.kernel.org/pub/scm/linux/kernel/git/jenswi/linux-tee.git/ > > The branch is based on v6.19-rc1, and I'll try to keep it stable for > others to depend on, if needed. Let's see if we can agree on taking > the remaining patches via that branch. 6 and 7 can go through your branch. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com