public inbox for linux-security-module@vger.kernel.org
 help / color / mirror / Atom feed
From: "Mickaël Salaün" <mic@digikod.net>
To: "Günther Noack" <gnoack3000@gmail.com>
Cc: John Johansen <john.johansen@canonical.com>,
	 Justin Suess <utilityemal77@gmail.com>,
	linux-security-module@vger.kernel.org,
	 Tingmao Wang <m@maowtm.org>,
	Samasth Norway Ananda <samasth.norway.ananda@oracle.com>,
	 Matthieu Buffet <matthieu@buffet.re>,
	Mikhail Ivanov <ivanov.mikhail1@huawei-partners.com>,
	 konstantin.meskhidze@huawei.com,
	Demi Marie Obenour <demiobenour@gmail.com>,
	 Alyssa Ross <hi@alyssa.is>, Jann Horn <jannh@google.com>,
	 Tahera Fahimi <fahimitahera@gmail.com>
Subject: Re: [PATCH v5 3/9] samples/landlock: Add support for named UNIX domain socket restrictions
Date: Wed, 18 Feb 2026 10:37:31 +0100	[thread overview]
Message-ID: <20260218.ufao5Vaefa2u@digikod.net> (raw)
In-Reply-To: <20260215105158.28132-4-gnoack3000@gmail.com>

On Sun, Feb 15, 2026 at 11:51:51AM +0100, Günther Noack wrote:
> The access right for UNIX domain socket lookups is grouped with the
> read-write rights in the sample tool.  Rationale: In the general case,
> any operations are possible through a UNIX domain socket, including
> data-mutating operations.
> 
> Cc: Justin Suess <utilityemal77@gmail.com>
> Cc: Mickaël Salaün <mic@digikod.net>
> Signed-off-by: Günther Noack <gnoack3000@gmail.com>
> ---
>  samples/landlock/sandboxer.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/samples/landlock/sandboxer.c b/samples/landlock/sandboxer.c
> index e7af02f98208..0bbbc5c9ead6 100644
> --- a/samples/landlock/sandboxer.c
> +++ b/samples/landlock/sandboxer.c
> @@ -111,7 +111,8 @@ static int parse_path(char *env_path, const char ***const path_list)
>  	LANDLOCK_ACCESS_FS_WRITE_FILE | \
>  	LANDLOCK_ACCESS_FS_READ_FILE | \
>  	LANDLOCK_ACCESS_FS_TRUNCATE | \
> -	LANDLOCK_ACCESS_FS_IOCTL_DEV)
> +	LANDLOCK_ACCESS_FS_IOCTL_DEV | \
> +	LANDLOCK_ACCESS_FS_RESOLVE_UNIX)
>  
>  /* clang-format on */
>  
> @@ -295,11 +296,12 @@ static bool check_ruleset_scope(const char *const env_var,
>  	LANDLOCK_ACCESS_FS_MAKE_SYM | \
>  	LANDLOCK_ACCESS_FS_REFER | \
>  	LANDLOCK_ACCESS_FS_TRUNCATE | \
> -	LANDLOCK_ACCESS_FS_IOCTL_DEV)
> +	LANDLOCK_ACCESS_FS_IOCTL_DEV | \
> +	LANDLOCK_ACCESS_FS_RESOLVE_UNIX)
>  
>  /* clang-format on */
>  
> -#define LANDLOCK_ABI_LAST 7
> +#define LANDLOCK_ABI_LAST 9
>  
>  #define XSTR(s) #s
>  #define STR(s) XSTR(s)
> @@ -444,6 +446,13 @@ int main(const int argc, char *const argv[], char *const *const envp)
>  			"provided by ABI version %d (instead of %d).\n",
>  			LANDLOCK_ABI_LAST, abi);
>  		__attribute__((fallthrough));
> +	case 7:
> +		__attribute__((fallthrough));

The current code should print the hint when ABI <= 7.  Please send a
dedicated patch to fix the TSYNC-related changes.

> +	case 8:
> +		/* Removes LANDLOCK_ACCESS_FS_RESOLVE_UNIX for ABI < 9 */
> +		ruleset_attr.handled_access_fs &=
> +			~LANDLOCK_ACCESS_FS_RESOLVE_UNIX;
> +		__attribute__((fallthrough));
>  	case LANDLOCK_ABI_LAST:
>  		break;
>  	default:
> -- 
> 2.52.0
> 
> 

  reply	other threads:[~2026-02-18  9:56 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-15 10:51 [PATCH v5 0/9] landlock: UNIX connect() control by pathname and scope Günther Noack
2026-02-15 10:51 ` [PATCH v5 1/9] lsm: Add LSM hook security_unix_find Günther Noack
2026-02-18  9:36   ` Mickaël Salaün
2026-02-19 13:26     ` Justin Suess
2026-02-19 20:04       ` [PATCH v6] " Justin Suess
2026-02-19 20:26         ` Günther Noack
2026-03-10 22:39           ` Paul Moore
2026-03-11 12:34             ` Justin Suess
2026-03-11 16:08               ` Paul Moore
2026-03-12 11:57                 ` Günther Noack
2026-02-20 15:49         ` Günther Noack
2026-02-21 13:22           ` Justin Suess
2026-02-23 16:09             ` Mickaël Salaün
2026-02-15 10:51 ` [PATCH v5 2/9] landlock: Control pathname UNIX domain socket resolution by path Günther Noack
2026-02-18  9:37   ` Mickaël Salaün
2026-02-19  9:45     ` Mickaël Salaün
2026-02-19 13:59       ` Günther Noack
2026-03-08  9:09         ` Mickaël Salaün
2026-03-08 11:50           ` Mickaël Salaün
2026-03-14 23:15             ` Günther Noack
2026-03-17 21:14               ` Mickaël Salaün
2026-02-20 14:33     ` Günther Noack
2026-03-08  9:18       ` Mickaël Salaün
2026-03-10 15:19         ` Sebastian Andrzej Siewior
2026-03-11  4:46         ` Kuniyuki Iwashima
2026-03-08  9:09   ` Mickaël Salaün
2026-03-15 20:58     ` Günther Noack
2026-02-15 10:51 ` [PATCH v5 3/9] samples/landlock: Add support for named UNIX domain socket restrictions Günther Noack
2026-02-18  9:37   ` Mickaël Salaün [this message]
2026-02-20 16:08     ` Günther Noack
2026-02-15 10:51 ` [PATCH v5 4/9] landlock/selftests: Test LANDLOCK_ACCESS_FS_RESOLVE_UNIX Günther Noack
2026-02-18 19:11   ` Mickaël Salaün
2026-02-20 16:27     ` Günther Noack
2026-02-20 17:04       ` Günther Noack
2026-02-15 10:51 ` [PATCH v5 5/9] landlock/selftests: Audit test for LANDLOCK_ACCESS_FS_RESOLVE_UNIX Günther Noack
2026-02-15 10:51 ` [PATCH v5 6/9] landlock/selftests: Check that coredump sockets stay unrestricted Günther Noack
2026-02-18 20:05   ` Mickaël Salaün
2026-02-15 10:51 ` [PATCH v5 7/9] landlock/selftests: fs_test: Simplify ruleset creation and enforcement Günther Noack
2026-02-15 10:51 ` [PATCH v5 8/9] landlock: Document FS access right for pathname UNIX sockets Günther Noack
2026-02-18  9:39   ` Mickaël Salaün
2026-03-14 21:16     ` Günther Noack
2026-02-15 10:51 ` [PATCH v5 9/9] landlock: Document design rationale for scoped access rights Günther Noack
2026-02-15 18:09   ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260218.ufao5Vaefa2u@digikod.net \
    --to=mic@digikod.net \
    --cc=demiobenour@gmail.com \
    --cc=fahimitahera@gmail.com \
    --cc=gnoack3000@gmail.com \
    --cc=hi@alyssa.is \
    --cc=ivanov.mikhail1@huawei-partners.com \
    --cc=jannh@google.com \
    --cc=john.johansen@canonical.com \
    --cc=konstantin.meskhidze@huawei.com \
    --cc=linux-security-module@vger.kernel.org \
    --cc=m@maowtm.org \
    --cc=matthieu@buffet.re \
    --cc=samasth.norway.ananda@oracle.com \
    --cc=utilityemal77@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox