From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAD50345738 for ; Thu, 19 Mar 2026 06:25:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773901517; cv=none; b=d30IcclFFEtLV8KJioZmfupaIoo7Seo0lE8q3C2PwRfMncubOJnghI/5mo5c8p204y+gb2b01baGg18inppLirET/bXy8wz3jQNjG+HQZ4DnqgVHNeJljGrQPQw4vDf2/y2GuyuFYnaQGR6ivYD5UX3C85+dW5fSRzFmdLnIIYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773901517; c=relaxed/simple; bh=qGqiE3KUBrPkxudnJPpgi7Dxk2L7pvIBgsd4DlVGYN8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NsvVL9oSkLwYsXj0UOahfVlBW42IX4d7a/omsq7XnVGgDY/odIGbcXwcXkZxm2gUWQKd4niFVmKRaum++woCN299vT9utDMdQfiEDKW+YUGnav4BHM2B71o930XMhJO9cpBTnsHTHzF64DUF+hfvP+aZMEqLWbc5sYFfVc0iGlw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=quora.org; spf=pass smtp.mailfrom=quora.org; dkim=pass (1024-bit key) header.d=quora.org header.i=@quora.org header.b=Ad3EZLF4; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=quora.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quora.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=quora.org header.i=@quora.org header.b="Ad3EZLF4" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-82735a41920so289005b3a.2 for ; Wed, 18 Mar 2026 23:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quora.org; s=google; t=1773901514; x=1774506314; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7i2hgB7wzWd0GpL7ZbSfJdBzEQ6VsuZDuvwguDkWp8I=; b=Ad3EZLF4lL/KOFXTNOnjmQBHvHOhTYxo92sN9dz0QBiuosv+KgmYzMZ3HuFO2ubGfm UP6KoJVbdVxNaRpf4Ix6VqSvBh5PmjyTJKv9Bo2g7ZOGAZ4/XbcJJpDzEPDTFkhSjpax oFc1sJBlDBTfTLEiEm1CMp8QWQxRt7NnWfMeA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773901514; x=1774506314; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7i2hgB7wzWd0GpL7ZbSfJdBzEQ6VsuZDuvwguDkWp8I=; b=o9kOM5BCEmdLUy6afMXQO09HFU+fguc78f7MsR5kK5xsaNVS8DiXOQuKAUW1J9+mYz aEv4sYYxHCChFz/NluLPL+BM5llgisYqKcS+puZruYtSKr4+89YA2VMm939BGhP0bwjp IJ9a7eA5kh1o72zMjIJF2xu4oygHeTLdrAQE3zTW3iKEf1ACsQFl/bMbMZ/e38Gs1wZW ilrfif8kz/uCxHrrxU1JWbaElgso4eRarHOUphDgPZWN2KNYMUzo0LFaS6JVa9UYj0AX KJi+K+6xYwxz13PHvHCETHUVqu9yHVpwG6sUPniLRuOoNyi8myT7c6SWrumbN5ufu2IR CT7Q== X-Forwarded-Encrypted: i=1; AJvYcCVq9DpiiTSbRFsDkH1JnNMIzOMA/TTmOk7J6erLy4A6EZgywKUZlDTzpuBUDWI3VIEVoCUFT5+zJn3h693ICrqzr8hfMBI=@vger.kernel.org X-Gm-Message-State: AOJu0YxSmVcuDGIs22EED7PL3TU7Dqyrk69TLR6zeN/L1hXNsMdVev37 RZTUZI8yK6UBWMCg5EaaafCjmF5IdX8RRAycT0hl3AmgCy7CYFa740078UqfTT/d+wo= X-Gm-Gg: ATEYQzxIUkjqaqEDe+IHSVsC1jMSLKYz0mxMaLaDnQSHbHE3OAQl0LhqTaPG54+Btqj oXAD1DZwLed0C4XKSiABPdjVzJyobZ6ntQvHNjrsGocXxPPZZ3LrVsTd4iSEw13dp6nKtfV1vUx iOnOMmEiJn7LkVjDPZToCDnEJDdYLOKkHpje+xFoVhsnIc2uKc2XE9q+9m+25NOPS9dGDHfCsX7 ERI5aozQpziUNa36dM+TBnvX9PriQ+a2fegKiHBSDQ4wwi3tmAwFFawilJpTEV/uQF6UP6WVSgH mcRTeugPEttZBJ3Kijq1nYrrfg9ZG1qjmmGp3ntaMFgDSsZfV/qPtRK/N7918OvIjwCsokuRQyj DU11ynfzeex1ISg7HIdUTYLHHLPGhxODf9t3lMmLczWXWD8+KZztXRHIr+9usJFrSKF8ap5DXVH yczPFFGm5z16yipHVvrDvWZWr1uOWTF4CQGIZLYOki2O9rNWxmi9xjITcuMt5ZvT1Ujy+GSzmyl pHEX/I+hqHrSUyncrxAZ+NtrStwD+j9Jhv6WJ3jXNCbzQzfwMnyckTCwQobRCFS2ZZuxQaC+MUg MbM23+DvvnhS6NbbDoJ0LmmHd4Df9jiOtLqlRU+6rlOCe2f/xj7jAGFBKa4i1cNivo6nY3DbseY EiSe8CbwM X-Received: by 2002:a05:6a00:1793:b0:821:a7b6:10a3 with SMTP id d2e1a72fcca58-82a6aed86ebmr5705451b3a.34.1773901514187; Wed, 18 Mar 2026 23:25:14 -0700 (PDT) Received: from aegis.localdomain ([49.148.247.44]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a6bbb2f34sm4862353b3a.30.2026.03.18.23.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 23:25:13 -0700 (PDT) From: Daniel J Blueman To: John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" Cc: Thorsten Blum , apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Daniel J Blueman Subject: [PATCH] apparmor: Fix string overrun due to missing termination Date: Thu, 19 Mar 2026 14:24:32 +0800 Message-ID: <20260319062433.17648-1-daniel@quora.org> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When booting Ubuntu 26.04 with Linux 7.0-rc4 on an ARM64 Qualcomm Snapdragon X1 we see a string buffer overrun: BUG: KASAN: slab-out-of-bounds in aa_dfa_match (security/apparmor/match.c:535) Read of size 1 at addr ffff0008901cc000 by task snap-update-ns/2120 CPU: 5 UID: 60578 PID: 2120 Comm: snap-update-ns Not tainted 7.0.0-rc4+ #22 PREEMPTLAZY Hardware name: LENOVO 83ED/LNVNB161216, BIOS NHCN60WW 09/11/2025 Call trace: show_stack (arch/arm64/kernel/stacktrace.c:501) (C) dump_stack_lvl (lib/dump_stack.c:122) print_report (mm/kasan/report.c:379 mm/kasan/report.c:482) kasan_report (mm/kasan/report.c:597) __asan_report_load1_noabort (mm/kasan/report_generic.c:378) aa_dfa_match (security/apparmor/match.c:535) match_mnt_path_str (security/apparmor/mount.c:244 security/apparmor/mount.c:336) match_mnt (security/apparmor/mount.c:371) aa_bind_mount (security/apparmor/mount.c:447 (discriminator 4)) apparmor_sb_mount (security/apparmor/lsm.c:719 (discriminator 1)) security_sb_mount (security/security.c:1062 (discriminator 31)) path_mount (fs/namespace.c:4101) __arm64_sys_mount (fs/namespace.c:4172 fs/namespace.c:4361 fs/namespace.c:4338 fs/namespace.c:4338) invoke_syscall.constprop.0 (arch/arm64/kernel/syscall.c:35 arch/arm64/kernel/syscall.c:49) el0_svc_common.constprop.0 (./include/linux/thread_info.h:142 (discriminator 2) arch/arm64/kernel/syscall.c:140 (discriminator 2)) do_el0_svc (arch/arm64/kernel/syscall.c:152) el0_svc (arch/arm64/kernel/entry-common.c:80 arch/arm64/kernel/entry-common.c:725) el0t_64_sync_handler (arch/arm64/kernel/entry-common.c:744) el0t_64_sync (arch/arm64/kernel/entry.S:596) Allocated by task 2120: kasan_save_stack (mm/kasan/common.c:58) kasan_save_track (./arch/arm64/include/asm/current.h:19 mm/kasan/common.c:70 mm/kasan/common.c:79) kasan_save_alloc_info (mm/kasan/generic.c:571) __kasan_kmalloc (mm/kasan/common.c:419) __kmalloc_noprof (./include/linux/kasan.h:263 mm/slub.c:5260 mm/slub.c:5272) aa_get_buffer (security/apparmor/lsm.c:2201) aa_bind_mount (security/apparmor/mount.c:442) apparmor_sb_mount (security/apparmor/lsm.c:719 (discriminator 1)) security_sb_mount (security/security.c:1062 (discriminator 31)) path_mount (fs/namespace.c:4101) __arm64_sys_mount (fs/namespace.c:4172 fs/namespace.c:4361 fs/namespace.c:4338 fs/namespace.c:4338) invoke_syscall.constprop.0 (arch/arm64/kernel/syscall.c:35 arch/arm64/kernel/syscall.c:49) el0_svc_common.constprop.0 (./include/linux/thread_info.h:142 (discriminator 2) arch/arm64/kernel/syscall.c:140 (discriminator 2)) do_el0_svc (arch/arm64/kernel/syscall.c:152) el0_svc (arch/arm64/kernel/entry-common.c:80 arch/arm64/kernel/entry-common.c:725) el0t_64_sync_handler (arch/arm64/kernel/entry-common.c:744) el0t_64_sync (arch/arm64/kernel/entry.S:596) The buggy address belongs to the object at ffff0008901ca000 which belongs to the cache kmalloc-rnd-06-8k of size 8192 The buggy address is located 0 bytes to the right of allocated 8192-byte region [ffff0008901ca000, ffff0008901cc000) The buggy address belongs to the physical page: page: refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x9101c8 head: order:3 mapcount:0 entire_mapcount:0 nr_pages_mapped:-1 pincount:0 flags: 0x8000000000000040(head|zone=2) page_type: f5(slab) raw: 8000000000000040 ffff000800016c40 fffffdffe2d14e10 ffff000800015c70 raw: 0000000000000000 0000000800010001 00000000f5000000 0000000000000000 head: 8000000000000040 ffff000800016c40 fffffdffe2d14e10 ffff000800015c70 head: 0000000000000000 0000000800010001 00000000f5000000 0000000000000000 head: 8000000000000003 fffffdffe2407201 fffffdffffffffff 00000000ffffffff head: ffffffffffffffff 0000000000000000 00000000ffffffff 0000000000000008 page dumped because: kasan: bad access detected Memory state around the buggy address: ffff0008901cbf00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ffff0008901cbf80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 >ffff0008901cc000: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ^ ffff0008901cc080: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ffff0008901cc100: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc This was introduced by previous incorrect conversion from strcpy(). Fix it by adding the missing terminator. Signed-off-by: Daniel J Blueman Fixes: 93d4dbdc8da0 ("apparmor: Replace deprecated strcpy in d_namespace_path") --- security/apparmor/path.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/security/apparmor/path.c b/security/apparmor/path.c index 65a0ca5cc1bd..2494e8101538 100644 --- a/security/apparmor/path.c +++ b/security/apparmor/path.c @@ -164,14 +164,16 @@ static int d_namespace_path(const struct path *path, char *buf, char **name, } out: - /* Append "/" to directory paths, except for root "/" which - * already ends in a slash. + /* Append "/" to directory paths and reterminate string, except for + * root "/" which already ends in a slash. */ if (!error && isdir) { bool is_root = (*name)[0] == '/' && (*name)[1] == '\0'; - if (!is_root) + if (!is_root) { buf[aa_g_path_max - 2] = '/'; + buf[aa_g_path_max - 1] = '\0'; + } } return error; -- 2.53.0