From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f43.google.com (mail-yx1-f43.google.com [74.125.224.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E75C937996C for ; Tue, 7 Apr 2026 20:02:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775592142; cv=none; b=eGkngy8ae6kUydxSrFfGPuPDi0JxGli+RbTSvVTZWp0laKL2WE0u5KKXFc3p2NiXSStdQr5q176gj/59TpiKScnhQblVT6f5dEG0CWReyn/SPZx7S9oDq0aHiQ21grz6HFtPYBba/gvpxc3Dz/2Lt6ZVSRmS29WJv7mqUgKHmnE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775592142; c=relaxed/simple; bh=T970uGi8fhSxDf5ZZOo6ka09fyjrPVUW8XM/9F6ScEo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HCGwLSt+lXQuEIfLhb9I5QwTi/nonMjUmhmbNYPeHfCPPHm5pVb3IMnZTlo9kQS/m2FiOLdzrNf9PPXpjEITEHcmu/Y7+8Tur/6XHSnyGHHWWAy2d7NgxOaHPo08ookrdy5yjHgoQ3VbpIuvfdEIgARYHa7RGIjjtkaPm/Rflmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BRJNkLTe; arc=none smtp.client-ip=74.125.224.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BRJNkLTe" Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-650789b22e3so1727653d50.1 for ; Tue, 07 Apr 2026 13:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775592140; x=1776196940; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BuKJbhdjkkPHzvIeZz/hT1B94AyhjIeMJIbjPCMSPwA=; b=BRJNkLTetmGqdXoLKweuVtjNPWuUc+HKrpHUNM786kQobwUxW0WFyj/bhwQptJhsBW sdvuyZ6cM0h+42DR2lEJmVy0l0zhFYmsfRJKgH4dbIFnGph2bPsn97ev72Bq36fLns/j WzoPgDh1gIc93lt4SmslLTpnMK2ZewisWh2YPMgr1g+jyg9J8vGlDzt6tqeYE7ObWdc5 cohS4VLWmvswdoAO2VB21fhvaS+y3U+CQPtpVA4uyPq6/ZY6mFeAeZN634SPhYmxFGxP U33xLwUDdCLMCdcriiEeVonVOJbgQtkzBskdarKzAh3Zc9yLiQMqjeF62HTb2y66MQza na3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775592140; x=1776196940; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BuKJbhdjkkPHzvIeZz/hT1B94AyhjIeMJIbjPCMSPwA=; b=Ea+k/97AvWzxl3Ym/wdBAlDX9VqAClBCWBE9m6Tq6c6KvdkRT2QYNbzZLBX7mJiw5O TCiqhOnBQrwyYF/YpHxEC9NqwLU/4/UJK1fiwmYxdUuAvnHQPXgQaeAv20eeP8eW781q E7idtgcdKq+vqk2ebNCjQsOdRW+BVV0bn4ZnUw2dapzxiuOIB7PbQtdxaA822B2rhYDf 4UXM+SkyLDkvMyNsx4DCe586BXkBDTjqemQ0O2PMQktm2PdVhUCaOe8NgjqEL9QAffrV 6HUt3Lmc645iCZEjW2Ka/nZSF981YwBIcgihSXxjTFjR3KpPcvAtQx5HetOEfHzc6D0r DV6g== X-Forwarded-Encrypted: i=1; AJvYcCX8fniNVfCeCEFkwK0YcbCXAUSKkMpq9iP4fAqTEQRqCJrfqnzT5wtW8M0rHFmBhYhpGTu7Va1DCc+VgldfMflA92g3350=@vger.kernel.org X-Gm-Message-State: AOJu0Yym7eo58MFbo/x0TMfNdn3R8SsZfAebZYyySzVmfi2uQlEiEaEB p/MCRm3SNnFfYMDkV911Xcnqm3IK1/n6veH4OY+cm6xARxxJCv6ezxQj X-Gm-Gg: AeBDieunoVBK/Kc5a2EaaH+Xi+L4XwKUUz7ZOLw8+qbtsYp5bphf2VHGfM4zVm4CUxg 0UtYH2eAmXAlxUsOfJByC7WST93FzdX3TEhaaW1SFUx2DGFGbfHFmAc1HzXEJW7EnP11jquLMVC V/4v1fynSmFjTtLD9LncGh9ahOaZUAhv+Uk969o1KGVuTlGdRsnCpaDuyO4TYIipzUCAAggeaHe JieVNW3a2Igx/uKiXFklbdTWneVcJCYi3ksmMsLhg0Dzu6OoWPpeCOi4L3v4x9ey0OYfOoRSyej 0xAUygPuFAYZ82TmjRTZ3XYA60UvFzYDOgMfZ4lWiNQZjKFTkSXR7xeHokhMYPcxe7uFGjRqdTs 3kSqlNSbqjrPrgGYTdT1r1sEU8d4NtyFaTQ6NRsJVqMAG42hdNEPMjt8XYp5EcmaQAbyB4rlCn6 LRU17/oj1tCsGcSVhOmDRyYmm1YZYrAdm0gBA0fA7aXyGcqY2tHOp6bqa7NhNsgUIQAzfyk8xu X-Received: by 2002:a53:ad4c:0:b0:650:211f:1d4 with SMTP id 956f58d0204a3-6504886c5c4mr11830030d50.47.1775592139804; Tue, 07 Apr 2026 13:02:19 -0700 (PDT) Received: from zenbox.prizrak.me ([2600:1700:18fb:6011:92f8:8594:e84e:1d9a]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6503a828f3csm8354078d50.3.2026.04.07.13.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 13:02:19 -0700 (PDT) From: Justin Suess To: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kpsingh@kernel.org, paul@paul-moore.com, mic@digikod.net, viro@zeniv.linux.org.uk, brauner@kernel.org, kees@kernel.org Cc: gnoack@google.com, jack@suse.cz, jmorris@namei.org, serge@hallyn.com, song@kernel.org, yonghong.song@linux.dev, martin.lau@linux.dev, m@maowtm.org, eddyz87@gmail.com, john.fastabend@gmail.com, sdf@fomichev.me, skhan@linuxfoundation.org, bpf@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Justin Suess Subject: [RFC PATCH 05/20] landlock: Make ruleset deferred free RCU safe Date: Tue, 7 Apr 2026 16:01:27 -0400 Message-ID: <20260407200157.3874806-6-utilityemal77@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407200157.3874806-1-utilityemal77@gmail.com> References: <20260407200157.3874806-1-utilityemal77@gmail.com> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use INIT_RCU_WORK in the landlock deferred free function, ensuring that deferred ruleset freeing is also RCU safe. This is important for future consumers who may free a Landlock ruleset under RCU in subsequent patches. Signed-off-by: Justin Suess --- security/landlock/ruleset.c | 9 +++++---- security/landlock/ruleset.h | 6 +++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/security/landlock/ruleset.c b/security/landlock/ruleset.c index 4f0305796165..5845cdc58d0d 100644 --- a/security/landlock/ruleset.c +++ b/security/landlock/ruleset.c @@ -699,16 +699,17 @@ static void free_ruleset_work(struct work_struct *const work) { struct landlock_ruleset *ruleset; - ruleset = container_of(work, struct landlock_ruleset, work_free); + ruleset = container_of(to_rcu_work(work), struct landlock_ruleset, + work_free); free_ruleset(ruleset); } -/* Only called by hook_cred_free(). */ +/* Called by deferred ruleset owners that cannot free from their context. */ void landlock_put_ruleset_deferred(struct landlock_ruleset *const ruleset) { if (ruleset && refcount_dec_and_test(&ruleset->usage)) { - INIT_WORK(&ruleset->work_free, free_ruleset_work); - schedule_work(&ruleset->work_free); + INIT_RCU_WORK(&ruleset->work_free, free_ruleset_work); + queue_rcu_work(system_wq, &ruleset->work_free); } } diff --git a/security/landlock/ruleset.h b/security/landlock/ruleset.h index 0facc5cb6555..fbbd1b73476e 100644 --- a/security/landlock/ruleset.h +++ b/security/landlock/ruleset.h @@ -146,13 +146,13 @@ struct landlock_ruleset { struct landlock_hierarchy *hierarchy; union { /** - * @work_free: Enables to free a ruleset within a lockless - * section. This is only used by + * @work_free: Enables to free a ruleset after an RCU grace + * period from a sleepable context. This is only used by * landlock_put_ruleset_deferred() when @usage reaches zero. * The fields @lock, @usage, @num_rules, @num_layers and * @access_masks are then unused. */ - struct work_struct work_free; + struct rcu_work work_free; struct { /** * @lock: Protects against concurrent modifications of -- 2.53.0