From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 656AA21771B; Thu, 23 Apr 2026 09:13:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776935591; cv=none; b=mIZJ6JMTcHoY0jGx5Bz5vCURVQ8ALfeRfjPil2mmv61zv8jppmEsV0S/bpcBQRC4FzDpDj9vbHwuMDuzP61qIl2S9fwCzxyWQ91Xf6i+tW4BpdVfhFWxJmhz2sejWu4CpohsIn3TSHXlBDNPMzeq3hoDuDFK3oVPjaqYMvDBdU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776935591; c=relaxed/simple; bh=I8yq6oDEe4IHbD8yPEv7ivQ6TWif+Z1YOjsoLQles1E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D08oY/EYG2M80KNMNm0/2KU3oyjXCfR56deoyo3q7SshSPdcb1psagP8L3M2lJmZaBriTNtNcfrfvIdA2b9JOPxLGhCapYf5vg6ePseRAuWuZWxhUBW0FuzF3VKn9jMkavs0oJWxkSmwGpQ+G10dhFBurCIf0mz6fHUYB0wskMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dQOMP5f0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dQOMP5f0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E36FC2BCAF; Thu, 23 Apr 2026 09:13:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776935590; bh=I8yq6oDEe4IHbD8yPEv7ivQ6TWif+Z1YOjsoLQles1E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dQOMP5f0VjHvc+YmGVPGeaieUSfRjE7tm5+nujJeHLGpAPi157n1VwdkekO4Lvu53 gnjOw9zdf6fYt2M40uSV7CvZfaQ/weaTj5RGyTKeXgRQDOS+XrYP44ckrZVJHv9hNK 0RI/prRi3lzYNFJ8YFTTkjW1c/KknZBLGdFaoJG5Xx655MRuXf6iJEcO1O9bi7ur1/ P/Z/VlmG1RtNZChbqrg1DE09zSdKfta2WGH3UjbCBxFYyWbxRVmyTJxIqngTQ8CeGR 6N4dHCFtLOGvfo8qfYJMfbn/EAIrcyXsF9IOxNHp/g/7c6nE6lojb0qA8+B6TXdLAc iBDH32pN6SkaQ== Date: Thu, 23 Apr 2026 10:13:05 +0100 From: Sudeep Holla To: Yeoreum Yun Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Sudeep Holla , linux-integrity@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, zohar@linux.ibm.com, roberto.sassu@huawei.com, dmitry.kasatkin@gmail.com, eric.snowberg@oracle.com, jarkko@kernel.org, jgg@ziepe.ca, maz@kernel.org, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, noodles@meta.com, sebastianene@google.com Subject: Re: [RFC PATCH v2 3/4] firmware: arm_ffa: revert ffa_init() initcall level to device_initcall Message-ID: <20260423-rich-caped-seal-b00d07@sudeepholla> References: <20260422162449.1814615-1-yeoreum.yun@arm.com> <20260422162449.1814615-4-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260422162449.1814615-4-yeoreum.yun@arm.com> On Wed, Apr 22, 2026 at 05:24:48PM +0100, Yeoreum Yun wrote: > commit 0e0546eabcd6 ("firmware: arm_ffa: Change initcall level of ffa_init() to rootfs_initcall") > changed the initcall level of ffa_init() to rootfs_initcall to address > an issue where IMA could not properly recognize the TPM device. > > However, this introduces a problem: pKVM fails to handle any FF-A calls > because it cannot trap the FFA_VERSION call invoked by ffa_init(). > > Since the IMA init function level has been changed to late_initcall_sync, > there is no longer a need to keep ffa_init() at rootfs_initcall. > Revert it back to device_initcall. > I prefer you do actual git revert on the original commit for this as well as the TPM CRM FFA driver explaining how the original idea fails in certain conditions. Don't add it as separate commit and add fixes tag to the original commits. -- Regards, Sudeep