From: Paul Moore <paul@paul-moore.com>
To: linux-security-module@vger.kernel.org
Cc: John Johansen <john.johansen@canonical.com>
Subject: [PATCH] apparmor: leverage audit_log_n_untrustedstring() when possible
Date: Fri, 17 Jul 2026 17:52:55 -0400 [thread overview]
Message-ID: <20260717215254.383183-2-paul@paul-moore.com> (raw)
Make use of the audit_log_n_untrustedstring() function to simplify the
code in aa_label_xaudit().
Signed-off-by: Paul Moore <paul@paul-moore.com>
---
security/apparmor/label.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/security/apparmor/label.c b/security/apparmor/label.c
index 3fd384d8c41a..a165cadf8249 100644
--- a/security/apparmor/label.c
+++ b/security/apparmor/label.c
@@ -1743,10 +1743,7 @@ void aa_label_xaudit(struct audit_buffer *ab, struct aa_ns *ns,
str = (char *) label->hname;
len = strlen(str);
}
- if (audit_string_contains_control(str, len))
- audit_log_n_hex(ab, str, len);
- else
- audit_log_n_string(ab, str, len);
+ audit_log_n_untrustedstring(ab, str, len);
kfree(name);
}
--
2.55.0
next reply other threads:[~2026-07-17 21:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 21:52 Paul Moore [this message]
2026-07-17 21:54 ` [PATCH] apparmor: leverage audit_log_n_untrustedstring() when possible Paul Moore
2026-07-17 21:57 ` Paul Moore
2026-07-17 23:52 ` Ryan Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717215254.383183-2-paul@paul-moore.com \
--to=paul@paul-moore.com \
--cc=john.johansen@canonical.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox