From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B70747A875 for ; Wed, 12 Aug 2026 16:34:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786552457; cv=none; b=JgylRoVKqKxkO/P1XqushrYRbFc7NQlkNdUU7y0LnRRI9JwrkfwVeiFK2LEPBlGlMVYGu01/041LGBLY/fknKQ2m7dQURAEXAvrFFsXYhs0tGieLf/PAQXtc2trEA8A43n+wirCmyrtPtwzlyS6Ds4LsP4yEmUnBV03qKDbIIV8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786552457; c=relaxed/simple; bh=+2zRxSvjAmqwYOE+tKwr1WSnbMWmNOH7W2evqTcz3wE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:content-type; b=HIeU+L1bsFlOp4iEyXeY6Llm/gId4E5Fbn49aZl/uMGTjwQXoT7HQhp99QVuhRxnYOoDjzIL1cfc5uveSmQMRgOntIgCPU8W3rZnPzlGj/WL0OEFVOqf9MsEuO4ac2i7R3RdpMOkoRDkUpCmxsi9niaMhXI2Co9B/smpx07xRd4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MXdg/PP/; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MXdg/PP/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786552454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JpTxCCo1JlTQTpMq2MklUewzzbiQjhVKEixoMx1SLYE=; b=MXdg/PP/lBAbJIyoMJb/LWW1V/9nyoAJKEkgj3xZS5+bQc6nQ3Zi79Wvwyi6Do2QUMrnC4 EUNAyYWoEjLwbidNPkbZHNwoZ/SzdkBH/Z8nVeqFXAC1US62AoT9RkMemyRhYrzHeJTxAH fEXg4STGGDlFfocXOLJcnQj9Hh1FtF8= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-355-rnie3BrMNuqh1rYf3ZMijw-1; Wed, 12 Aug 2026 12:34:04 -0400 X-MC-Unique: rnie3BrMNuqh1rYf3ZMijw-1 X-Mimecast-MFC-AGG-ID: rnie3BrMNuqh1rYf3ZMijw_1786552442 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 57089180028A; Wed, 12 Aug 2026 16:34:02 +0000 (UTC) Received: from thuth-p1g4.redhat.corp (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4E4443002D30; Wed, 12 Aug 2026 16:33:56 +0000 (UTC) From: Thomas Huth To: Eric Biggers , "Jason A. Donenfeld" , Ard Biesheuvel Cc: Herbert Xu , "David S. Miller" , James Bottomley , Jarkko Sakkinen , Mimi Zohar , David Howells , Paul Moore , James Morris , "Serge E. Hallyn" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org Subject: [PATCH 3/3] lib/crypto: sha1: Use hmac_sha1_zeroize_ctx() instead of memzero_explicit() Date: Wed, 12 Aug 2026 18:33:36 +0200 Message-ID: <20260812163336.3103835-4-thuth@redhat.com> In-Reply-To: <20260812163336.3103835-1-thuth@redhat.com> References: <20260812163336.3103835-1-thuth@redhat.com> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-MFC-PROC-ID: s27ptzQdzIxe-qsTtqOXrFWaio5dgIwl09i5jwar-3I_1786552442 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true From: Thomas Huth It's only cosmetics, but since we have the new hmac_sha1_zeroize_ctx() function anyway, we can also use it here. Signed-off-by: Thomas Huth --- lib/crypto/sha1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/crypto/sha1.c b/lib/crypto/sha1.c index b687b89d97cb4..c4361ef77166e 100644 --- a/lib/crypto/sha1.c +++ b/lib/crypto/sha1.c @@ -275,7 +275,7 @@ void hmac_sha1_final(struct hmac_sha1_ctx *ctx, u8 out[SHA1_DIGEST_SIZE]) for (size_t i = 0; i < SHA1_DIGEST_SIZE; i += 4) put_unaligned_be32(ctx->ostate.h[i / 4], out + i); - memzero_explicit(ctx, sizeof(*ctx)); + hmac_sha1_zeroize_ctx(ctx); } EXPORT_SYMBOL_GPL(hmac_sha1_final); -- 2.55.0