From: sashiko-bot@kernel.org
Cc: linux-security-module@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] keys: Return user session keyring on lookup
Date: Thu, 24 Sep 2026 06:01:43 +0000 [thread overview]
Message-ID: <20260924060143.A73091F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260924055521.1981957-2-jarkko@kernel.org>
> A process without a session keyring looking up KEY_SPEC_SESSION_KEYRING
> without KEY_LOOKUP_CREATE mutates the credentials. This causes struct creds
> instances shared with other subsystems to become stale.
>
> Address this by returning the resolved user session keyring directly
> without installing it into credentials.
>
> Suggested-by: Jann Horn <jannh@google.com>
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260924055521.1981957-1-jarkko@kernel.org?part=1
next prev parent reply other threads:[~2026-09-24 6:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 5:55 [RFC PATCH 0/2] keys: Address lookup_user_key() mutability Jarkko Sakkinen
2026-09-24 5:55 ` [RFC PATCH 1/2] keys: Return user session keyring on lookup Jarkko Sakkinen
2026-09-24 6:01 ` sashiko-bot [this message]
2026-09-24 5:55 ` [RFC PATCH 2/2] keys: Reject keyring creation with overridden credentials Jarkko Sakkinen
2026-09-24 6:03 ` sashiko-bot
2026-10-04 17:54 ` [RFC PATCH 0/2] keys: Address lookup_user_key() mutability Jarkko Sakkinen
2026-10-05 13:09 ` Serge E. Hallyn
2026-10-05 18:46 ` Jarkko Sakkinen
2026-10-06 18:52 ` Serge Hallyn (AMD)
2026-10-08 14:26 ` Jarkko Sakkinen
2026-10-08 15:25 ` Serge E. Hallyn
2026-10-08 20:00 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924060143.A73091F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox