From: Jonathan Cameron <jic23@kernel.org>
To: Atharva Tiwari <atharvatiwarilinuxdev@gmail.com>
Cc: alexandre.belloni@bootlin.com, andy@kernel.org,
asahi@lists.linux.dev, bhelgaas@google.com, bp@alien8.de,
brgl@kernel.org, dave.hansen@linux.intel.com,
dlechner@baylibre.com, dmitry.kasatkin@gmail.com,
eric.snowberg@oracle.com, griffin@kroah.com, hansg@kernel.org,
hpa@zytor.com, ilpo.jarvinen@linux.intel.com, j@jannau.net,
jarkko@kernel.org, jmorris@namei.org, keyrings@vger.kernel.org,
lee@kernel.org, lenb@kernel.org, linusw@kernel.org,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-iio@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux@roeck-us.net,
mfd@lists.linux.dev, mingo@redhat.com, neal@gompa.dev,
nuno.sa@analog.com, paul@paul-moore.com, pavel@kernel.org,
platform-driver-x86@vger.kernel.org, rafael@kernel.org,
roberto.sassu@huawei.com, serge@hallyn.com, sre@kernel.org,
sven@kernel.org, tglx@kernel.org, wim@linux-watchdog.org,
x86@kernel.org, zohar@linux.ibm.com
Subject: Re: [RFC PATCH 14/14] mfd/macsmc: add ioctl to access smc keys
Date: Sun, 8 Nov 2026 01:35:26 +0000 [thread overview]
Message-ID: <20261108013526.1ce3b9b2@jic23-hlaptop> (raw)
In-Reply-To: <20261104195317.8284-1-atharvatiwarilinuxdev@gmail.com>
On Wed, 4 Nov 2026 14:53:17 -0500
Atharva Tiwari <atharvatiwarilinuxdev@gmail.com> wrote:
> > If this isn't matching some legacy interface, then we need more
> > on what these do. Maybe they are suited to some other kernel
> > interface? In particular they might need the various controls
> > on how destructive they are that something like fwctl brings.
> >
> > Generally an arbitrary opaque path to firmware isn't a good idea...
> >
> > Jonathan
>
> Here its required, if we write CPU/GPU Pstates and PPT to
> some keys (MSTS MSPC HE0N), we can reduce the temp by 10C
> And We can fix the dreaded PROCHOT signals on macs, Giving
> Same temps as macOS.
Being able to control them is good, but ideally we'd map
these to appropriate subsystems rather than having a magic
interface for them. There might of course be some gaps
that need plugging, but custom ioctl is rarely the way to go
(except maybe due to legacy userspace we don't want to touch!)
Jonathan
>
> But you and Sasha are right, that exposing all keys is a
> bad idea, so i have restricted writing to some keys only.
>
next prev parent reply other threads:[~2026-11-08 1:35 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 8:51 [RFC PATCH 00/14] Add macsmc support for Intel Macs, replacing applesmc Atharva Tiwari
2026-10-29 8:51 ` [RFC PATCH 01/14] treewide: Add backend for macsmc Atharva Tiwari
2026-10-29 9:20 ` sashiko-bot
2026-10-29 8:51 ` [RFC PATCH 02/14] platform/x86: add backend for macsmc in intel macs Atharva Tiwari
2026-10-29 9:23 ` sashiko-bot
2026-10-29 12:59 ` Ilpo Järvinen
2026-10-29 8:52 ` [RFC PATCH 03/14] watchdog: add driver for apple smc Atharva Tiwari
2026-10-29 9:17 ` sashiko-bot
2026-10-29 13:30 ` Andy Shevchenko
2026-10-29 8:52 ` [RFC PATCH 04/14] iio/light: add new driver for macsmc Atharva Tiwari
2026-10-29 9:17 ` sashiko-bot
2026-11-01 1:28 ` Jonathan Cameron
2026-10-29 8:52 ` [RFC PATCH 05/14] iio/accel: add driver for apple SMS Atharva Tiwari
2026-10-29 9:20 ` sashiko-bot
2026-11-01 1:35 ` Jonathan Cameron
2026-10-29 8:52 ` [RFC PATCH 06/14] leds: add support for macsmc kbl Atharva Tiwari
2026-10-29 9:16 ` sashiko-bot
2026-10-29 8:52 ` [RFC PATCH 07/14] rtc: add support for x86 macs in macsmc-rtc Atharva Tiwari
2026-10-29 9:15 ` sashiko-bot
2026-10-29 8:52 ` [RFC PATCH 08/14] treewide: Add a flag to detect the Apple T2 chip Atharva Tiwari
2026-10-29 9:11 ` sashiko-bot
2026-10-29 8:52 ` [RFC PATCH 09/14] treewide: disable other rtc's in t2 macs Atharva Tiwari
2026-10-29 9:16 ` sashiko-bot
2026-10-29 8:52 ` [RFC PATCH 10/14] power/supply: add support for x86 macs in macsmc-power Atharva Tiwari
2026-10-29 9:19 ` sashiko-bot
2026-10-29 8:52 ` [RFC PATCH 11/14] acpi: disable battery and adapter for x86 apple machines Atharva Tiwari
2026-10-29 9:13 ` sashiko-bot
2026-10-29 8:52 ` [RFC PATCH 12/14] hwmon/macsmc: add more types Atharva Tiwari
2026-10-29 9:18 ` sashiko-bot
2026-10-29 8:52 ` [RFC PATCH 13/14] hwmon: add support for x86 macs in macsmc-hwmon Atharva Tiwari
2026-10-29 9:20 ` sashiko-bot
2026-10-29 8:52 ` [RFC PATCH 14/14] mfd/macsmc: add ioctl to access smc keys Atharva Tiwari
2026-10-29 9:26 ` sashiko-bot
2026-11-01 1:38 ` Jonathan Cameron
2026-11-04 19:53 ` Atharva Tiwari
2026-11-08 1:35 ` Jonathan Cameron [this message]
2026-11-01 1:07 ` [RFC PATCH 00/14] Add macsmc support for Intel Macs, replacing applesmc Jonathan Cameron
2026-11-04 19:45 ` Atharva Tiwari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261108013526.1ce3b9b2@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andy@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=atharvatiwarilinuxdev@gmail.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=brgl@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=dlechner@baylibre.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=eric.snowberg@oracle.com \
--cc=griffin@kroah.com \
--cc=hansg@kernel.org \
--cc=hpa@zytor.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=j@jannau.net \
--cc=jarkko@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=lee@kernel.org \
--cc=lenb@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mfd@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=neal@gompa.dev \
--cc=nuno.sa@analog.com \
--cc=paul@paul-moore.com \
--cc=pavel@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=roberto.sassu@huawei.com \
--cc=serge@hallyn.com \
--cc=sre@kernel.org \
--cc=sven@kernel.org \
--cc=tglx@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=x86@kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox