From: Tingmao Wang <m@maowtm.org>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: "Tingmao Wang" <m@maowtm.org>,
"Günther Noack" <gnoack3000@gmail.com>,
linux-security-module@vger.kernel.org
Subject: [PATCH] landlock: Add missing EINVAL case in the doc for landlock_add_rule
Date: Mon, 16 Nov 2026 23:31:37 +0000 [thread overview]
Message-ID: <20261116233139.206924-1-m@maowtm.org> (raw)
This is another way it can return EINVAL but is not documented. Documenting
it is useful to help rule out errors.
Signed-off-by: Tingmao Wang <m@maowtm.org>
---
security/landlock/syscalls.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/landlock/syscalls.c b/security/landlock/syscalls.c
index fb5af318b69b..29e9d5d7399d 100644
--- a/security/landlock/syscalls.c
+++ b/security/landlock/syscalls.c
@@ -629,6 +629,7 @@ static int add_rule_capability(struct landlock_ruleset *const ruleset,
* - %EAFNOSUPPORT: @rule_type is %LANDLOCK_RULE_NET_PORT but TCP/IP is not
* supported by the running kernel;
* - %EINVAL: @flags is not valid;
+ * - %EINVAL: @rule_type is not valid;
* - %EINVAL: The rule accesses are inconsistent (i.e.
* &landlock_path_beneath_attr.allowed_access or
* &landlock_net_port_attr.allowed_access is not a subset of the ruleset
base-commit: 57493c3b7f449a60d1c43322158671b98684f9b1
--
2.56.1
next reply other threads:[~2026-11-16 23:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 23:31 Tingmao Wang [this message]
2026-11-16 23:34 ` [PATCH] landlock: Add missing EINVAL case in the doc for landlock_add_rule sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116233139.206924-1-m@maowtm.org \
--to=m@maowtm.org \
--cc=gnoack3000@gmail.com \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@digikod.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox