Linux Security Modules development
 help / color / mirror / Atom feed
From: "Maxime Bélair" <maxime.belair@canonical.com>
To: John Johansen <john.johansen@canonical.com>,
	Georgia Garcia <georgia.garcia@canonical.com>
Cc: apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org,
	"Maxime Bélair" <maxime.belair@canonical.com>
Subject: [PATCH 3/4] apparmor: write the feature set to a file at build time
Date: Tue, 17 Nov 2026 14:50:09 +0100	[thread overview]
Message-ID: <20261117135042.78238-4-maxime.belair@canonical.com> (raw)
In-Reply-To: <20261117135042.78238-1-maxime.belair@canonical.com>

apparmor_parser compiles policy for the feature set of the kernel,
which libapparmor reads from /sys/kernel/security/apparmor/features,
and the policy cache is keyed on that set. The cache for a kernel can
therefore only be filled once that kernel runs, and the first boot
into a kernel with a new feature set compiles all of the policy.

Every entry of the features directory comes from a static table of
constants. So write the set to security/apparmor/features when the
kernel is built, in the format that libapparmor flattens the directory
to. Policy can then be compiled when a kernel is installed:

  apparmor_parser --kernel-features=<file> ...

Signed-off-by: Maxime Bélair <maxime.belair@canonical.com>
---
 security/apparmor/.gitignore         |   2 +
 security/apparmor/Makefile           |  15 ++++
 security/apparmor/apparmorfs.c       |   1 +
 security/apparmor/gen_features.c     | 100 +++++++++++++++++++++++++++
 security/apparmor/include/features.h |   5 +-
 5 files changed, 121 insertions(+), 2 deletions(-)
 create mode 100644 security/apparmor/gen_features.c

diff --git a/security/apparmor/.gitignore b/security/apparmor/.gitignore
index 921cc7c3e835..ff816ca0f22b 100644
--- a/security/apparmor/.gitignore
+++ b/security/apparmor/.gitignore
@@ -3,3 +3,5 @@ net_names.h
 capability_names.h
 rlim_names.h
 feature_masks.h
+/features
+/gen_features
diff --git a/security/apparmor/Makefile b/security/apparmor/Makefile
index 7d20a09cb116..400655ec78a3 100644
--- a/security/apparmor/Makefile
+++ b/security/apparmor/Makefile
@@ -102,6 +102,21 @@ cmd_make-rlim = echo "static const char *const rlim_names[RLIM_NLIMITS] = {" \
 quiet_cmd_make-masks = GEN     $@
 cmd_make-masks = grep -h '^\#define AA_SFS_' $(filter %.h,$^) > $@
 
+# Write the feature set to a file, with a host program that is built from the
+# feature tables. It needs the kernel configuration, and -idirafter keeps the
+# other kernel headers behind the ones of the host.
+hostprogs := gen_features
+HOSTCFLAGS_gen_features.o := -include $(srctree)/include/linux/kconfig.h \
+			     -idirafter $(objtree)/include
+always-y += features
+
+quiet_cmd_gen_features = GEN     $@
+      cmd_gen_features = $< > $@
+
+$(obj)/features: $(obj)/gen_features FORCE
+	$(call if_changed,gen_features)
+
+$(obj)/gen_features : $(obj)/feature_masks.h
 $(obj)/apparmorfs.o : $(obj)/feature_masks.h
 $(obj)/capability.o : $(obj)/capability_names.h
 $(obj)/net.o : $(obj)/net_names.h
diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c
index 4ca449b108df..b897d2840d77 100644
--- a/security/apparmor/apparmorfs.c
+++ b/security/apparmor/apparmorfs.c
@@ -1255,6 +1255,7 @@ static const struct file_operations aa_sfs_access = {
 	.llseek		= generic_file_llseek,
 };
 
+/* gen_features.c prints the same values at build time, keep them in sync */
 static int aa_sfs_seq_show(struct seq_file *seq, void *v)
 {
 	struct aa_sfs_entry *fs_file = seq->private;
diff --git a/security/apparmor/gen_features.c b/security/apparmor/gen_features.c
new file mode 100644
index 000000000000..978a1b06ab4b
--- /dev/null
+++ b/security/apparmor/gen_features.c
@@ -0,0 +1,100 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * AppArmor security module
+ *
+ * This program writes the feature set of the kernel that is being built, the
+ * way libapparmor flattens /sys/kernel/security/apparmor/features on the
+ * running kernel. The policy cache is keyed on it, so the output has to be
+ * the same byte for byte: the entries of a directory in the strcmp() order of
+ * their names, each as
+ *
+ *	<name> {<entries of the directory>}\n
+ *	<name> {<content of the file>}\n
+ *
+ * Copyright 2026 Canonical Ltd.
+ */
+
+#include <stdbool.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+
+enum aa_sfs_type {
+	AA_SFS_TYPE_BOOLEAN,
+	AA_SFS_TYPE_STRING,
+	AA_SFS_TYPE_U64,
+	AA_SFS_TYPE_DIR,
+};
+
+/* The members of the kernel's struct aa_sfs_entry that the tables set */
+struct aa_sfs_entry {
+	const char *name;
+	enum aa_sfs_type v_type;
+	union {
+		bool boolean;
+		const char *string;
+		unsigned long u64;
+		struct aa_sfs_entry *files;
+	} v;
+};
+
+#define AA_SFS_FILE_BOOLEAN(_name, _value) \
+	{ .name = (_name), .v_type = AA_SFS_TYPE_BOOLEAN, .v.boolean = (_value) }
+#define AA_SFS_FILE_STRING(_name, _value) \
+	{ .name = (_name), .v_type = AA_SFS_TYPE_STRING, .v.string = (_value) }
+#define AA_SFS_FILE_U64(_name, _value) \
+	{ .name = (_name), .v_type = AA_SFS_TYPE_U64, .v.u64 = (_value) }
+#define AA_SFS_DIR(_name, _value) \
+	{ .name = (_name), .v_type = AA_SFS_TYPE_DIR, .v.files = (_value) }
+
+#include "feature_masks.h"
+#include "include/features.h"
+
+static int cmp_entries(const void *a, const void *b)
+{
+	const struct aa_sfs_entry *x = a, *y = b;
+
+	return strcmp(x->name, y->name);
+}
+
+static void print_dir(struct aa_sfs_entry *dir)
+{
+	struct aa_sfs_entry *entry;
+	size_t count = 0;
+
+	while (dir[count].name)
+		count++;
+
+	qsort(dir, count, sizeof(*dir), cmp_entries);
+
+	for (entry = dir; entry->name; entry++) {
+		/* libapparmor skips these */
+		if (entry->name[0] == '.')
+			continue;
+
+		printf("%s {", entry->name);
+		switch (entry->v_type) {
+		case AA_SFS_TYPE_BOOLEAN:
+			printf("%s\n", entry->v.boolean ? "yes" : "no");
+			break;
+		case AA_SFS_TYPE_STRING:
+			printf("%s\n", entry->v.string);
+			break;
+		case AA_SFS_TYPE_U64:
+			/* "%#08lx" in the kernel, which prints 0x for 0 too */
+			printf("0x%06lx\n", entry->v.u64);
+			break;
+		case AA_SFS_TYPE_DIR:
+			print_dir(entry->v.files);
+			break;
+		}
+		printf("}\n");
+	}
+}
+
+int main(void)
+{
+	print_dir(aa_sfs_entry_features);
+
+	return fflush(stdout) || ferror(stdout);
+}
diff --git a/security/apparmor/include/features.h b/security/apparmor/include/features.h
index dc38f54abec6..aadd8391ae9a 100644
--- a/security/apparmor/include/features.h
+++ b/security/apparmor/include/features.h
@@ -3,8 +3,9 @@
  * AppArmor security module
  *
  * This file contains the tables behind the securityfs features directory,
- * /sys/kernel/security/apparmor/features. It defines them, so it is for
- * apparmorfs.c alone.
+ * /sys/kernel/security/apparmor/features. It defines them, for apparmorfs.c
+ * and for the host program gen_features.c, so it cannot depend on kernel
+ * headers.
  *
  * Copyright (C) 1998-2008 Novell/SUSE
  * Copyright 2009-2026 Canonical Ltd.
-- 
2.51.0


  parent reply	other threads:[~2026-11-17 13:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 13:50 [PATCH 0/4] apparmor: provide the kernel feature set at build time Maxime Bélair
2026-11-17 13:50 ` [PATCH 1/4] apparmor: move the feature tables to a header Maxime Bélair
2026-11-17 13:55   ` sashiko-bot
2026-11-17 13:50 ` [PATCH 2/4] apparmor: make the feature tables build without kernel headers Maxime Bélair
2026-11-17 13:55   ` sashiko-bot
2026-11-17 13:50 ` Maxime Bélair [this message]
2026-11-17 14:00   ` [PATCH 3/4] apparmor: write the feature set to a file at build time sashiko-bot
2026-11-17 13:50 ` [PATCH 4/4] kbuild: install the AppArmor feature set with the modules Maxime Bélair
2026-11-17 13:58   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117135042.78238-4-maxime.belair@canonical.com \
    --to=maxime.belair@canonical.com \
    --cc=apparmor@lists.ubuntu.com \
    --cc=georgia.garcia@canonical.com \
    --cc=john.johansen@canonical.com \
    --cc=linux-security-module@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox