From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B84CC43610 for ; Fri, 9 Nov 2018 15:05:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D0D020827 for ; Fri, 9 Nov 2018 15:05:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D0D020827 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-security-module-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728331AbeKJAq0 (ORCPT ); Fri, 9 Nov 2018 19:46:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56748 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727781AbeKJAq0 (ORCPT ); Fri, 9 Nov 2018 19:46:26 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6F80E3082DDB; Fri, 9 Nov 2018 15:05:29 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-113.rdu2.redhat.com [10.10.120.113]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2624F1974A; Fri, 9 Nov 2018 15:05:28 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1541772875.3990.29.camel@linux.ibm.com> References: <1541772875.3990.29.camel@linux.ibm.com> <1541743166-5036-1-git-send-email-zohar@linux.ibm.com> <27927.1541769383@warthog.procyon.org.uk> To: Mimi Zohar Cc: dhowells@redhat.com, keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH] KEYS: revert requiring signature "encoding" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <20320.1541775927.1@warthog.procyon.org.uk> Date: Fri, 09 Nov 2018 15:05:27 +0000 Message-ID: <20321.1541775927@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Fri, 09 Nov 2018 15:05:29 +0000 (UTC) Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: Mimi Zohar wrote: > Looking the patch over again, do you prefer the duplicate call or > defining a local variable and using the ternary conditional operator > ("?:") like this: > > bool rsa = false; > > if (!(sig->encoding) && strcmp(pkey->pkey_algo, "rsa") == 0) > rsa = true; > > ret = software_key_determine_akcipher(rsa ? "pkcs1" : sig->encoding, > sig->hash_algo, > pkey, alg_name); Might be better to do: const char *encoding = sig->encoding; if (!encoding && strcmp(pkey->pkey_algo, "rsa") == 0) encoding = "pkcs1"; ret = software_key_determine_akcipher(encoding, ... David