From mboxrd@z Thu Jan 1 00:00:00 1970 From: dave.hansen@intel.com (Dave Hansen) Date: Mon, 10 Sep 2018 14:09:26 -0700 Subject: [RFC 09/12] mm: Restrict memory encryption to anonymous VMA's In-Reply-To: <20180910210716.GB26766@intel.com> References: <84154fd2-7c27-0fd2-f339-15e144a5df49@intel.com> <20180910210716.GB26766@intel.com> Message-ID: <21db220c-257b-f9b5-2b41-992267f0552b@intel.com> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On 09/10/2018 02:07 PM, Jarkko Sakkinen wrote: > On Mon, Sep 10, 2018 at 11:57:49AM -0700, Dave Hansen wrote: >> On 09/10/2018 11:21 AM, Sakkinen, Jarkko wrote: >>>> +/* >>>> + * Encrypted mprotect is only supported on anonymous mappings. >>>> + * All VMA's in the requested range must be anonymous. If this >>>> + * test fails on any single VMA, the entire mprotect request fails. >>>> + */ >>> kdoc >> kdoc what? You want this comment in kdoc format? Why? > If there is a header comment for a function anyway, why wouldn't you > put it to kdoc-format? Because this is a shorter and more concise way to document the function. kdoc isn't universally the best thing to do for function comments.