From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8B1F22F2E; Mon, 21 Apr 2025 21:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745271867; cv=none; b=TM0EnkDBberlXOhGmU6PIgROVsdpH9tkOEnPPYtaPrbxVrdlADeQmE7kn3HRvFuxeAvC3eYCbItgbsH+hd/K5lWI9z7kVFLlXavC+sh/fOuxRSG5oEhw//fBcr+XSX2LHwd6w4Cxt4aDNcw50JlSvrEedFyZKdcxpPWhule0LYY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745271867; c=relaxed/simple; bh=PT5gupkicFt2esXi8ztZd0p0piQA/lhlpgm4nsM6Gak=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZcBBZ2i19nGtLZrikHGuGAo+TrU4tOiQ84qQP7jJQBC7kR1IDjIVuA6ROr5rcUCODYCzr6V5knjWadl/qmQ5k/ghSdr7VG/0PZH4ceD9aaonKp62cqKAUiUSGujTTcKNMk5FyYPsBNiHICwOI7ZA05MsVBr9wWtV3QAPY1gYJnk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=GbSjsjQD; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="GbSjsjQD" Received: from [100.70.160.93] (unknown [172.172.34.12]) by linux.microsoft.com (Postfix) with ESMTPSA id EC27F20BCAD1; Mon, 21 Apr 2025 14:44:22 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com EC27F20BCAD1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1745271865; bh=aqS4FuLxGEljkPeVAmETGzCYTa7oTLpRxOsxhZi2z6I=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=GbSjsjQDyLZCMRTA1svAS4y/9qHUB+OZmR0RALHX7CiHBX0SfVDQF2KvSK/aRO5Eh iS4wa32R1E8AI+ZpHnNY6B7Yxbxk2a+kpdOHCMOyvB+YEfqMVPxAavxLO747qIkUzH PLMsOCr0PoA0zODXoafNJko3zm3p9RoVwF3oMBj4= Message-ID: <2434013a-72d2-450d-a043-fcea916ef22d@linux.microsoft.com> Date: Mon, 21 Apr 2025 14:44:21 -0700 Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 3/9] kexec: define functions to map and unmap segments To: Mimi Zohar , Baoquan He Cc: stefanb@linux.ibm.com, roberto.sassu@huaweicloud.com, roberto.sassu@huawei.com, eric.snowberg@oracle.com, ebiederm@xmission.com, paul@paul-moore.com, code@tyhicks.com, bauermann@kolabnow.com, linux-integrity@vger.kernel.org, kexec@lists.infradead.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, madvenka@linux.microsoft.com, nramas@linux.microsoft.com, James.Bottomley@hansenpartnership.com, vgoyal@redhat.com, dyoung@redhat.com References: <20250416021028.1403-1-chenste@linux.microsoft.com> <20250416021028.1403-4-chenste@linux.microsoft.com> <6c3aca6815edf25828bad6f0b4587a040ada03c5.camel@linux.ibm.com> Content-Language: en-US From: steven chen In-Reply-To: <6c3aca6815edf25828bad6f0b4587a040ada03c5.camel@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/21/2025 2:35 PM, Mimi Zohar wrote: > On Mon, 2025-04-21 at 13:40 -0700, steven chen wrote: >> On 4/21/2025 7:18 AM, Mimi Zohar wrote: >>> On Mon, 2025-04-21 at 09:51 -0400, Mimi Zohar wrote: >>>> On Fri, 2025-04-18 at 12:36 +0800, Baoquan He wrote: >>>>> On 04/15/25 at 07:10pm, steven chen wrote: >>>>>> From: Steven Chen >>>>> ^^^^^^ >>>> As James Bottomley previously explained[1], if you haven't made any changes to >>>> Tushar's patch, then the very first line of the patch description would be >>>> "From: Tushar Sugandhi " followed by a blank line. >>>> If there is a minor change, you would add ": explanation". >>>> For example: >>>> >>>> Steven Chen : modified patch description >>> To clarify: This line would be included below with your Signed-off-by tag. >>> >>>> [1] >>>> https://lore.kernel.org/lkml/58e70121aaee33679ac295847197c1e5511b2a81.camel@HansenPartnership.com/ >>>> >>>>>> Implement kimage_map_segment() to enable IMA to map the measurement log >>>>>> list to the kimage structure during the kexec 'load' stage. This function >>>>>> gathers the source pages within the specified address range, and maps them >>>>>> to a contiguous virtual address range. >>>>>> >>>>>> This is a preparation for later usage. >>>>>> >>>>>> Implement kimage_unmap_segment() for unmapping segments using vunmap(). >>>>>> >>>>>> From: Tushar Sugandhi >>>>> ^^^^^^ >>>> Neither "Author:" nor "From:" belong here. Please remove. >>>> >>>>>> Signed-off-by: Tushar Sugandhi >>>>> ^^^^^^^ >>>> Having Tushar's "Signed-off-by" tag and yours below indicate that you modified >>>> the original author's patch. >>> To clarify: "Just" having Tushar's "Signed-off-by" tag and yours below indicate >>> that you modified the original author's patch. >> Hi Mimi, >> >> I will update it in next version. > Sigh, after reviewing your discussion with Baoquan, I'm not sure whether my > comment this morning added more confusion. > > Option 1: Include a single "From:" line at the very top to change the author > from yourself to someone else. The following from line would make Tushar the > patch author: From: Tushar Sugandhi > > In addition, any minor changes you made should be added before your Signed-off- > by tag. For example: Steven Chen : modified patch > description > > Option 2: As mentioned previously and now discussed with Baoquan, adding "Co- > developed-by:" > >> Just wandering are you done reviewing or still need more time? > Yes, I just finished reviewing/testing. The patch descriptions are looking much > better. As Baoquan reminded you, please remember to update the "ima: define and > call ima_alloc_kexec_file_buf()" patch description. > > thanks, > > Mimi Thanks a lot! >>>>>> Cc: Eric Biederman >>>>>> Cc: Baoquan He >>>>>> Cc: Vivek Goyal >>>>>> Cc: Dave Young >>>>>> Signed-off-by: steven chen >>>>> ^^^^^ >>>>> >>>>> The signing on this patch is a little confusing. I can't see who is the >>>>> real author, who is the co-author, between you and Tushar. You may need >>>>> to refer to Documentation/process/5.Posting.rst to make that clear. >>>>> >>>>>> Acked-by: Baoquan He