From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792424517; b=PHYiKU+fL0sEbfjESkCkfKYsxZAF03yBFHnYJMH/HwMoW89Luvr7WgiyKj07+VhHRIII ZiRfRg++jo5XRyFEDq2y4SmIDmn/n6yUYw4y85dglSIH+FZ2/V6AHQdgiW/N+D8qJzc+J h5w1JmpdEcWUynEy/kpJEVfE82yCCLJZI1i+eRfNog26SQj25aG9vM/ea7j6+eoG22tJG HSKGWNT10urK8P+nyaIgIyXE0DDqsQ7NZTlD1vYhmvGoKNcfcIa3hpS23rxZP7/3vEBFM f2hh5fiAuDFt8nMPwAk6MsDQD+0LlbTphZj+QYncUfUn1yadfZybq4yekjnEO7CFkyw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792424517; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:Received:Organization:From:In-Reply-To: References:To:Cc:Subject:MIME-Version:Date:Message-ID:X-Scanned-By: X-Mimecast-MFC-PROC-ID:X-Mimecast-Originator:Content-Type:Content-ID; bh=NaN+mCZydYoju135pw7TWTUw+J0RdYin2G9nyjNDB/Y=; b=ia1+l+HEtCNgIUgBzOPJ4pFoREnCFa1+USMEGmkoF9QiMPc+mOBliQ6eH5B2I+Iv30Hc Py7d3x4FWFh/erRBHI2IfPDcdowJZV7laT3EBD52WcjdV5F5FffOY4KRqVVpGzOx9fMgd wLnmihZRTAt6UAwOoeTXwA2tpjR07My/durxKvinQCs8YCHp4+XJt956x63K8ihfP/5st dyP9OAVjX8uSQRxTml85ijrTXOQIPpRK0C50K0bseOLer/R4boVQLGyVS78zFe4ZZwlcn 12G6qeroW+Irx+Mza1cHMJy/CrbK7lTeVjKLPKUah3foWauuKV0kko6cLxIJF8DicnA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=i+Ft0x3T; arc=none smtp.remote-ip=170.10.129.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF7EA606EFD4 for ; Mon, 19 Oct 2026 15:41:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org DF7EA606EFD4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=i+Ft0x3T DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792424516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NaN+mCZydYoju135pw7TWTUw+J0RdYin2G9nyjNDB/Y=; b=i+Ft0x3TaUe1uyF9tkXen8CYwLBP8nFYSslxgr/Y9KaOiT3HmZv5kHasMX/+8za40OfTR1 P84lIj7EYFkS2OF94/vVtZ3LQWLWTXbXChZHJqZDAvruPDHllqOmgVhsrvQtEOZ9omv+8I 2tMmbF1Z5KbI0DjSudQlDIuc4DRYIOU= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-177-FPDmvhMOPueC8vIQAl0fXg-1; Mon, 19 Oct 2026 15:41:52 +0000 X-MC-Unique: FPDmvhMOPueC8vIQAl0fXg-1 X-Mimecast-MFC-AGG-ID: FPDmvhMOPueC8vIQAl0fXg_1792424510 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 467561955F7F; Mon, 19 Oct 2026 15:41:50 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.44.48.11]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 32C9D30000E3; Mon, 19 Oct 2026 15:41:46 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20261019142516.300040-7-jarkko@kernel.org> References: <20261019142516.300040-7-jarkko@kernel.org> <20261019142516.300040-1-jarkko@kernel.org> To: Jarkko Sakkinen Cc: dhowells@redhat.com, keyrings@vger.kernel.org, Eric Biggers , stable@vger.kernel.org, Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , linux-security-module@vger.kernel.org (open list:SECURITY SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: Re: [RFC PATCH 6/8] KEYS: Prevent overflow of user->qnbytes in key_alloc() X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Date: Mon, 19 Oct 2026 16:41:45 +0100 Message-ID: <2610123.1792424505@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-MFC-PROC-ID: ze5W8Uuh_tXwPKyEOjfXhhiAmR8KwL0ibVHNG8ydW4E_1792424510 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-ID: <2610122.1792424505.1@warthog.procyon.org.uk> I suggest merging patches 4 and 6, then add: Reviewed-by: David Howells